Skip to contentSkip to conversation

Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

PATCH In review srishti sharma 2 participants 6 messages Jun 9, 2017 – Jun 12, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

Fixed alignment so that it matched open paranthesis .

---
 drivers/staging/ks7010/ks_hostif.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks_hostif.c +2 -2
index 697347b..e3c11be 100644
@@ -1659,8 +1659,8 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
 
 static
 void hostif_power_mgmt_request(struct ks_wlan_private *priv,
-				unsigned long mode, unsigned long wake_up,
-				unsigned long receive_dtims)
+			       unsigned long mode, unsigned long wake_up,
+			       unsigned long receive_dtims)
 {
	struct hostif_power_mgmt_request_t *pp;

--
2.7.4

#1 lore raw
Quoted 23 lines · srishti sharma

Fixed alignment so that it matched open paranthesis .

---
 drivers/staging/ks7010/ks_hostif.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks_hostif.c +2 -3
index 697347b..e3c11be 100644
@@ -1659,8 +1659,8 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
 
 static
 void hostif_power_mgmt_request(struct ks_wlan_private *priv,
-                               unsigned long mode, unsigned long wake_up,
-                               unsigned long receive_dtims)
+                              unsigned long mode, unsigned long wake_up,
+                              unsigned long receive_dtims)
 {
        struct hostif_power_mgmt_request_t *pp;
 
--
Quoted 1 line

2.7.4

Okay , this doesn't look right , please ignore ! Sorry

Thanks
Srishti

#2 lore raw
Quoted 4 lines · srishti sharma
Quoted 3 lines · srishti sharma

Fixed alignment so that it matched open paranthesis .

^ ^

You're the opposite of me. My mama named me with capital letters but informally I sometimes use lower case. Your formal name is lower case but informally you use caps. :P

Quoted 3 lines

Okay , this doesn't look right , please ignore ! Sorry

It actually is correct, it just looks wrong in the diff because of the extra " +-" character at the beginning of the line.

Quoted 2 lines

Thanks
Srishti

regards,
dan carpenter

#3 lore raw
Quoted 15 lines · Dan Carpenter
Quoted 4 lines · srishti sharma
Quoted 3 lines · srishti sharma

Fixed alignment so that it matched open paranthesis .

^ ^

You're the opposite of me. My mama named me with capital letters but informally I sometimes use lower case. Your formal name is lower case but informally you use caps. :P

Quoted 3 lines

Okay , this doesn't look right , please ignore ! Sorry

Quoted 9 lines

It actually is correct, it just looks wrong in the diff because of the extra " +-" character at the beginning of the line.

Quoted 2 lines

Thanks
Srishti

regards,
dan carpenter

Hey,

Thanks :) , so will this be accepted ?

Regards,
Srishti

#4 lore raw
Quoted 3 lines · srishti sharma

Thanks :) , so will this be accepted ?

Probably, yes. Unless Greg has already dropped it because you said to drop it.

regards,
dan carpenter

#5 lore raw
Quoted 11 lines · Dan Carpenter
Quoted 3 lines · srishti sharma

Thanks :) , so will this be accepted ?

Probably, yes. Unless Greg has already dropped it because you said to drop it.

regards,
dan carpenter

Okay, Thanks :)

Regards,
srishti