Skip to contentSkip to conversation

bitbake.conf: Add whoami to HOSTTOOLS

PATCH In review Jonathan Liu 5 participants 7 messages Jun 11, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bitbake.conf: Add whoami to HOSTTOOLS

The whoami command is used when building the Linux kernel in scripts/mkcompile_h to embed the build user that is visible in /proc/version.

---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +1 -1
index 3ad905c917..4f20aa3d1c 100644
@@ -465,7 +465,7 @@ HOSTTOOLS += " \
     mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd python python2 \
     python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh sha256sum \
     sleep sort split stat strings strip tail tar tee test touch tr true uname \
-    uniq wc wget which xargs \
+    uniq wc wget which whoami xargs \
 "
 
 # Tools needed to run testimage runtime image testing
Signature · 1 line
2.12.2
#1 lore raw
Quoted 14 lines · Jonathan Liu

The whoami command is used when building the Linux kernel in scripts/mkcompile_h to embed the build user that is visible in /proc/version.

---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +0 -0
index 3ad905c917..4f20aa3d1c 100644

meta/conf/bitbake.conf HOSTTOOLS += " \ · line 468

Quoted 5 lines
meta/conf/bitbake.conf +1 -1
@@ -465,7 +465,7 @@ HOSTTOOLS += " \
     mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd python python2 \
     python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh sha256sum \
     sleep sort split stat strings strip tail tar tee test touch tr true uname \
-    uniq wc wget which xargs \
+    uniq wc wget which whoami xargs \

I think it might be better to not use whoami at all to begin with, it might be good for reproducibility
too.

Quoted 11 lines
meta/conf/bitbake.conf +0 -1
 "
 
 # Tools needed to run testimage runtime image testing
--

2.12.2

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw
Quoted 10 lines · Khem Raj
Quoted 9 lines · Jonathan Liu

The whoami command is used when building the Linux kernel in scripts/mkcompile_h to embed the build user that is visible in /proc/version.

---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

meta/conf/bitbake.conf HOSTTOOLS += " \ · line 468

Quoted 10 lines
meta/conf/bitbake.conf +1 -1
index 3ad905c917..4f20aa3d1c 100644
@@ -465,7 +465,7 @@ HOSTTOOLS += " \
     mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd python python2 \
     python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh sha256sum \
     sleep sort split stat strings strip tail tar tee test touch tr true uname \
-    uniq wc wget which xargs \
+    uniq wc wget which whoami xargs \

I think it might be better to not use whoami at all to begin with, it might be good for reproducibility too.

There was this whole discussion about adding whoami couple months ago - Richard won't accept the change:

http://lists.openembedded.org/pipermail/openembedded-core/2017-March/134878.html

Signature · 1 line
Denys
#3 lore raw
In reply to Jonathan Liu
Quoted 4 lines · Jonathan Liu

The whoami command is used when building the Linux kernel in scripts/mkcompile_h to embed the build user that is visible in /proc/version.

Not if you have oe-core a5a14edb5573e33667b63b1e34cb4e19d075e8e8, in theory at least. Unless you have an entirely from-scratch recipe that doesn't use kernel.bbclass, I guess.

Ross

#4 lore raw
Quoted 10 lines · Ross
Quoted 4 lines · Jonathan Liu

The whoami command is used when building the Linux kernel in scripts/mkcompile_h to embed the build user that is visible in /proc/version.

Not if you have oe-core a5a14edb5573e33667b63b1e34cb4e19d075e8e8, in theory at least. Unless you have an entirely from-scratch recipe that doesn't use kernel.bbclass, I guess.

Not in pyro - care to backport?

Signature · 1 line
Denys
#5 lore raw
Quoted 9 lines · Denys Dmytriyenko
Quoted 8 lines · Ross
Quoted 5 lines · Jonathan Liu

The whoami command is used when building the Linux kernel in scripts/mkcompile_h to embed the build user that is visible in /proc/version.

Quoted 6 lines
Quoted 5 lines

Not if you have oe-core a5a14edb5573e33667b63b1e34cb4e19d075e8e8, in theory
at least.  Unless you have an entirely from-scratch recipe that doesn't use
kernel.bbclass, I guess.

Not in pyro - care to backport?

I've backported this onto the pyro branch.

Cheers,

Richard

#6 lore raw
Quoted 10 lines · Richard Purdie
Quoted 9 lines · Denys Dmytriyenko
Quoted 8 lines · Ross
Quoted 5 lines · Jonathan Liu

The whoami command is used when building the Linux kernel in scripts/mkcompile_h to embed the build user that is visible in /proc/version.

Quoted 8 lines
Quoted 6 lines
Quoted 5 lines

Not if you have oe-core a5a14edb5573e33667b63b1e34cb4e19d075e8e8, in theory
at least.  Unless you have an entirely from-scratch recipe that doesn't use
kernel.bbclass, I guess.

Not in pyro - care to backport?

I've backported this onto the pyro branch.

Thanks! I guess I've missed it...

Signature · 1 line
Denys