Patch "crypto: gcm - wait for crypto op not signal safe" has been added to the 4.9-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
crypto: gcm - wait for crypto op not signal safe
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
crypto-gcm-wait-for-crypto-op-not-signal-safe.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
f3ad587070d6bd961ab942b3fd7a85d00dfc934bMon Sep 17 00:00:00 2001
From: Gilad Ben-Yossef <[email protected]>
Date: Thu, 18 May 2017 16:29:25 +0300
Subject: crypto: gcm - wait for crypto op not signal safe
From: Gilad Ben-Yossef <[email protected]>
commit f3ad587070d6bd961ab942b3fd7a85d00dfc934b upstream.
crypto_gcm_setkey() was using wait_for_completion_interruptible() to wait for completion of async crypto op but if a signal occurs it may return before DMA ops of HW crypto provider finish, thus corrupting the data buffer that is kfree'ed in this case.
Resolve this by using wait_for_completion() instead.
--- crypto/gcm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
crypto/gcm.c +2 -4
@@ -152,10 +152,8 @@ static int crypto_gcm_setkey(struct cryp err =crypto_skcipher_encrypt (&data->req);if (err == -EINPROGRESS || err == -EBUSY ) { - err =wait_for_completion_interruptible ( - &data->result.completion); -if (!err) - err = data->result.err; +wait_for_completion (&data->result.completion); + err = data->result.err; }if (err)
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/crypto-drbg-wait-for-crypto-op-not-signal-safe.patch queue-4.9/crypto-gcm-wait-for-crypto-op-not-signal-safe.patch queue-4.9/crypto-asymmetric_keys-handle-ebusy-due-to-backlog-correctly.patch