FAILED: patch "[PATCH] iio: proximity: as3935: fix iio_trigger_poll issue" failed to apply to 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jun 12, 2017

Subsystems (2)

Stable branch IIO

lore

Share & tools

lore

[email protected]

author maintainer

2017-06-12 08:44 UTC #0 lore raw

The patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 9122b54f266ddee09654fe3fbc503c1a60f4a01c Mon Sep 17 00:00:00 2001

From: Matt Ranostay <[email protected]>
Date: Thu, 4 May 2017 17:32:19 -0700
Subject: [PATCH] iio: proximity: as3935: fix iio_trigger_poll issue

Using iio_trigger_poll() can oops when multiple interrupts happen before the first is handled.

Use iio_trigger_poll_chained() instead and use the timestamp when processed, since it will be in theory be 2 ms max latency.

Fixes 24ddb0e4bba4 ("iio: Add AS3935 lightning sensor support")

Cc [email protected]

Signed-off-by Matt Ranostay <[email protected]>

Signed-off-by Jonathan Cameron <[email protected]>

drivers/iio/proximity/as3935.c +2 -2

index 2e94e5ad884b..aa4df0dcc8c9 100644
@@ -215,7 +215,7 @@ static irqreturn_t as3935_trigger_handler(int irq, void *private)
 
 	st->buffer[0] = val & AS3935_DATA_MASK;
 	iio_push_to_buffers_with_timestamp(indio_dev, &st->buffer,
-					   pf->timestamp);
+					   iio_get_time_ns(indio_dev));
 err_read:
 	iio_trigger_notify_done(indio_dev->trig);

@@ -244,7 +244,7 @@ static void as3935_event_work(struct work_struct *work)
 
 	switch (val) {
 	case AS3935_EVENT_INT:
-		iio_trigger_poll(st->trig);
+		iio_trigger_poll_chained(st->trig);
 		break;
 	case AS3935_NOISE_INT:
 		dev_warn(&st->spi->dev, "noise level is too high\n");