Skip to contentSkip to conversation

drm/amdgpu/gfx9: fix compute ring doorbell index

PATCH In review Alex Deucher 2 participants 2 messages Jun 13, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/gfx9: fix compute ring doorbell index

This got lost when the code was revamped. Copy/paste bug from gfx8.

Fixes 78c168342 (drm/amdgpu: allow split of queues with kfd at queue granularity v4)
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +1 -1
index e9dd2c1..5f3c369 100644
@@ -1293,7 +1293,7 @@ static int gfx_v9_0_compute_ring_init(struct amdgpu_device *adev, int ring_id,
 
 	ring->ring_obj = NULL;
 	ring->use_doorbell = true;
-	ring->doorbell_index = AMDGPU_DOORBELL_MEC_RING0 + ring_id;
+	ring->doorbell_index = (AMDGPU_DOORBELL_MEC_RING0 + ring_id) << 1;
 	ring->eop_gpu_addr = adev->gfx.mec.hpd_eop_gpu_addr
 				+ (ring_id * GFX9_MEC_HPD_SIZE);
 	sprintf(ring->name, "comp_%d.%d.%d", ring->me, ring->pipe, ring->queue);
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1497322879-19446-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

Reviewed-by Junwei Zhang
#2 lore raw
Quoted 6 lines · Alex Deucher

This got lost when the code was revamped. Copy/paste bug from gfx8.

Fixes 78c168342 (drm/amdgpu: allow split of queues with kfd at queue granularity v4)
Quoted 10 lines
---
  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +0 -0
index e9dd2c1..5f3c369 100644

drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c static int gfx_v9_0_compute_ring_init(struct amdgpu_device *adev, int ring_id, · line 1299

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +1 -1
@@ -1293,7 +1293,7 @@ static int gfx_v9_0_compute_ring_init(struct amdgpu_device *adev, int ring_id,
 
  	ring->ring_obj = NULL;
  	ring->use_doorbell = true;
-	ring->doorbell_index = AMDGPU_DOORBELL_MEC_RING0 + ring_id;
+	ring->doorbell_index = (AMDGPU_DOORBELL_MEC_RING0 + ring_id) << 1;
  	ring->eop_gpu_addr = adev->gfx.mec.hpd_eop_gpu_addr
  				+ (ring_id * GFX9_MEC_HPD_SIZE);
  	sprintf(ring->name, "comp_%d.%d.%d", ring->me, ring->pipe, ring->queue);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx