Skip to contentSkip to conversation

tests/chamelium: Require HPD storm control for basic hotplug test

PATCH In review Paul Kocialkowski 1 participant 3 messages Jun 12, 2017 – Jun 13, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/chamelium: Require HPD storm control for basic hotplug test

The basic hotplug test (test_basic_hotplug) makes calls to igt_hpd_storm_set_threshold, which requires HPD storm control.

This adds a check for that control, since it was missing.

---
 tests/chamelium.c | 2 ++
 1 file changed, 2 insertions(+)
tests/chamelium.c +2 -0
index dc631161..acd17886 100644
@@ -153,6 +153,8 @@ test_basic_hotplug(data_t *data, struct chamelium_port *port)
 	struct udev_monitor *mon = igt_watch_hotplug();
 	int i;
 
+	igt_require_hpd_storm_ctl(data->drm_fd);
+
 	reset_state(data, port);
 	igt_hpd_storm_set_threshold(data->drm_fd, 0);
 
Signature · 6 lines
2.13.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 4 lines · Paul Kocialkowski

The basic hotplug test (test_basic_hotplug) makes calls to igt_hpd_storm_set_threshold, which requires HPD storm control.

This adds a check for that control, since it was missing.

+Lyude for Chamelium patches

Quoted 19 lines
---
 tests/chamelium.c | 2 ++
 1 file changed, 2 insertions(+)
tests/chamelium.c +2 -0
index dc631161..acd17886 100644
@@ -153,6 +153,8 @@ test_basic_hotplug(data_t *data, struct chamelium_port
 *port)
 	struct udev_monitor *mon = igt_watch_hotplug();
 	int i;
 
+	igt_require_hpd_storm_ctl(data->drm_fd);
+
 	reset_state(data, port);
 	igt_hpd_storm_set_threshold(data->drm_fd, 0);
Signature · 6 lines
Paul Kocialkowski <[email protected]>
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 7 lines · Paul Kocialkowski
Quoted 4 lines · Paul Kocialkowski

The basic hotplug test (test_basic_hotplug) makes calls to igt_hpd_storm_set_threshold, which requires HPD storm control.

This adds a check for that control, since it was missing.

+Lyude for Chamelium patches

... and adding back others. Sorry for the noise.

Quoted 19 lines
Quoted 19 lines
---
 tests/chamelium.c | 2 ++
 1 file changed, 2 insertions(+)
tests/chamelium.c +2 -0
index dc631161..acd17886 100644
@@ -153,6 +153,8 @@ test_basic_hotplug(data_t *data, struct chamelium_port
 *port)
 	struct udev_monitor *mon = igt_watch_hotplug();
 	int i;
 
+	igt_require_hpd_storm_ctl(data->drm_fd);
+
 	reset_state(data, port);
 	igt_hpd_storm_set_threshold(data->drm_fd, 0);
Signature · 6 lines
Paul Kocialkowski <[email protected]>
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx