Skip to contentSkip to conversation

staging: android: ion: heap: Improve code style

PATCH New Aliaksei Karaliou 1 participant 2 messages Jun 13, 2017 1 message not in the archive Staging

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Aliaksei Karaliou

author
#1 lore raw

Sorry for that and thank you for reply.
Regarding scripts/get_maintainer.pl, it seems that trying to avoid disturbing too much people it turned out vice versa. And it was wrong idea to ignoring vger mailing list since I need this patch to be in public.

Best regards,
Aliaksei.

Aliaksei Karaliou (1):
staging: android: ion: Improve memory alloc style

 drivers/staging/android/ion/ion_system_heap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.1.4
author
#2 lore raw

PATCH v2 1/1 staging: android: ion: Improve memory alloc style

Use variable name instead of structure name to get size of memory to allocate as proposed by checkpatch.pl

Signed-off-by Aliaksei Karaliou <[email protected]>
---
 drivers/staging/android/ion/ion_system_heap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/android/ion/ion_system_heap.c +3 -3
index c50f2d9..5964bf2 100644
@@ -153,7 +153,7 @@ static int ion_system_heap_allocate(struct ion_heap *heap,
 		max_order = compound_order(page);
 		i++;
 	}
-	table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
+	table = kmalloc(sizeof(*table), GFP_KERNEL);
 	if (!table)
 		goto free_pages;
 

@@ -383,7 +383,7 @@ static int ion_system_contig_heap_allocate(struct ion_heap *heap,
 	for (i = len >> PAGE_SHIFT; i < (1 << order); i++)
 		__free_page(page + i);
 
-	table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
+	table = kmalloc(sizeof(*table), GFP_KERNEL);
 	if (!table) {
 		ret = -ENOMEM;
 		goto free_pages;

@@ -433,7 +433,7 @@ static struct ion_heap *__ion_system_contig_heap_create(void)
 {
 	struct ion_heap *heap;
 
-	heap = kzalloc(sizeof(struct ion_heap), GFP_KERNEL);
+	heap = kzalloc(sizeof(*heap), GFP_KERNEL);
 	if (!heap)
 		return ERR_PTR(-ENOMEM);
 	heap->ops = &kmalloc_ops;
Signature · 1 line
2.1.4