Skip to contentSkip to conversation

Patch "sierra_net: Skip validating irrelevant fields for IDLE LSIs" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jun 15, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

sierra_net: Skip validating irrelevant fields for IDLE LSIs

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
sierra_net-skip-validating-irrelevant-fields-for-idle-lsis.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Jun 15 11:13:01 CEST 2017

From: Stefan Br�ns <[email protected]>
Date: Tue, 23 May 2017 21:53:42 -0400
Subject: sierra_net: Skip validating irrelevant fields for IDLE LSIs

From: Stefan Br�ns <[email protected]>

[ Upstream commit 764895d3039e903dac3a70f219949efe43d036a0 ]

When the context is deactivated, the link_type is set to 0xff, which triggers a warning message, and results in a wrong link status, as the LSI is ignored.

---
 drivers/net/usb/sierra_net.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/net/usb/sierra_net.c +7 -7
@@ -365,6 +365,13 @@ static int sierra_net_parse_lsi(struct u
 		return -1;
 	}
 
+	/* Validate the session state */
+	if (lsi->session_state == SIERRA_NET_SESSION_IDLE) {
+		netdev_err(dev->net, "Session idle, 0x%02x\n",
+			   lsi->session_state);
+		return 0;
+	}
+
 	/* Validate the protocol  - only support UMTS for now */
 	if (lsi->protocol != SIERRA_NET_PROTOCOL_UMTS) {
 		netdev_err(dev->net, "Protocol unsupported, 0x%02x\n",
@@ -386,13 +393,6 @@ static int sierra_net_parse_lsi(struct u
 		return 0;
 	}
 
-	/* Validate the session state */
-	if (lsi->session_state == SIERRA_NET_SESSION_IDLE) {
-		netdev_err(dev->net, "Session idle, 0x%02x\n",
-			lsi->session_state);
-		return 0;
-	}
-
 	/* Set link_sense true */
 	return 1;
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/sierra_net-skip-validating-irrelevant-fields-for-idle-lsis.patch queue-4.4/sierra_net-add-support-for-ipv6-and-dual-stack-link-sense-indications.patch