Skip to contentSkip to conversation

Patch "drm/i915: Fix 90/270 rotated coordinates for FBC" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jun 15, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

drm/i915: Fix 90/270 rotated coordinates for FBC

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     drm-i915-fix-90-270-rotated-coordinates-for-fbc.patch

and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 1065467ed8e2601bf2d7018cf47c557ccbea3769 Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <[email protected]>
Date: Fri, 31 Mar 2017 21:00:56 +0300
Subject: drm/i915: Fix 90/270 rotated coordinates for FBC
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Ville Syrjälä <[email protected]>

commit 1065467ed8e2601bf2d7018cf47c557ccbea3769 upstream.

The clipped src coordinates have already been rotated by 270 degrees for when the plane rotation is 90/270 degrees, hence the FBC code should no longer swap the width and height.

Cc Tvrtko Ursulin <[email protected]>
Cc Paulo Zanoni <[email protected]>
Fixes b63a16f6cd89 ("drm/i915: Compute display surface offset in the plane check hook for SKL+")
(cherry picked from commit 73714c05df97d7527e7eaaa771472ef2ede46fa3)
---
 drivers/gpu/drm/i915/intel_fbc.c |   19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/intel_fbc.c +7 -12
@@ -82,20 +82,10 @@ static unsigned int get_crtc_fence_y_off
 static void intel_fbc_get_plane_source_size(struct intel_fbc_state_cache *cache,
 					    int *width, int *height)
 {
-	int w, h;
-
-	if (drm_rotation_90_or_270(cache->plane.rotation)) {
-		w = cache->plane.src_h;
-		h = cache->plane.src_w;
-	} else {
-		w = cache->plane.src_w;
-		h = cache->plane.src_h;
-	}
-
 	if (width)
-		*width = w;
+		*width = cache->plane.src_w;
 	if (height)
-		*height = h;
+		*height = cache->plane.src_h;
 }
 
 static int intel_fbc_calculate_cfb_size(struct drm_i915_private *dev_priv,
@@ -747,6 +737,11 @@ static void intel_fbc_update_state_cache
 			ilk_pipe_pixel_rate(crtc_state);
 
 	cache->plane.rotation = plane_state->base.rotation;
+	/*
+	 * Src coordinates are already rotated by 270 degrees for
+	 * the 90/270 degree plane rotation cases (to match the
+	 * GTT mapping), hence no need to account for rotation here.
+	 */
 	cache->plane.src_w = drm_rect_width(&plane_state->base.src) >> 16;
 	cache->plane.src_h = drm_rect_height(&plane_state->base.src) >> 16;
 	cache->plane.visible = plane_state->base.visible;

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/drm-i915-fix-90-270-rotated-coordinates-for-fbc.patch queue-4.11/drm-i915-workaround-vlv-chv-dsi-scanline-counter-hardware-fail.patch queue-4.11/drm-i915-guard-against-i915_ggtt_disable_guc-being-invoked-unconditionally.patch queue-4.11/drm-i915-prevent-the-system-suspend-complete-optimization.patch