ehci-pci: Prepare for usage of readl()/writel() accessors

We used to have opencoded ehci_readl()/writel() which required no external functions to be called.

Now with attempt to switch to generic readl()/writel() accessors
we see a missing declaration of those accessors in ehci-ppc4xx.
Something like that happens if applied
http://patchwork.ozlabs.org/patch/726714/:
--------------------------------->8---------------------------
CC drivers/usb/host/ehci-pci.o
In file included from drivers/usb/host/ehci-pci.c:14:0:
drivers/usb/host/ehci-pci.c: In function 'ehci_pci_init':
drivers/usb/host/ehci.h:108:36: warning: implicit declaration of function 'readl' [-Wimplicit-function-declaration]

 #define ehci_readl(x)  cpu_to_le32(readl(x))
                                    ^
drivers/usb/host/ehci.h:23:26: note: in definition of macro 'HC_LENGTH'
 #define HC_LENGTH(p)  (((p) >> 0) & 0x00ff)
                          ^
include/linux/byteorder/generic.h:89:21: note: in expansion of macro '__cpu_to_le32'
 #define cpu_to_le32 __cpu_to_le32
                     ^~~~~~~~~~~~~
drivers/usb/host/ehci-pci.c:33:14: note: in expansion of macro 'ehci_readl'
    HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
              ^~~~~~~~~~

--------------------------------->8---------------------------

This the same fix as we have for "ehci-ppc4xx" in
83cb46c286b "ehci-ppc4xx: Prepare for usage of readl()/writel() accessors".

Signed-off-by Alexey Brodkin <[email protected]>

Cc Simon Glass <[email protected]>

Cc Tom Rini <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Stefan Roese <[email protected]>

---
 drivers/usb/host/ehci-pci.c | 1 +
 1 file changed, 1 insertion(+)

drivers/usb/host/ehci-pci.c +1 -0

index f20fc3354cc0..dceba4bd7aa1 100644
@@ -10,6 +10,7 @@
 #include <errno.h>
 #include <pci.h>
 #include <usb.h>
+#include <asm/io.h>
 
 #include "ehci.h"
 

Quoted 3 lines · Alexey Brodkin

We used to have opencoded ehci_readl()/writel() which required no external functions to be called.

Applied, thanks.

Hi Marek,

Quoted 5 lines · Alexey Brodkin

Quoted 3 lines

We used to have opencoded ehci_readl()/writel() which required no external functions to be called.

Quoted 1 line

Applied, thanks.

Now when we get everything ready for building fine
see https://travis-ci.org/abrodkin/u-boot/builds/238394634
could you please apply my old patch with conversion to platform- specific accessors?

I mean this one http://patchwork.ozlabs.org/patch/726714/

Quoted 2 lines · Alexey Brodkin

Hi Marek,

Hi,

Quoted 17 lines · Marek Vasut

Quoted 8 lines · Alexey Brodkin

Quoted 4 lines

We used to have opencoded ehci_readl()/writel() which required no external functions to be called.

Applied, thanks.

Now when we get everything ready for building fine
see https://urldefense.proofpoint.com/v2/url?u=https-3A__travis-2Dci.org_abrodkin_u-2Dboot_builds_238394634&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lq
deeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=6zuMNpU2sqTEauB3FyrBrLk_RR6Ko4zfrK2Jtmw_WLo&s=FxquunKntzi7lTQhylwOxuVroRKBcROy8uH08Fs84AI&e= could you please apply my old patch with conversion to platform-
specific accessors?

Quoted 2 lines

I mean this one https://urldefense.proofpoint.com/v2/url?u=http-3A__patchwork.ozlabs.org_patch_726714_&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSS
Ees0GFDDl656eViXO7breS55ytWkhpk5R81I&m=6zuMNpU2sqTEauB3FyrBrLk_RR6Ko4zfrK2Jtmw_WLo&s=qFC1yxpdfhfEijsMnTgN0g_-1ckUkUNt8RdsQBJC1f0&e=

Yes, rebase, retest and repost.

Quoted 2 lines · Alexey Brodkin

Hi Marek,

Hi,

Quoted 17 lines · Marek Vasut

Quoted 8 lines · Alexey Brodkin

Quoted 4 lines

We used to have opencoded ehci_readl()/writel() which required no external functions to be called.

Applied, thanks.

Now when we get everything ready for building fine
see https://urldefense.proofpoint.com/v2/url?u=https-3A__travis-2Dci.org_abrodkin_u-2Dboot_builds_238394634&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lq
deeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=6zuMNpU2sqTEauB3FyrBrLk_RR6Ko4zfrK2Jtmw_WLo&s=FxquunKntzi7lTQhylwOxuVroRKBcROy8uH08Fs84AI&e= could you please apply my old patch with conversion to platform-
specific accessors?

Quoted 2 lines

I mean this one https://urldefense.proofpoint.com/v2/url?u=http-3A__patchwork.ozlabs.org_patch_726714_&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSS
Ees0GFDDl656eViXO7breS55ytWkhpk5R81I&m=6zuMNpU2sqTEauB3FyrBrLk_RR6Ko4zfrK2Jtmw_WLo&s=qFC1yxpdfhfEijsMnTgN0g_-1ckUkUNt8RdsQBJC1f0&e=

Yes, rebase, retest and repost.

Hi Marek,

Quoted 23 lines · Marek Vasut

Quoted 2 lines · Alexey Brodkin

Hi Marek,

Hi,

Quoted 17 lines · Marek Vasut

Quoted 8 lines · Alexey Brodkin

Quoted 4 lines

We used to have opencoded ehci_readl()/writel() which required no external functions to be called.

Applied, thanks.

Now when we get everything ready for building fine
see https://urldefense.proofpoint.com/v2/url?u=https-3A__travis-2Dci.org_abrodkin_u-2Dboot_builds_238394634&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lq
deeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=6zuMNpU2sqTEauB3FyrBrLk_RR6Ko4zfrK2Jtmw_WLo&s=FxquunKntzi7lTQhylwOxuVroRKBcROy8uH08Fs84AI&e= could you please apply my old patch with conversion to platform-
specific accessors?

Quoted 5 lines

Quoted 2 lines

I mean this one https://urldefense.proofpoint.com/v2/url?u=http-3A__patchwork.ozlabs.org_patch_726714_&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSS
Ees0GFDDl656eViXO7breS55ytWkhpk5R81I&m=6zuMNpU2sqTEauB3FyrBrLk_RR6Ko4zfrK2Jtmw_WLo&s=qFC1yxpdfhfEijsMnTgN0g_-1ckUkUNt8RdsQBJC1f0&e=

Yes, rebase, retest and repost.

That last comment was about another patch which depends on this change. So I'm wondering if there's a reason for
"ehci-pci: Prepare for usage of readl()/writel() accessors" to not be applied?

And BTW I did retested and resent the one that depends on this, see http://patchwork.ozlabs.org/patch/771436/.

Quoted 36 lines · Alexey Brodkin

Hi Marek,

Quoted 23 lines · Marek Vasut

Quoted 2 lines · Alexey Brodkin

Hi Marek,

Hi,

Quoted 17 lines · Marek Vasut

Quoted 8 lines · Alexey Brodkin

Quoted 4 lines

We used to have opencoded ehci_readl()/writel() which required no external functions to be called.

Applied, thanks.

Now when we get everything ready for building fine
see https://urldefense.proofpoint.com/v2/url?u=https-3A__travis-2Dci.org_abrodkin_u-2Dboot_builds_238394634&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lq
deeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=6zuMNpU2sqTEauB3FyrBrLk_RR6Ko4zfrK2Jtmw_WLo&s=FxquunKntzi7lTQhylwOxuVroRKBcROy8uH08Fs84AI&e= could you please apply my old patch with conversion to platform-
specific accessors?

Quoted 5 lines

Quoted 2 lines

I mean this one https://urldefense.proofpoint.com/v2/url?u=http-3A__patchwork.ozlabs.org_patch_726714_&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSS
Ees0GFDDl656eViXO7breS55ytWkhpk5R81I&m=6zuMNpU2sqTEauB3FyrBrLk_RR6Ko4zfrK2Jtmw_WLo&s=qFC1yxpdfhfEijsMnTgN0g_-1ckUkUNt8RdsQBJC1f0&e=

Yes, rebase, retest and repost.

That last comment was about another patch which depends on this change. So I'm wondering if there's a reason for
"ehci-pci: Prepare for usage of readl()/writel() accessors" to not be applied?

Quoted 2 lines

And BTW I did retested and resent the one that depends on this, see http://patchwork.ozlabs.org/patch/771436/.

If there are any patches you want applied, please repost. And no , I am NOT taking random PW links.

Quoted 37 lines · Marek Vasut

Quoted 36 lines · Alexey Brodkin

Hi Marek,

Quoted 23 lines · Marek Vasut

Quoted 2 lines · Alexey Brodkin

Hi Marek,

Hi,

Quoted 17 lines · Marek Vasut

Quoted 8 lines · Alexey Brodkin

Quoted 4 lines

We used to have opencoded ehci_readl()/writel() which required no external functions to be called.

Applied, thanks.

Now when we get everything ready for building fine
see https://urldefense.proofpoint.com/v2/url?u=https-3A__travis-2Dci.org_abrodkin_u-2Dboot_builds_238394634&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lq
deeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=6zuMNpU2sqTEauB3FyrBrLk_RR6Ko4zfrK2Jtmw_WLo&s=FxquunKntzi7lTQhylwOxuVroRKBcROy8uH08Fs84AI&e= could you please apply my old patch with conversion to platform-
specific accessors?

Quoted 5 lines

Quoted 2 lines

I mean this one https://urldefense.proofpoint.com/v2/url?u=http-3A__patchwork.ozlabs.org_patch_726714_&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSS
Ees0GFDDl656eViXO7breS55ytWkhpk5R81I&m=6zuMNpU2sqTEauB3FyrBrLk_RR6Ko4zfrK2Jtmw_WLo&s=qFC1yxpdfhfEijsMnTgN0g_-1ckUkUNt8RdsQBJC1f0&e=

Yes, rebase, retest and repost.

That last comment was about another patch which depends on this change. So I'm wondering if there's a reason for
"ehci-pci: Prepare for usage of readl()/writel() accessors" to not be applied?

Quoted 5 lines

Quoted 2 lines

And BTW I did retested and resent the one that depends on this, see http://patchwork.ozlabs.org/patch/771436/.

If there are any patches you want applied, please repost. And no , I am NOT taking random PW links.

That's not a random link, that's his repost from 10 days ago.

Quoted 4 lines · Tom Rini

Quoted 2 lines · Marek Vasut

On 06/14/2017 11:55 AM, Alexey Brodkin wrote:

Clearly that patch did NOT land in my mailbox.

Hi Marek,

Quoted 5 lines · Marek Vasut

Quoted 4 lines · Tom Rini

Quoted 2 lines · Marek Vasut

On 06/14/2017 11:55 AM, Alexey Brodkin wrote:

[snip]

Quoted 1 line

Quoted 1 line

Clearly that patch did NOT land in my mailbox.

So true, I meant to move your email from "cc" to "to" field but got distracted and ended-up sending the email to everybody but not you.

Please pardon my inattention.

Quoted 17 lines · Alexey Brodkin

Hi Marek,

Quoted 8 lines · Marek Vasut

Quoted 6 lines · Tom Rini

Quoted 3 lines · Marek Vasut

On 06/14/2017 11:55 AM, Alexey Brodkin wrote:

[snip]

Quoted 2 lines

Quoted 6 lines

Quoted 1 line

Clearly that patch did NOT land in my mailbox.

So true, I meant to move your email from "cc" to "to" field but got distracted and ended-up sending the email to everybody but not you.

Please pardon my inattention.

Anyway, I applied it to usb, hopefully it doesn't blow up this time.