Skip to contentSkip to conversation

Patch "cpufreq: conservative: Allow down_threshold to take values from 1 to 10" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jun 18, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

cpufreq: conservative: Allow down_threshold to take values from 1 to 10

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
cpufreq-conservative-allow-down_threshold-to-take-values-from-1-to-10.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b8e11f7d2791bd9320be1c6e772a60b2aa093e45 Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?Tomasz=20Wilczy=C5=84ski?= <[email protected]>
Date: Sun, 11 Jun 2017 17:28:39 +0900
Subject: cpufreq: conservative: Allow down_threshold to take values from 1 to 10
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Tomasz Wilczyński <[email protected]>

commit b8e11f7d2791bd9320be1c6e772a60b2aa093e45 upstream.

Commit 27ed3cd2ebf4 (cpufreq: conservative: Fix the logic in frequency decrease checking) removed the 10 point substraction when comparing the load against down_threshold but did not remove the related limit for the down_threshold value. As a result, down_threshold lower than 11 is not allowed even though values from 1 to 10 do work correctly too. The comment ("cannot be lower than 11 otherwise freq will not fall") also does not apply after removing the substraction.

For this reason, allow down_threshold to take any value from 1 to 99 and fix the related comment.

Fixes 27ed3cd2ebf4 (cpufreq: conservative: Fix the logic in frequency decrease checking)
---
 drivers/cpufreq/cpufreq_conservative.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cpufreq/cpufreq_conservative.c +2 -2
@@ -185,8 +185,8 @@ static ssize_t store_down_threshold(stru
 	int ret;
 	ret = sscanf(buf, "%u", &input);
 
-	/* cannot be lower than 11 otherwise freq will not fall */
-	if (ret != 1 || input < 11 || input > 100 ||
+	/* cannot be lower than 1 otherwise freq will not fall */
+	if (ret != 1 || input < 1 || input > 100 ||
 			input >= dbs_data->up_threshold)
 		return -EINVAL;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/cpufreq-conservative-allow-down_threshold-to-take-values-from-1-to-10.patch