Skip to contentSkip to conversation

Patch "mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jun 18, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mfd-omap-usb-tll-fix-inverted-bit-use-for-usb-tll-mode.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 8b8a84c54aff4256d592dc18346c65ecf6811b45 Mon Sep 17 00:00:00 2001

From: Tony Lindgren <[email protected]>
Date: Sat, 15 Apr 2017 10:05:08 -0700
Subject: mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode

From: Tony Lindgren <[email protected]>

commit 8b8a84c54aff4256d592dc18346c65ecf6811b45 upstream.

Commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver") added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF bit the wrong way. The comments in the code are correct, but the inverted use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register to be enabled instead of disabled unlike what the comments say.

Without this change the Wrigley 3G LTE modem on droid 4 EHCI bus can be only pinged few times before it stops responding.

Fixes 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
---
 drivers/mfd/omap-usb-tll.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/omap-usb-tll.c +1 -1
@@ -377,8 +377,8 @@ int omap_tll_init(struct usbhs_omap_plat
 				 * and use SDR Mode
 				 */
 				reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
-					| OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
 					| OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
+				reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
 			} else if (pdata->port_mode[i] ==
 					OMAP_EHCI_PORT_MODE_HSIC) {
 				/*

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/mfd-cpcap-fix-bad-use-of-irq-sense-register.patch queue-4.11/mfd-omap-usb-tll-fix-inverted-bit-use-for-usb-tll-mode.patch queue-4.11/mfd-cpcap-fix-interrupt-to-use-level-interrupt.patch queue-4.11/mfd-cpcap-use-ack_invert-interrupts.patch