new recipe: open-vm-tools recipe
cover new recipe: open-vm-tools recipe
Hi all,
This patch series adds a new recipe for Open VM Tools to meta-oe. This recipe is invaluable for using Openembedded with VMWare, as without the tools, performance is very slow.
More information about Open VM Tools can be found here:
https://github.com/vmware/open-vm-tools
Please note that, as mentioned in the first commit, this recipe is modified from the recipe originally found in the Open-Switch repository. The first patch is directly from that repository, and the following patches are modifications to it.
Original recipe:
https://github.com/open-switch/ops-build
yocto/openswitch/meta-foss-openswitch/recipes-extended/open-vm-tools/open-vm-tools_10.0.5.bb Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
Although the original recipe packaging was Apache-licensed, I received permission from the author (Diego Dompe) to relicense it under the MIT license for inclusion in meta-openembedded:
https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html
https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html
--
The following changes since commit 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
Revert "rrdtool: add gettext-native dependency" (2017-06-05 11:13:09
+0200)
are available in the git repository at:
https://github.com/XevoInc/meta-openembedded
for you to fetch changes up to 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
----------------------------------------------------------------
Martin Kelly (14):
add open-vm-tools recipe
open-vm-tools: add missing pkgconfig dependency
open-vm-tools: add missing glib-2.0-native dependency
open-vm-tools: clarify and expand licensing
open-vm-tools: base_contains --> bb.utils.contains
open-vm-tools: update version to 10.1.5
open-vm-tools: don't use mspack
open-vm-tools: don't use dnet-config
open-vm-tools: add #include to fix build break
open-vm-tools: add missing X11 dependencies
open-vm-tools: remove kernel module logic
open-vm-tools: line up configure options
open-vm-tools: support FUSE
open-vm-tools: style changes
.../recipes-support/open-vm-tools/files/tools.conf | 2 + .../open-vm-tools/files/vmtoolsd.service | 11 +++ .../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++ .../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++ .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb | 90 ++++++++++++++++++++++ 6 files changed, 212 insertions(+) create mode 100644 meta-oe/recipes-support/open-vm-tools/files/tools.conf create mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch create mode 100644
meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb --
2.1.4
Quoted 77 lines · Martin Kelly
Hi all,
This patch series adds a new recipe for Open VM Tools to meta-oe. This recipe is invaluable for using Openembedded with VMWare, as without the tools, performance is very slow.
More information about Open VM Tools can be found here:
https://github.com/vmware/open-vm-tools
Please note that, as mentioned in the first commit, this recipe is modified from the recipe originally found in the Open-Switch repository. The first patch is directly from that repository, and the following patches are modifications to it.
Original recipe:
https://github.com/open-switch/ops-build
yocto/openswitch/meta-foss-openswitch/recipes-extended/open-vm-tools/open-vm-tools_10.0.5.bbCommit
9008de2d8e100f3f868c66765742bca9fa98f3f9Although the original recipe packaging was Apache-licensed, I received permission from the author (Diego Dompe) to relicense it under the MIT license for inclusion in meta-openembedded:
https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html
https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html--
The following changes since commit41cf832cc9abd6f2293a6d612463a34a53a9a52a:Revert "rrdtool: add gettext-native dependency" (2017-06-05 11:13:09
+0200)are available in the git repository at:
https://github.com/XevoInc/meta-openembedded
for you to fetch changes up to
402d1b3917195beb2ab7cac5dc94aaed8992b5a1:open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
----------------------------------------------------------------
Martin Kelly (14):
add open-vm-tools recipe
open-vm-tools: add missing pkgconfig dependency
open-vm-tools: add missing glib-2.0-native dependency
open-vm-tools: clarify and expand licensing
open-vm-tools:base_contains--> bb.utils.contains
open-vm-tools: update version to 10.1.5
open-vm-tools: don't use mspack
open-vm-tools: don't use dnet-config
open-vm-tools: add #include to fix build break
open-vm-tools: add missing X11 dependencies
open-vm-tools: remove kernel module logic
open-vm-tools: line up configure options
open-vm-tools: support FUSE
open-vm-tools: style changes.../recipes-support/open-vm-tools/files/tools.conf | 2 + .../open-vm-tools/files/vmtoolsd.service | 11 +++ .../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++ .../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++ .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb | 90 ++++++++++++++++++++++ 6 files changed, 212 insertions(+) create mode 100644 meta-oe/recipes-support/open-vm-tools/files/tools.conf create mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service create mode 100644
meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patchcreate mode 100644
meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch
Quoted 7 lines
create mode 100644
meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patchcreate mode 100644meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb --
2.1.4
(ping)
It didn't make it to patchwork, because you've sent only the cover letter. I've added it to master-next now.
Next time please send also individual patches. So that it gets more visibility for other people to comment and also that I can use patchwork to pull it in.
Regards,
Quoted 95 lines · Martin Kelly
Quoted 81 lines · Martin Kelly
Hi all,
This patch series adds a new recipe for Open VM Tools to meta-oe. This recipe is invaluable for using Openembedded with VMWare, as without the tools, performance is very slow.
More information about Open VM Tools can be found here:
https://github.com/vmware/open-vm-tools
Please note that, as mentioned in the first commit, this recipe is modified from the recipe originally found in the Open-Switch repository. The first patch is directly from that repository, and the following patches are modifications to it.
Original recipe:
https://github.com/open-switch/ops-build
yocto/openswitch/meta-foss-openswitch/recipes-extended/open-vm-tools/ open-vm-tools_10.0.5.bbCommit
9008de2d8e100f3f868c66765742bca9fa98f3f9Although the original recipe packaging was Apache-licensed, I received permission from the author (Diego Dompe) to relicense it under the MIT license for inclusion in meta-openembedded:
https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html
https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html--
The following changes since commit41cf832cc9abd6f2293a6d612463a34a53a9a52a:Revert "rrdtool: add gettext-native dependency" (2017-06-05 11:13:09
+0200)are available in the git repository at:
https://github.com/XevoInc/meta-openembedded
for you to fetch changes up to
402d1b3917195beb2ab7cac5dc94aaed8992b5a1:open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
----------------------------------------------------------------
Martin Kelly (14):
add open-vm-tools recipe
open-vm-tools: add missing pkgconfig dependency
open-vm-tools: add missing glib-2.0-native dependency
open-vm-tools: clarify and expand licensing
open-vm-tools:base_contains--> bb.utils.contains
open-vm-tools: update version to 10.1.5
open-vm-tools: don't use mspack
open-vm-tools: don't use dnet-config
open-vm-tools: add #include to fix build break
open-vm-tools: add missing X11 dependencies
open-vm-tools: remove kernel module logic
open-vm-tools: line up configure options
open-vm-tools: support FUSE
open-vm-tools: style changes.../recipes-support/open-vm-tools/files/tools.conf | 2 + .../open-vm-tools/files/vmtoolsd.service | 11 +++ .../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++ .../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++ .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb | 90 ++++++++++++++++++++++ 6 files changed, 212 insertions(+) create mode 100644 meta-oe/recipes-support/open-v m-tools/files/tools.conf create mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service create mode 100644meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix -kernel-detection.patch
create mode 100644meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-con figure.ac-don-t-use-dnet-config.patch
Quoted 9 lines
create mode 100644meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add -include-sys-sysmacros.h.patch
create mode 100644meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb --
2.1.4(ping)
Quoted 9 lines · Martin Jansa
It didn't make it to patchwork, because you've sent only the cover letter. I've added it to master-next now.
Next time please send also individual patches. So that it gets more visibility for other people to comment and also that I can use patchwork to pull it in.
Regards,
Thanks, sorry about that. I was trying to use the send-pull-request script and getting errors; somehow it couldn't figure out the branch I was using. I tried to fix the script but eventually gave up and did a manual pull request attempting to mimic what the script would have spit out.
Quoted 110 lines
On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <[email protected] <mailto:[email protected]>> wrote:
On 06/09/2017 03:22 PM, Martin Kelly wrote: Hi all, This patch series adds a new recipe for Open VM Tools to meta-oe. This recipe is invaluable for using Openembedded with VMWare, as without the tools, performance is very slow. More information about Open VM Tools can be found here: https://github.com/vmware/open-vm-tools <https://github.com/vmware/open-vm-tools> Please note that, as mentioned in the first commit, this recipe is modified from the recipe originally found in the Open-Switch repository. The first patch is directly from that repository, and the following patches are modifications to it. Original recipe: https://github.com/open-switch/ops-build <https://github.com/open-switch/ops-build> yocto/openswitch/meta-foss-openswitch/recipes-extended/open-vm-tools/open-vm-tools_10.0.5.bb <http://open-vm-tools_10.0.5.bb> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9 Although the original recipe packaging was Apache-licensed, I received permission from the author (Diego Dompe) to relicense it under the MIT license for inclusion in meta-openembedded: https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html> -- The following changes since commit 41cf832cc9abd6f2293a6d612463a34a53a9a52a: Revert "rrdtool: add gettext-native dependency" (2017-06-05 11:13:09 +0200) are available in the git repository at: https://github.com/XevoInc/meta-openembedded <https://github.com/XevoInc/meta-openembedded> for you to fetch changes up to 402d1b3917195beb2ab7cac5dc94aaed8992b5a1: open-vm-tools: style changes (2017-06-07 22:31:34 +0000) ---------------------------------------------------------------- Martin Kelly (14): add open-vm-tools recipe open-vm-tools: add missing pkgconfig dependency open-vm-tools: add missing glib-2.0-native dependency open-vm-tools: clarify and expand licensing open-vm-tools: base_contains --> bb.utils.contains open-vm-tools: update version to 10.1.5 open-vm-tools: don't use mspack open-vm-tools: don't use dnet-config open-vm-tools: add #include to fix build break open-vm-tools: add missing X11 dependencies open-vm-tools: remove kernel module logic open-vm-tools: line up configure options open-vm-tools: support FUSE open-vm-tools: style changes .../recipes-support/open-vm-tools/files/tools.conf | 2 + .../open-vm-tools/files/vmtoolsd.service | 11 +++ .../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++ .../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++ .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> | 90 ++++++++++++++++++++++ 6 files changed, 212 insertions(+) create mode 100644 meta-oe/recipes-support/open-vm-tools/files/tools.conf create mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> -- 2.1.4 (ping)
No problem, I had issues with that script as well, but it works for me if I provide all necessary params manually (when it doesn't try to figure out anything).
Quoted 140 lines · Martin Kelly
Quoted 10 lines · Martin Jansa
It didn't make it to patchwork, because you've sent only the cover letter. I've added it to master-next now.
Next time please send also individual patches. So that it gets more visibility for other people to comment and also that I can use patchwork to pull it in.
Regards,
Thanks, sorry about that. I was trying to use the send-pull-request script and getting errors; somehow it couldn't figure out the branch I was using. I tried to fix the script but eventually gave up and did a manual pull request attempting to mimic what the script would have spit out.
On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <[email protected]
Quoted 122 lines
<mailto:[email protected]>> wrote:
On 06/09/2017 03:22 PM, Martin Kelly wrote:
Hi all,
This patch series adds a new recipe for Open VM Tools to meta-oe. This
recipe is invaluable for using Openembedded with VMWare, as without the
tools, performance is very slow.More information about Open VM Tools can be found here:
https://github.com/vmware/open-vm-tools
<https://github.com/vmware/open-vm-tools>Please note that, as mentioned in the first commit, this recipe is modified from the recipe originally found in the Open-Switch repository.
The first patch is directly from that repository, and the
following
patches are modifications to it.Original recipe:
https://github.com/open-switch/ops-build
<https://github.com/open-switch/ops-build>
yocto/openswitch/meta-foss-openswitch/recipes-extended/open-
vm-tools/open-vm-tools_10.0.5.bb
<http://open-vm-tools_10.0.5.bb>Commit
9008de2d8e100f3f868c66765742bca9fa98f3f9Although the original recipe packaging was Apache-licensed, I received
permission from the author (Diego Dompe) to relicense it under the MIT
license for inclusion in meta-openembedded:https://lists.openswitch.net/pipermail/ops-dev/2017-April/01
4715.html<https://lists.openswitch.net/pipermail/ops-dev/2017-April/0 14715.html> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html
<https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html>
--
The following changes since commit
41cf832cc9abd6f2293a6d612463a34a53a9a52a:Revert "rrdtool: add gettext-native dependency" (2017-06-05
11:13:09
+0200)are available in the git repository at:
https://github.com/XevoInc/meta-openembedded
<https://github.com/XevoInc/meta-openembedded>for you to fetch changes up to
402d1b3917195beb2ab7cac5dc94aaed8992b5a1:open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
----------------------------------------------------------------
Martin Kelly (14):
add open-vm-tools recipe
open-vm-tools: add missing pkgconfig dependency
open-vm-tools: add missing glib-2.0-native dependency
open-vm-tools: clarify and expand licensing
open-vm-tools:base_contains--> bb.utils.contains
open-vm-tools: update version to 10.1.5
open-vm-tools: don't use mspack
open-vm-tools: don't use dnet-config
open-vm-tools: add #include to fix build break
open-vm-tools: add missing X11 dependencies
open-vm-tools: remove kernel module logic
open-vm-tools: line up configure options
open-vm-tools: support FUSE
open-vm-tools: style changes
.../recipes-support/open-vm-tools/files/tools.conf| 2 +
.../open-vm-tools/files/vmtoolsd.service | 11 +++
.../open-vm-tools/0001-Fix-kernel-detection.patch| 35
+++++++++.../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++ .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> | 90 ++++++++++++++++++++++ 6 files changed, 212 insertions(+) create mode 100644 meta-oe/recipes-support/open-vm-tools/files/tools.conf create mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> -- 2.1.4 (ping)
Quoted 4 lines · Martin Jansa
No problem, I had issues with that script as well, but it works for me if I provide all necessary params manually (when it doesn't try to figure out anything).
Makes sense; I think the script may be too smart for its own good :).
Quoted 169 lines
On Thu, Jun 15, 2017 at 7:07 PM, Martin Kelly <[email protected] <mailto:[email protected]>> wrote:
On 06/15/2017 09:54 AM, Martin Jansa wrote: It didn't make it to patchwork, because you've sent only the cover letter. I've added it to master-next now. Next time please send also individual patches. So that it gets more visibility for other people to comment and also that I can use patchwork to pull it in. Regards, Thanks, sorry about that. I was trying to use the send-pull-request script and getting errors; somehow it couldn't figure out the branch I was using. I tried to fix the script but eventually gave up and did a manual pull request attempting to mimic what the script would have spit out. On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>> wrote: On 06/09/2017 03:22 PM, Martin Kelly wrote: Hi all, This patch series adds a new recipe for Open VM Tools to meta-oe. This recipe is invaluable for using Openembedded with VMWare, as without the tools, performance is very slow. More information about Open VM Tools can be found here: https://github.com/vmware/open-vm-tools <https://github.com/vmware/open-vm-tools> <https://github.com/vmware/open-vm-tools <https://github.com/vmware/open-vm-tools>> Please note that, as mentioned in the first commit, this recipe is modified from the recipe originally found in the Open-Switch repository. The first patch is directly from that repository, and the following patches are modifications to it. Original recipe: https://github.com/open-switch/ops-build <https://github.com/open-switch/ops-build> <https://github.com/open-switch/ops-build <https://github.com/open-switch/ops-build>> yocto/openswitch/meta-foss-openswitch/recipes-extended/open-vm-tools/open-vm-tools_10.0.5.bb <http://open-vm-tools_10.0.5.bb> <http://open-vm-tools_10.0.5.bb <http://open-vm-tools_10.0.5.bb>> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9 Although the original recipe packaging was Apache-licensed, I received permission from the author (Diego Dompe) to relicense it under the MIT license for inclusion in meta-openembedded: https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html>> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html>> -- The following changes since commit 41cf832cc9abd6f2293a6d612463a34a53a9a52a: Revert "rrdtool: add gettext-native dependency" (2017-06-05 11:13:09 +0200) are available in the git repository at: https://github.com/XevoInc/meta-openembedded <https://github.com/XevoInc/meta-openembedded> <https://github.com/XevoInc/meta-openembedded <https://github.com/XevoInc/meta-openembedded>> for you to fetch changes up to 402d1b3917195beb2ab7cac5dc94aaed8992b5a1: open-vm-tools: style changes (2017-06-07 22:31:34 +0000) ---------------------------------------------------------------- Martin Kelly (14): add open-vm-tools recipe open-vm-tools: add missing pkgconfig dependency open-vm-tools: add missing glib-2.0-native dependency open-vm-tools: clarify and expand licensing open-vm-tools: base_contains --> bb.utils.contains open-vm-tools: update version to 10.1.5 open-vm-tools: don't use mspack open-vm-tools: don't use dnet-config open-vm-tools: add #include to fix build break open-vm-tools: add missing X11 dependencies open-vm-tools: remove kernel module logic open-vm-tools: line up configure options open-vm-tools: support FUSE open-vm-tools: style changes .../recipes-support/open-vm-tools/files/tools.conf | 2 + .../open-vm-tools/files/vmtoolsd.service | 11 +++ .../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++ .../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++ .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> <http://open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb>> | 90 ++++++++++++++++++++++ 6 files changed, 212 insertions(+) create mode 100644 meta-oe/recipes-support/open-vm-tools/files/tools.conf create mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> <http://open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb>> -- 2.1.4 (ping)
Quoted 3 lines · CEST Martin Jansa
No problem, I had issues with that script as well, but it works for me if I provide all necessary params manually (when it doesn't try to figure out anything).
Which issues have you been experiencing with send-pull-request? Have you reported these as bugs?
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Quoted 7 lines · Paul Eggleton
Quoted 3 lines · CEST Martin Jansa
No problem, I had issues with that script as well, but it works for me if I provide all necessary params manually (when it doesn't try to figure out anything).
Which issues have you been experiencing with send-pull-request? Have you reported these as bugs?
I had also reached out, but hadn't subscribed to the list yet. He said he would respin the patches and provide specifics on the failure he experienced.
If I recall, it can still be picking about certain remotes, but I thought github was one that it handled well. So I'm looking forward to seeing the report. Happy to help once we have some details.
Signature · 2 lines
Darren Hart VMware Open Source Technology Center
Quoted 9 lines · Martin Jansa
It didn't make it to patchwork, because you've sent only the cover letter. I've added it to master-next now.
Next time please send also individual patches. So that it gets more visibility for other people to comment and also that I can use patchwork to pull it in.
Regards,
Small note: Looks like the initial commit (24b2ac) has a small typo that should ideally be fixed before it's merged into master:
"open-vm-tools: add recipe from meat-foss-openswitch"
"meat" --> "meta"
Quoted 110 lines
On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <[email protected] <mailto:[email protected]>> wrote:
On 06/09/2017 03:22 PM, Martin Kelly wrote: Hi all, This patch series adds a new recipe for Open VM Tools to meta-oe. This recipe is invaluable for using Openembedded with VMWare, as without the tools, performance is very slow. More information about Open VM Tools can be found here: https://github.com/vmware/open-vm-tools <https://github.com/vmware/open-vm-tools> Please note that, as mentioned in the first commit, this recipe is modified from the recipe originally found in the Open-Switch repository. The first patch is directly from that repository, and the following patches are modifications to it. Original recipe: https://github.com/open-switch/ops-build <https://github.com/open-switch/ops-build> yocto/openswitch/meta-foss-openswitch/recipes-extended/open-vm-tools/open-vm-tools_10.0.5.bb <http://open-vm-tools_10.0.5.bb> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9 Although the original recipe packaging was Apache-licensed, I received permission from the author (Diego Dompe) to relicense it under the MIT license for inclusion in meta-openembedded: https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html> -- The following changes since commit 41cf832cc9abd6f2293a6d612463a34a53a9a52a: Revert "rrdtool: add gettext-native dependency" (2017-06-05 11:13:09 +0200) are available in the git repository at: https://github.com/XevoInc/meta-openembedded <https://github.com/XevoInc/meta-openembedded> for you to fetch changes up to 402d1b3917195beb2ab7cac5dc94aaed8992b5a1: open-vm-tools: style changes (2017-06-07 22:31:34 +0000) ---------------------------------------------------------------- Martin Kelly (14): add open-vm-tools recipe open-vm-tools: add missing pkgconfig dependency open-vm-tools: add missing glib-2.0-native dependency open-vm-tools: clarify and expand licensing open-vm-tools: base_contains --> bb.utils.contains open-vm-tools: update version to 10.1.5 open-vm-tools: don't use mspack open-vm-tools: don't use dnet-config open-vm-tools: add #include to fix build break open-vm-tools: add missing X11 dependencies open-vm-tools: remove kernel module logic open-vm-tools: line up configure options open-vm-tools: support FUSE open-vm-tools: style changes .../recipes-support/open-vm-tools/files/tools.conf | 2 + .../open-vm-tools/files/vmtoolsd.service | 11 +++ .../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++ .../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++ .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> | 90 ++++++++++++++++++++++ 6 files changed, 212 insertions(+) create mode 100644 meta-oe/recipes-support/open-vm-tools/files/tools.conf create mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> -- 2.1.4 (ping)
OK, I'll try to remember to fix it before merge.
I'm sorry about it, tweaking other people commits always strikes back :).
Quoted 142 lines · Martin Kelly
Quoted 10 lines · Martin Jansa
It didn't make it to patchwork, because you've sent only the cover letter. I've added it to master-next now.
Next time please send also individual patches. So that it gets more visibility for other people to comment and also that I can use patchwork to pull it in.
Regards,
Small note: Looks like the initial commit (24b2ac) has a small typo that should ideally be fixed before it's merged into master:
"open-vm-tools: add recipe from meat-foss-openswitch"
"meat" --> "meta"
On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <[email protected]
Quoted 122 lines
<mailto:[email protected]>> wrote:
On 06/09/2017 03:22 PM, Martin Kelly wrote:
Hi all,
This patch series adds a new recipe for Open VM Tools to meta-oe. This
recipe is invaluable for using Openembedded with VMWare, as without the
tools, performance is very slow.More information about Open VM Tools can be found here:
https://github.com/vmware/open-vm-tools
<https://github.com/vmware/open-vm-tools>Please note that, as mentioned in the first commit, this recipe is modified from the recipe originally found in the Open-Switch repository.
The first patch is directly from that repository, and the
following
patches are modifications to it.Original recipe:
https://github.com/open-switch/ops-build
<https://github.com/open-switch/ops-build>
yocto/openswitch/meta-foss-openswitch/recipes-extended/open-
vm-tools/open-vm-tools_10.0.5.bb
<http://open-vm-tools_10.0.5.bb>Commit
9008de2d8e100f3f868c66765742bca9fa98f3f9Although the original recipe packaging was Apache-licensed, I received
permission from the author (Diego Dompe) to relicense it under the MIT
license for inclusion in meta-openembedded:https://lists.openswitch.net/pipermail/ops-dev/2017-April/01
4715.html<https://lists.openswitch.net/pipermail/ops-dev/2017-April/0 14715.html> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html
<https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html>
--
The following changes since commit
41cf832cc9abd6f2293a6d612463a34a53a9a52a:Revert "rrdtool: add gettext-native dependency" (2017-06-05
11:13:09
+0200)are available in the git repository at:
https://github.com/XevoInc/meta-openembedded
<https://github.com/XevoInc/meta-openembedded>for you to fetch changes up to
402d1b3917195beb2ab7cac5dc94aaed8992b5a1:open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
----------------------------------------------------------------
Martin Kelly (14):
add open-vm-tools recipe
open-vm-tools: add missing pkgconfig dependency
open-vm-tools: add missing glib-2.0-native dependency
open-vm-tools: clarify and expand licensing
open-vm-tools:base_contains--> bb.utils.contains
open-vm-tools: update version to 10.1.5
open-vm-tools: don't use mspack
open-vm-tools: don't use dnet-config
open-vm-tools: add #include to fix build break
open-vm-tools: add missing X11 dependencies
open-vm-tools: remove kernel module logic
open-vm-tools: line up configure options
open-vm-tools: support FUSE
open-vm-tools: style changes
.../recipes-support/open-vm-tools/files/tools.conf| 2 +
.../open-vm-tools/files/vmtoolsd.service | 11 +++
.../open-vm-tools/0001-Fix-kernel-detection.patch| 35
+++++++++.../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++ .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> | 90 ++++++++++++++++++++++ 6 files changed, 212 insertions(+) create mode 100644 meta-oe/recipes-support/open-vm-tools/files/tools.conf create mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> -- 2.1.4 (ping)
Fails to configure on qemuarm.
If arm isn't expected to be supported, can you please update COMPATIBLE_HOST restriction?
http://errors.yoctoproject.org/Errors/Details/145599/
Quoted 151 lines · Martin Jansa
OK, I'll try to remember to fix it before merge.
I'm sorry about it, tweaking other people commits always strikes back :).
Quoted 144 lines · Martin Kelly
Quoted 10 lines · Martin Jansa
It didn't make it to patchwork, because you've sent only the cover letter. I've added it to master-next now.
Next time please send also individual patches. So that it gets more visibility for other people to comment and also that I can use patchwork to pull it in.
Regards,
Small note: Looks like the initial commit (24b2ac) has a small typo that should ideally be fixed before it's merged into master:
"open-vm-tools: add recipe from meat-foss-openswitch"
"meat" --> "meta"
On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <[email protected]
Quoted 124 lines
<mailto:[email protected]>> wrote:
On 06/09/2017 03:22 PM, Martin Kelly wrote:
Hi all,
This patch series adds a new recipe for Open VM Tools to meta-oe. This
recipe is invaluable for using Openembedded with VMWare, as without the
tools, performance is very slow.More information about Open VM Tools can be found here:
https://github.com/vmware/open-vm-tools
<https://github.com/vmware/open-vm-tools>Please note that, as mentioned in the first commit, this recipe
is
modified from the recipe originally found in the Open-Switch repository.
The first patch is directly from that repository, and the
following
patches are modifications to it.Original recipe:
https://github.com/open-switch/ops-build
<https://github.com/open-switch/ops-build>
yocto/openswitch/meta-foss-openswitch/recipes-extended/open-
vm-tools/open-vm-tools_10.0.5.bb
<http://open-vm-tools_10.0.5.bb>Commit
9008de2d8e100f3f868c66765742bca9fa98f3f9Although the original recipe packaging was Apache-licensed, I received
permission from the author (Diego Dompe) to relicense it under the MIT
license for inclusion in meta-openembedded:https://lists.openswitch.net/pipermail/ops-dev/2017-April/01
4715.html<https://lists.openswitch.net/pipermail/ops-dev/2017-April/0 14715.html> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html
<https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html>
--
The following changes since commit
41cf832cc9abd6f2293a6d612463a34a53a9a52a:Revert "rrdtool: add gettext-native dependency" (2017-06-05
11:13:09
+0200)are available in the git repository at:
https://github.com/XevoInc/meta-openembedded
<https://github.com/XevoInc/meta-openembedded>for you to fetch changes up to
402d1b3917195beb2ab7cac5dc94aaed8992b5a1:open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
----------------------------------------------------------------
Martin Kelly (14):
add open-vm-tools recipe
open-vm-tools: add missing pkgconfig dependency
open-vm-tools: add missing glib-2.0-native dependency
open-vm-tools: clarify and expand licensing
open-vm-tools:base_contains--> bb.utils.contains
open-vm-tools: update version to 10.1.5
open-vm-tools: don't use mspack
open-vm-tools: don't use dnet-config
open-vm-tools: add #include to fix build break
open-vm-tools: add missing X11 dependencies
open-vm-tools: remove kernel module logic
open-vm-tools: line up configure options
open-vm-tools: support FUSE
open-vm-tools: style changes
.../recipes-support/open-vm-tools/files/tools.conf| 2 +
.../open-vm-tools/files/vmtoolsd.service | 11 +++
.../open-vm-tools/0001-Fix-kernel-detection.patch| 35
+++++++++.../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++ .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> | 90 ++++++++++++++++++++++ 6 files changed, 212 insertions(+) create mode 100644 meta-oe/recipes-support/open-vm-tools/files/tools.conf create mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> -- 2.1.4 (ping)
And there is also this:
=== Incorrect PACKAGE_ARCH or sstate signatures (3) ===
Complete log:
http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/log.signatures.20170618_014055.log/
* ERROR: 3 issues were found in these recipes: open-vm-tools
* ERROR: 1 errors found in signatures.qemux86.do_configure.sigdata.log
* ERROR: 1 errors found in
signatures.qemux86.do_populate_sysroot.sigdata.log
* ERROR: 1 errors found in
signatures.qemux86.do_package_write_ipk.sigdata.log
* ERROR: open-vm-tools different signature for task
do_configure.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in/home/jenkins/oe/world/shr-core/tmp-glibc/sstate-diff/1497786055/signatures.qemux86.do_configure.sigdata.log
* ERROR: open-vm-tools different signature for task
do_populate_sysroot.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in/home/jenkins/oe/world/shr-core/tmp-glibc/sstate-diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log
* ERROR: open-vm-tools different signature for task
do_package_write_ipk.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in/home/jenkins/oe/world/shr-core/tmp-glibc/sstate-diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log
* ERROR: 3 issues were found in these recipes: open-vm-tools
So it probably depends on some MACHINE specific variable without being marked as MACHINE_ARCH.
It's depending on kernel, so it needs to be MACHINE_ARCH, also I've noticed few more issues:
DEPENDS is there twice:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb#L24
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb#L39
What is supposed to set KERNEL_VERSION variable in:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb#L58
?
Don't use tags in SRCREV, use git hash instead (otherwise bitbake fetcher will reach upstream git repo every single time the recipe is parsed and will cause failed builds when github isn't accessible).
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb#L35
There are many hardcoded paths like /usr/lib/ or /usr/sbin/, please use proper variables like libdir, sbindir.
Once you fix these issues please resend all changes to the ML, it's much better to review inline than this.
Regards,
Quoted 163 lines · Martin Jansa
Fails to configure on qemuarm.
If arm isn't expected to be supported, can you please update
COMPATIBLE_HOSTrestriction?http://errors.yoctoproject.org/Errors/Details/145599/
Quoted 152 lines · Martin Jansa
OK, I'll try to remember to fix it before merge.
I'm sorry about it, tweaking other people commits always strikes back :).
Quoted 145 lines · Martin Kelly
Quoted 10 lines · Martin Jansa
It didn't make it to patchwork, because you've sent only the cover letter. I've added it to master-next now.
Next time please send also individual patches. So that it gets more visibility for other people to comment and also that I can use patchwork to pull it in.
Regards,
Small note: Looks like the initial commit (24b2ac) has a small typo that should ideally be fixed before it's merged into master:
"open-vm-tools: add recipe from meat-foss-openswitch"
"meat" --> "meta"
On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <[email protected]
Quoted 125 lines
<mailto:[email protected]>> wrote:
On 06/09/2017 03:22 PM, Martin Kelly wrote:
Hi all,
This patch series adds a new recipe for Open VM Tools to meta-oe. This
recipe is invaluable for using Openembedded with VMWare, as without the
tools, performance is very slow.More information about Open VM Tools can be found here:
https://github.com/vmware/open-vm-tools
<https://github.com/vmware/open-vm-tools>Please note that, as mentioned in the first commit, this recipe
is
modified from the recipe originally found in the Open-Switch repository.
The first patch is directly from that repository, and the
following
patches are modifications to it.Original recipe:
https://github.com/open-switch/ops-build
<https://github.com/open-switch/ops-build>
yocto/openswitch/meta-foss-openswitch/recipes-extended/open-
vm-tools/open-vm-tools_10.0.5.bb
<http://open-vm-tools_10.0.5.bb>Commit
9008de2d8e100f3f868c66765742bca9fa98f3f9Although the original recipe packaging was Apache-licensed, I received
permission from the author (Diego Dompe) to relicense it under the MIT
license for inclusion in meta-openembedded:https://lists.openswitch.net/pipermail/ops-dev/2017-April/01
4715.html<https://lists.openswitch.net/pipermail/ops-dev/2017-April/0 14715.html> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html
<https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html>
-- The following changes since commit 41cf832cc9abd6f2293a6d612463a34a53a9a52a: Revert "rrdtool: add gettext-native dependency" (2017-06-05 11:13:09 +0200) are available in the git repository at: https://github.com/XevoInc/meta-openembedded <https://github.com/XevoInc/meta-openembedded> for you to fetch changes up to 402d1b3917195beb2ab7cac5dc94aaed8992b5a1: open-vm-tools: style changes (2017-06-07 22:31:34 +0000) ----------------------------------------------------------------
Martin Kelly (14):
add open-vm-tools recipe
open-vm-tools: add missing pkgconfig dependency
open-vm-tools: add missing glib-2.0-native dependency
open-vm-tools: clarify and expand licensing
open-vm-tools:base_contains--> bb.utils.contains
open-vm-tools: update version to 10.1.5
open-vm-tools: don't use mspack
open-vm-tools: don't use dnet-config
open-vm-tools: add #include to fix build break
open-vm-tools: add missing X11 dependencies
open-vm-tools: remove kernel module logic
open-vm-tools: line up configure options
open-vm-tools: support FUSE
open-vm-tools: style changes
.../recipes-support/open-vm-tools/files/tools.conf| 2 +
.../open-vm-tools/files/vmtoolsd.service | 11 +++
.../open-vm-tools/0001-Fix-kernel-detection.patch| 35
+++++++++.../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++ .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> | 90 ++++++++++++++++++++++ 6 files changed, 212 insertions(+) create mode 100644 meta-oe/recipes-support/open-vm-tools/files/tools.conf create mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> -- 2.1.4 (ping)
Quoted 35 lines · Martin Jansa
And there is also this:
=== Incorrect
PACKAGE_ARCHor sstate signatures (3) ===Complete log: http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/lo
g.signatures.20170618_014055.log/
* ERROR: 3 issues were found in these recipes: open-vm-tools* ERROR: 1 errors found in signatures.qemux86.do_configure.sigdata.log
* ERROR: 1 errors found in signatures.qemux86.do_populate_sysroot.sigdata.log
* ERROR: 1 errors found in signatures.qemux86.do_package_write_ipk.sigdata.log* ERROR: open-vm-tools different signature for task do_configure.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in/home/jenkins/oe/world/shr-core/tmp-glibc/sstate- diff/1497786055/signatures.qemux86.do_configure.sigdata.log
* ERROR: open-vm-tools different signature for task do_populate_sysroot.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in/home/jenkins/oe/world/shr-core/tmp-glibc/sstate- diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log
* ERROR: open-vm-tools different signature for task do_package_write_ipk.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in/home/jenkins/oe/world/shr-core/tmp-glibc/sstate- diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log
* ERROR: 3 issues were found in these recipes: open-vm-toolsSo it probably depends on some MACHINE specific variable without being marked as
MACHINE_ARCH.
Quoted 8 lines
Looking at:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab
7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm- tools_10.1.5.bbIt's depending on kernel, so it needs to be
MACHINE_ARCH, also I've noticed few more issues:
Thanks for all the feedback. I believe I've now fixed all the issues you outlined.
I dropped the kernel dependency entirely, as we're no longer building the kernel modules (they all got upstreamed). Thus I suspect the issue is no longer present with my latest changes.
That said, I can't repro the sstate errors on my local machine. Could you provide repro steps so I can verify this is fixed before I send new patches?
Quoted 220 lines
DEPENDS is there twice:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab
7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm- tools_10.1.5.bb#L24
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab
7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm- tools_10.1.5.bb#L39What is supposed to set
KERNEL_VERSIONvariable in:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab
7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm- tools_10.1.5.bb#L58
?Don't use tags in SRCREV, use git hash instead (otherwise bitbake fetcher will reach upstream git repo every single time the recipe is parsed and will cause failed builds when github isn't accessible).
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab
7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm- tools_10.1.5.bb#L35There are many hardcoded paths like
/usr/lib/or/usr/sbin/, please use proper variables like libdir, sbindir.Once you fix these issues please resend all changes to the ML, it's much better to review inline than this.
Regards,
On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <[email protected]
Quoted 187 lines
wrote:
Fails to configure on qemuarm.If arm isn't expected to be supported, can you please update
COMPATIBLE_HOSTrestriction?http://errors.yoctoproject.org/Errors/Details/145599/
Quoted 175 lines · Martin Jansa
OK, I'll try to remember to fix it before merge.
I'm sorry about it, tweaking other people commits always strikes back :).
Quoted 166 lines · Martin Kelly
Quoted 4 lines · Martin Jansa
It didn't make it to patchwork, because you've sent only the cover
letter. I've added it to master-next now.Quoted 9 lines
Next time please send also individual patches. So that it gets more
visibility for other people to comment and also that I can use patchwork
to pull it in.Regards,
Small note: Looks like the initial commit (24b2ac) has a small typo that should ideally be fixed before it's merged into master:"open-vm-tools: add recipe from meat-foss-openswitch"
"meat" --> "meta"
Quoted 138 lines
On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <[email protected] m
<mailto:[email protected]>> wrote:On 06/09/2017 03:22 PM, Martin Kelly wrote:
Hi all,
This patch series adds a new recipe for Open VM Tools to
meta-oe. This
recipe is invaluable for using Openembedded with VMWare, as
without the
tools, performance is very slow.More information about Open VM Tools can be found here:
https://github.com/vmware/open-vm-tools
<https://github.com/vmware/open-vm-tools>Please note that, as mentioned in the first commit, this recipe is
modified from the recipe originally found in the Open-Switch
repository.
The first patch is directly from that repository, and the following
patches are modifications to it.Original recipe:
https://github.com/open-switch/ops-build
<https://github.com/open-switch/ops-build>
yocto/openswitch/meta-foss-openswitch/recipes- extended/open-vm-tools/open-vm-tools_10.0.5.bb
<http://open-vm-tools_10.0.5.bb>Commit
9008de2d8e100f3f868c66765742bca9fa98f3f9Although the original recipe packaging was Apache- licensed, I
received
permission from the author (Diego Dompe) to relicense it under
the MIT
license for inclusion in meta-openembedded:https://lists.openswitch.net/pipermail/ops-dev/2017-A
pril/014715.html
<https://lists.openswitch.net/pipermail/ops-dev/2017-
April/014715.html>
https://lists.openswitch.net/pipermail/ops-dev/2017-A
pril/014716.html<https://lists.openswitch.net/pipermail/ops-dev/2017-
April/014716.html>--
The following changes since commit
41cf832cc9abd6f2293a6d612463a34a53a9a52a:Revert "rrdtool: add gettext-native dependency" (2017-06-05
11:13:09
+0200)are available in the git repository at:
https://github.com/XevoInc/meta-openembedded
<https://github.com/XevoInc/meta-openembedded>for you to fetch changes up to
402d1b3917195beb2ab7cac5dc94aaed8992b5a1:open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
---------------------------------------------------
-------------
Martin Kelly (14):
add open-vm-tools recipe
open-vm-tools: add missing pkgconfig dependency
open-vm-tools: add missing glib-2.0-native dependency
open-vm-tools: clarify and expand licensing
open-vm-tools:base_contains--> bb.utils.contains
open-vm-tools: update version to 10.1.5
open-vm-tools: don't use mspack
open-vm-tools: don't use dnet-config
open-vm-tools: add #include to fix build break
open-vm-tools: add missing X11 dependencies
open-vm-tools: remove kernel module logic
open-vm-tools: line up configure options
open-vm-tools: support FUSE
open-vm-tools: style changes.../recipes-support/open-vm-tools/files/tools.conf | 2 +
.../open-vm-tools/files/vmtoolsd.service | 11 +++ .../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++ .../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++ .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb
<http://open-vm-tools_10.1.5.bb> | 90
++++++++++++++++++++++6 files changed, 212 insertions(+)create mode 100644 meta-oe/recipes-support/open-vm-
tools/files/tools.conf
create mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patchcreate mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-
tools/0002-configure.ac-don-t-use-dnet-config.patchcreate mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-
tools/0003-add-include-sys-sysmacros.h.patchcreate mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm- tools_10.1.5.bb
<http://open-vm-tools_10.1.5.bb>
--
2.1.4Quoted 4 lines
(ping)
(ping) I apologize for the top-post but did not want to have the ping lost in the noise.
Quoted 312 lines · Martin Kelly
Quoted 43 lines · Martin Jansa
And there is also this:
=== Incorrect
PACKAGE_ARCHor sstate signatures (3) ===Complete log: http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/
lo
g.signatures.20170618_014055.log/
* ERROR: 3 issues were found in these recipes: open-vm-tools* ERROR: 1 errors found in signatures.qemux86.do_configure.sigdata.log
* ERROR: 1 errors found in signatures.qemux86.do_populate_sysroot.sigdata.log
* ERROR: 1 errors found in signatures.qemux86.do_package_write_ipk.sigdata.log* ERROR: open-vm-tools different signature for task do_configure.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in/home/jenkins/oe/world/shr-core/tmp-glibc/sstate- diff/1497786055/signatures.qemux86.do_configure.sigdata.log
* ERROR: open-vm-tools different signature for task do_populate_sysroot.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in/home/jenkins/oe/world/shr-core/tmp-glibc/sstate- diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log
* ERROR: open-vm-tools different signature for task do_package_write_ipk.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in/home/jenkins/oe/world/shr-core/tmp-glibc/sstate- diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log
* ERROR: 3 issues were found in these recipes: open-vm-toolsSo it probably depends on some MACHINE specific variable without being marked as
MACHINE_ARCH.Looking at:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
ab 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- vm-
tools_10.1.5.bbQuoted 3 lines
It's depending on kernel, so it needs to be
MACHINE_ARCH, also I've noticed few more issues:Thanks for all the feedback. I believe I've now fixed all the issues you outlined.
I dropped the kernel dependency entirely, as we're no longer building the kernel modules (they all got upstreamed). Thus I suspect the issue
is no longer present with my latest changes.That said, I can't repro the sstate errors on my local machine. Could you provide repro steps so I can verify this is fixed before I send new
patches?Quoted 251 lines
DEPENDS is there twice:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
ab 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- vm-
tools_10.1.5.bb#L24
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
ab 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- vm-
tools_10.1.5.bb#L39What is supposed to set
KERNEL_VERSIONvariable in:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
ab 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- vm-
tools_10.1.5.bb#L58
?Don't use tags in SRCREV, use git hash instead (otherwise bitbake fetcher will reach upstream git repo every single time the recipe is
parsed and will cause failed builds when github isn't accessible).
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
ab 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- vm-
tools_10.1.5.bb#L35There are many hardcoded paths like
/usr/lib/or/usr/sbin/, please use proper variables like libdir, sbindir.Once you fix these issues please resend all changes to the ML, it's much better to review inline than this.
Regards,
On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <[email protected] om
Quoted 208 lines
wrote:
Fails to configure on qemuarm.If arm isn't expected to be supported, can you please update
COMPATIBLE_HOSTrestriction?http://errors.yoctoproject.org/Errors/Details/145599/
Quoted 195 lines · Martin Jansa
OK, I'll try to remember to fix it before merge.
I'm sorry about it, tweaking other people commits always strikes
back :).Quoted 185 lines · Martin Kelly
Quoted 5 lines · Martin Jansa
It didn't make it to patchwork, because you've sent only the
cover
letter. I've added it to master-next now.Quoted 9 lines
Next time please send also individual patches. So that it gets more
visibility for other people to comment and also that I can use patchwork
to pull it in.Regards,
Small note: Looks like the initial commit (24b2ac) has a small
typo that should ideally be fixed before it's merged into master:"open-vm-tools: add recipe from meat-foss-openswitch"
"meat" --> "meta"
Quoted 153 lines
On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo. co
m
<mailto:[email protected]>> wrote:On 06/09/2017 03:22 PM, Martin Kelly wrote:
Hi all,
This patch series adds a new recipe for Open VM Tools
to
meta-oe. This
recipe is invaluable for using Openembedded with VMWare, as
without the
tools, performance is very slow.More information about Open VM Tools can be found here:
https://github.com/vmware/open-vm-tools
<https://github.com/vmware/open-vm-tools>Please note that, as mentioned in the first commit, this recipe is
modified from the recipe originally found in the Open-Switch
repository.
The first patch is directly from that repository, and
the following
patches are modifications to it.Original recipe:
https://github.com/open-switch/ops-build
<https://github.com/open-switch/ops-build>
yocto/openswitch/meta-foss-openswitch/recipes- extended/open-vm-tools/open-vm-tools_10.0.5.bb
<http://open-vm-tools_10.0.5.bb>Commit
9008de2d8e100f3f868c66765742bca9fa98f3f9Although the original recipe packaging was Apache- licensed, I
received
permission from the author (Diego Dompe) to relicense
it under
the MIT
license for inclusion in meta-openembedded:https://lists.openswitch.net/pipermail/ops-dev/2017
-A
pril/014715.html
<https://lists.openswitch.net/pipermail/ops-dev/201
7-
April/014715.html>
https://lists.openswitch.net/pipermail/ops-dev/2017
-A
pril/014716.html<https://lists.openswitch.net/pipermail/ops-dev/201
7-
April/014716.html>--
The following changes since commit
41cf832cc9abd6f2293a6d612463a34a53a9a52a:Revert "rrdtool: add gettext-native dependency" (2017-06-05
11:13:09
+0200)are available in the git repository at:
https://github.com/XevoInc/meta-openembedded
<https://github.com/XevoInc/meta-openembedded>for you to fetch changes up to
402d1b3917195beb2ab7cac5dc94aaed8992b5a1:open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
---------------------------------------------------
-------------
Martin Kelly (14):
add open-vm-tools recipe
open-vm-tools: add missing pkgconfig dependency
open-vm-tools: add missing glib-2.0-native dependency
open-vm-tools: clarify and expand licensing
open-vm-tools:base_contains--> bb.utils.contains
open-vm-tools: update version to 10.1.5
open-vm-tools: don't use mspack
open-vm-tools: don't use dnet-config
open-vm-tools: add #include to fix build break
open-vm-tools: add missing X11 dependencies
open-vm-tools: remove kernel module logic
open-vm-tools: line up configure options
open-vm-tools: support FUSE
open-vm-tools: style changes.../recipes-support/open-vm-tools/files/tools.conf
Quoted 1 line
2 +
.../open-vm-tools/files/vmtoolsd.service |
11 +++.../open-vm-tools/0001-Fix-kernel-detection.patch|
35 +++++++++.../0002-configure.ac-don-t-use-dnet-config.patch|
41 ++++++++++.../0003-add-include-sys-sysmacros.h.patch|
33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb
<http://open-vm-tools_10.1.5.bb> | 90
++++++++++++++++++++++6 files changed, 212 insertions(+)create mode 100644 meta-oe/recipes-support/open-vm-
tools/files/tools.conf
create mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patchcreate mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-
tools/0002-configure.ac-don-t-use-dnet-config.patchcreate mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-
tools/0003-add-include-sys-sysmacros.h.patchcreate mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm- tools_10.1.5.bb
<http://open-vm-tools_10.1.5.bb>
--
2.1.4Quoted 4 lines
(ping)
It basically just calls this script:
openembedded-core/scripts/sstate-diff-machines.sh --machines="qemux86copy qemux86 qemuarm" --targets=world --tmpdir=tmp-glibc/ --analyze 2>&1 | tee ${LOGDIR}/signatures.log
see:
https://github.com/shr-project/jenkins-jobs/blob/master/jenkins-job.sh#L258
for qemux86copy you either need to add meta-selftest layer from oe-core or apply:
http://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/master&id=9d45c08641b868322af4bebc2f095340cf4dac3f
Sorry I didn't reply earlier, I think it's resolved by dropped kernel dependency and I didn't notice the question about reproducing it.
Regards,
Quoted 317 lines · Martin Kelly
(ping) I apologize for the top-post but did not want to have the ping lost in the noise.
Quoted 312 lines · Martin Kelly
Quoted 43 lines · Martin Jansa
And there is also this:
=== Incorrect
PACKAGE_ARCHor sstate signatures (3) ===Complete log: http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/
lo
g.signatures.20170618_014055.log/
* ERROR: 3 issues were found in these recipes: open-vm-tools* ERROR: 1 errors found in
signatures.qemux86.do_configure.sigdata.log
* ERROR: 1 errors found in
signatures.qemux86.do_populate_sysroot.sigdata.log
* ERROR: 1 errors found in
signatures.qemux86.do_package_write_ipk.sigdata.log* ERROR: open-vm-tools different signature for task
do_configure.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in/home/jenkins/oe/world/shr-core/tmp-
glibc/sstate- diff/1497786055/signatures.qemux86.do_configure.sigdata.log
* ERROR: open-vm-tools different signature for task
do_populate_sysroot.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in/home/jenkins/oe/world/shr-core/tmp-
glibc/sstate- diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log
* ERROR: open-vm-tools different signature for task
do_package_write_ipk.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in/home/jenkins/oe/world/shr-core/tmp-
glibc/sstate- diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log
* ERROR: 3 issues were found in these recipes: open-vm-toolsSo it probably depends on some MACHINE specific variable without being marked as
MACHINE_ARCH.Looking at:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
ab 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- vm-
tools_10.1.5.bbQuoted 3 lines
It's depending on kernel, so it needs to be
MACHINE_ARCH, also I've noticed few more issues:Thanks for all the feedback. I believe I've now fixed all the issues you outlined.
I dropped the kernel dependency entirely, as we're no longer building the kernel modules (they all got upstreamed). Thus I suspect the issue
is no longer present with my latest changes.That said, I can't repro the sstate errors on my local machine. Could you provide repro steps so I can verify this is fixed before I send new
patches?Quoted 251 lines
DEPENDS is there twice:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
ab 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- vm-
tools_10.1.5.bb#L24
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
ab 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- vm-
tools_10.1.5.bb#L39What is supposed to set
KERNEL_VERSIONvariable in:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
ab 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- vm-
tools_10.1.5.bb#L58
?Don't use tags in SRCREV, use git hash instead (otherwise bitbake fetcher will reach upstream git repo every single time the recipe is
parsed and will cause failed builds when github isn't accessible).
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
ab 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- vm-
tools_10.1.5.bb#L35There are many hardcoded paths like
/usr/lib/or/usr/sbin/, please use proper variables like libdir, sbindir.Once you fix these issues please resend all changes to the ML, it's much better to review inline than this.
Regards,
On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <[email protected] om
Quoted 208 lines
wrote:
Fails to configure on qemuarm.If arm isn't expected to be supported, can you please update
COMPATIBLE_HOSTrestriction?http://errors.yoctoproject.org/Errors/Details/145599/
Quoted 195 lines · Martin Jansa
OK, I'll try to remember to fix it before merge.
I'm sorry about it, tweaking other people commits always strikes
back :).Quoted 185 lines · Martin Kelly
Quoted 5 lines · Martin Jansa
It didn't make it to patchwork, because you've sent only the
cover
letter. I've added it to master-next now.Quoted 9 lines
Next time please send also individual patches. So that it gets more
visibility for other people to comment and also that I can use patchwork
to pull it in.Regards,
Small note: Looks like the initial commit (24b2ac) has a small
typo that should ideally be fixed before it's merged into master:"open-vm-tools: add recipe from meat-foss-openswitch"
"meat" --> "meta"
Quoted 157 lines
On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo. co
m
<mailto:[email protected]>> wrote:On 06/09/2017 03:22 PM, Martin Kelly wrote:
Hi all,
This patch series adds a new recipe for Open VM
Tools
to
meta-oe. This
recipe is invaluable for using Openembedded with
VMWare, as
without the
tools, performance is very slow.More information about Open VM Tools can be found
here:https://github.com/vmware/open-vm-tools
<https://github.com/vmware/open-vm-tools>Please note that, as mentioned in the first commit,
this recipe is
modified from the recipe originally found in the
Open-Switch
repository.
The first patch is directly from that repository,
and
the following
patches are modifications to it.Original recipe:
https://github.com/open-switch/ops-build
<https://github.com/open-switch/ops-build>
yocto/openswitch/meta-foss-openswitch/recipes-
extended/open-vm-tools/open-vm-tools_10.0.5.bb<http://open-vm-tools_10.0.5.bb> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9 Although the original recipe packaging was Apache-licensed, I
received
permission from the author (Diego Dompe) to
relicense
it under
the MIT
license for inclusion in meta-openembedded:https://lists.openswitch.net/pipermail/ops-dev/2017
-A
pril/014715.html<https://lists.openswitch.net/pipermail/ops-dev/201 7- April/014715.html> https://lists.openswitch.net/pipermail/ops-dev/2017-A
pril/014716.html<https://lists.openswitch.net/pipermail/ops-dev/2017-
April/014716.html>--
The following changes since commit
41cf832cc9abd6f2293a6d612463a34a53a9a52a:Revert "rrdtool: add gettext-native dependency"
(2017-06-0511:13:09 +0200) are available in the git repository at: https://github.com/XevoInc/meta-openembedded <https://github.com/XevoInc/meta-openembedded> for you to fetch changes up to 402d1b3917195beb2ab7cac5dc94aaed8992b5a1: open-vm-tools: style changes (2017-06-07 22:31:34+0000)
----------------------------------------------------------------
Martin Kelly (14):
add open-vm-tools recipe
open-vm-tools: add missing pkgconfig
dependency
open-vm-tools: add missing glib-2.0-native
dependency
open-vm-tools: clarify and expand licensing
open-vm-tools:base_contains-->
bb.utils.contains
open-vm-tools: update version to 10.1.5
open-vm-tools: don't use mspack
open-vm-tools: don't use dnet-config
open-vm-tools: add #include to fix build
break
open-vm-tools: add missing X11 dependencies
open-vm-tools: remove kernel module logic
open-vm-tools: line up configure options
open-vm-tools: support FUSE
open-vm-tools: style changes
.../recipes-support/open-vm-tools/files/tools.confQuoted 1 line
2 +
.../open-vm-tools/files/vmtoolsd.service
|
11 +++.../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++ .../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++ .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++ .../open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> | 90 ++++++++++++++++++++++ 6 files changed, 212 insertions(+) create mode 100644 meta-oe/recipes-support/open-vm- tools/files/tools.conf create mode 100644 meta-oe/recipes-support/open-vm- tools/files/vmtoolsd.service create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-
tools/0001-Fix-kernel-detection.patchcreate mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-
tools/0002-configure.ac-don-t-use-dnet-config.patchcreate mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-
tools/0003-add-include-sys-sysmacros.h.patchcreate mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm- tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> -- 2.1.4 (ping)
Quoted 9 lines · Martin Jansa
It basically just calls this script:
openembedded-core/scripts/sstate-diff-machines.sh--machines="qemux86copy qemux86 qemuarm" --targets=world --tmpdir=tmp-glibc/ --analyze 2>&1 | tee ${LOGDIR}/signatures.logsee:
https://github.com/shr-project/jenkins-jobs/blob/master/jenkins-job.sh#L258
Quoted 7 lines
for qemux86copy you either need to add meta-selftest layer from oe-core or apply:
http://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/master&id=9d45c08641b868322af4bebc2f095340cf4dac3fSorry I didn't reply earlier, I think it's resolved by dropped kernel dependency and I didn't notice the question about reproducing it.
I'm trying to run the script, but I'm just getting output suggesting everything is OK, even with the old change that I know has issues. I'm guessing I need to manually run through some steps that simulate what Jenkins would have done before running this script ("bitbake world" on several arches with a particular directory structure?).
It seems to me we have a few options:
- Try to troubleshoot how to manually run the tests
- Submit the fixed-up version and hope it works. I agree that dropping the kernel dependency will probably fix the issue.
- If you know how to trigger the Jenkins build manually, you could test it on my new branch before I submit:
https://github.com/xevoinc/meta-openembedded/tree/open-vm-tools-v2
I'm happy with any of these; let me know what you think.
Quoted 355 lines
On Thu, Jun 22, 2017 at 7:15 PM, Martin Kelly <[email protected] <mailto:[email protected]>> wrote:
(ping) I apologize for the top-post but did not want to have the ping lost in the noise. On Mon, 2017-06-19 at 16:43 -0700, Martin Kelly wrote: > On Sun, 2017-06-18 at 22:28 +0200, Martin Jansa wrote: > > And there is also this: > > > > === Incorrect PACKAGE_ARCH or sstate signatures (3) === > > > > Complete log: http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/ <http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/> > > lo > > g.signatures.20170618_014055.log/ > > * ERROR: 3 issues were found in these recipes: open-vm-tools > > > > * ERROR: 1 errors found in > > signatures.qemux86.do_configure.sigdata.log > > * ERROR: 1 errors found in > > signatures.qemux86.do_populate_sysroot.sigdata.log > > * ERROR: 1 errors found in > > signatures.qemux86.do_package_write_ipk.sigdata.log > > > > * ERROR: open-vm-tools different signature for task > > do_configure.sigdata between qemux86copy and qemux86 > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp- > > glibc/sstate- > > diff/1497786055/signatures.qemux86.do_configure.sigdata.log > > * ERROR: open-vm-tools different signature for task > > do_populate_sysroot.sigdata between qemux86copy and qemux86 > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp- > > glibc/sstate- > > diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log > > * ERROR: open-vm-tools different signature for task > > do_package_write_ipk.sigdata between qemux86copy and qemux86 > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp- > > glibc/sstate- > > diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log > > * ERROR: 3 issues were found in these recipes: open-vm-tools > > > > So it probably depends on some MACHINE specific variable without > > being marked as MACHINE_ARCH. > > > > Looking at: > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb <http://tools_10.1.5.bb> > > > > It's depending on kernel, so it needs to be MACHINE_ARCH, also I've > > noticed few more issues: > > > > Thanks for all the feedback. I believe I've now fixed all the issues > you outlined. > > I dropped the kernel dependency entirely, as we're no longer building > the kernel modules (they all got upstreamed). Thus I suspect the > issue > is no longer present with my latest changes. > > That said, I can't repro the sstate errors on my local machine. Could > you provide repro steps so I can verify this is fixed before I send > new > patches? > > > DEPENDS is there twice: > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb#L24 <http://tools_10.1.5.bb#L24> > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb#L39 <http://tools_10.1.5.bb#L39> > > > > What is supposed to set KERNEL_VERSION variable in: > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb#L58 <http://tools_10.1.5.bb#L58> > > ? > > > > Don't use tags in SRCREV, use git hash instead (otherwise bitbake > > fetcher will reach upstream git repo every single time the recipe > > is > > parsed and will cause failed builds when github isn't accessible). > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb#L35 <http://tools_10.1.5.bb#L35> > > > > There are many hardcoded paths like /usr/lib/ or /usr/sbin/, please > > use proper variables like libdir, sbindir. > > > > Once you fix these issues please resend all changes to the ML, it's > > much better to review inline than this. > > > > Regards, > > > > > > On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <[email protected] > > om > > > wrote: > > > Fails to configure on qemuarm. > > > > > > If arm isn't expected to be supported, can you please update > > > COMPATIBLE_HOST restriction? > > > > > > http://errors.yoctoproject.org/Errors/Details/145599/ <http://errors.yoctoproject.org/Errors/Details/145599/> > > > > > > On Thu, Jun 15, 2017 at 7:50 PM, Martin Jansa <martin.jansa@gmail > > > .c > > > om> wrote: > > > > OK, I'll try to remember to fix it before merge. > > > > > > > > I'm sorry about it, tweaking other people commits always > > > > strikes > > > > back :). > > > > > > > > On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly <[email protected] <mailto:[email protected]>> > > > > wrote: > > > > > On 06/15/2017 09:54 AM, Martin Jansa wrote: > > > > > > It didn't make it to patchwork, because you've sent only > > > > > > the > > > > > > cover > > > > > > letter. I've added it to master-next now. > > > > > > > > > > > > Next time please send also individual patches. So that it > > > > > > gets more > > > > > > visibility for other people to comment and also that I can > > > > > > use patchwork > > > > > > to pull it in. > > > > > > > > > > > > Regards, > > > > > > > > > > > > > > > > > > > > > > > > > > > Small note: Looks like the initial commit (24b2ac) has a > > > > > small > > > > > typo that should ideally be fixed before it's merged into > > > > > master: > > > > > > > > > > "open-vm-tools: add recipe from meat-foss-openswitch" > > > > > > > > > > "meat" --> "meta" > > > > > > > > > > > On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo. > > > > > > co > > > > > > m > > > > > > <mailto:[email protected] <mailto:[email protected]>>> wrote: > > > > > > > > > > > > On 06/09/2017 03:22 PM, Martin Kelly wrote: > > > > > > > > > > > > Hi all, > > > > > > > > > > > > This patch series adds a new recipe for Open VM > > > > > > Tools > > > > > > to > > > > > > meta-oe. This > > > > > > recipe is invaluable for using Openembedded with > > > > > > VMWare, as > > > > > > without the > > > > > > tools, performance is very slow. > > > > > > > > > > > > More information about Open VM Tools can be found > > > > > > here: > > > > > > > > > > > > https://github.com/vmware/open-vm-tools <https://github.com/vmware/open-vm-tools> > > > > > > <https://github.com/vmware/open-vm-tools <https://github.com/vmware/open-vm-tools>> > > > > > > > > > > > > Please note that, as mentioned in the first commit, > > > > > > this recipe is > > > > > > modified from the recipe originally found in the > > > > > > Open-Switch > > > > > > repository. > > > > > > The first patch is directly from that repository, > > > > > > and > > > > > > the following > > > > > > patches are modifications to it. > > > > > > > > > > > > Original recipe: > > > > > > https://github.com/open-switch/ops-build <https://github.com/open-switch/ops-build> > > > > > > <https://github.com/open-switch/ops-build <https://github.com/open-switch/ops-build>> > > > > > > yocto/openswitch/meta-foss-openswitch/recipes- > > > > > > extended/open-vm-tools/open-vm-tools_10.0.5.bb <http://open-vm-tools_10.0.5.bb> > > > > > > <http://open-vm-tools_10.0.5.bb <http://open-vm-tools_10.0.5.bb>> > > > > > > > > > > > > Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9 > > > > > > > > > > > > Although the original recipe packaging was Apache- > > > > > > licensed, I > > > > > > received > > > > > > permission from the author (Diego Dompe) to > > > > > > relicense > > > > > > it under > > > > > > the MIT > > > > > > license for inclusion in meta-openembedded: > > > > > > > > > > > > https://lists.openswitch.net/pipermail/ops-dev/2017 <https://lists.openswitch.net/pipermail/ops-dev/2017> > > > > > > -A > > > > > > pril/014715.html > > > > > > <https://lists.openswitch.net/pipermail/ops-dev/201 <https://lists.openswitch.net/pipermail/ops-dev/201> > > > > > > 7- > > > > > > April/014715.html> > > > > > > https://lists.openswitch.net/pipermail/ops-dev/2017 <https://lists.openswitch.net/pipermail/ops-dev/2017> > > > > > > -A > > > > > > pril/014716.html > > > > > > > > > > > > <https://lists.openswitch.net/pipermail/ops-dev/201 <https://lists.openswitch.net/pipermail/ops-dev/201> > > > > > > 7- > > > > > > April/014716.html> > > > > > > > > > > > > -- > > > > > > The following changes since commit > > > > > > 41cf832cc9abd6f2293a6d612463a34a53a9a52a: > > > > > > > > > > > > Revert "rrdtool: add gettext-native dependency" > > > > > > (2017-06-05 > > > > > > 11:13:09 > > > > > > +0200) > > > > > > > > > > > > are available in the git repository at: > > > > > > > > > > > > https://github.com/XevoInc/meta-openembedded <https://github.com/XevoInc/meta-openembedded> > > > > > > <https://github.com/XevoInc/meta-openembedded <https://github.com/XevoInc/meta-openembedded>> > > > > > > > > > > > > for you to fetch changes up to > > > > > > 402d1b3917195beb2ab7cac5dc94aaed8992b5a1: > > > > > > > > > > > > open-vm-tools: style changes (2017-06-07 22:31:34 > > > > > > +0000) > > > > > > > > > > > > --------------------------------------------------- > > > > > > ------------- > > > > > > Martin Kelly (14): > > > > > > add open-vm-tools recipe > > > > > > open-vm-tools: add missing pkgconfig > > > > > > dependency > > > > > > open-vm-tools: add missing glib-2.0-native > > > > > > dependency > > > > > > open-vm-tools: clarify and expand licensing > > > > > > open-vm-tools: base_contains --> > > > > > > bb.utils.contains > > > > > > open-vm-tools: update version to 10.1.5 > > > > > > open-vm-tools: don't use mspack > > > > > > open-vm-tools: don't use dnet-config > > > > > > open-vm-tools: add #include to fix build > > > > > > break > > > > > > open-vm-tools: add missing X11 dependencies > > > > > > open-vm-tools: remove kernel module logic > > > > > > open-vm-tools: line up configure options > > > > > > open-vm-tools: support FUSE > > > > > > open-vm-tools: style changes > > > > > > > > > > > > .../recipes-support/open-vm-tools/files/tools.conf > > > > > > > 2 + > > > > > > > > > > > > .../open-vm-tools/files/vmtoolsd.service > > > > > > | > > > > > > 11 +++ > > > > > > .../open-vm-tools/0001-Fix-kernel-detection.patch > > > > > > | > > > > > > 35 +++++++++ > > > > > > .../0002-configure.ac-don-t-use-dnet-config.patch > > > > > > | > > > > > > 41 ++++++++++ > > > > > > .../0003-add-include-sys-sysmacros.h.patch > > > > > > | > > > > > > 33 ++++++++ > > > > > > .../open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> > > > > > > <http://open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb>> | 90 > > > > > > ++++++++++++++++++++++ > > > > > > 6 files changed, 212 insertions(+) > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm- > > > > > > tools/files/tools.conf > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm- > > > > > > tools/files/vmtoolsd.service > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm- > > > > > > tools/0001-Fix-kernel-detection.patch > > > > > > > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm- > > > > > > tools/0002-configure.ac-don-t-use-dnet-config.patch > > > > > > > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm- > > > > > > tools/0003-add-include-sys-sysmacros.h.patch > > > > > > > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm- > > > > > > tools_10.1.5.bb <http://tools_10.1.5.bb> > > > > > > <http://open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb>> > > > > > > -- > > > > > > 2.1.4 > > > > > > > > > > > > > > > > > > (ping) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
Quoted 18 lines · Martin Kelly
Quoted 9 lines · Martin Jansa
It basically just calls this script:
openembedded-core/scripts/sstate-diff-machines.sh--machines="qemux86copy qemux86 qemuarm" --targets=world --tmpdir=tmp-glibc/ --analyze 2>&1 | tee ${LOGDIR}/signatures.logsee:
https://github.com/shr-project/jenkins-jobs/blob/master/jenkins-job.sh#L258Quoted 7 lines
for qemux86copy you either need to add meta-selftest layer from oe-core or apply:
http://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/master&id=9d45c08641b868322af4bebc2f095340cf4dac3fSorry I didn't reply earlier, I think it's resolved by dropped kernel dependency and I didn't notice the question about reproducing it.
Quoted 5 lines
I'm trying to run the script, but I'm just getting output suggesting everything is OK, even with the old change that I know has issues. I'm guessing I need to manually run through some steps that simulate what Jenkins would have done before running this script ("bitbake world" on several arches with a particular directory structure?).
It doesn't do anything special before or after the script (you don't need to build anything in order to compare signatures).
The whole jenkins setup is described here:
http://www.openembedded.org/wiki/Bitbake_World_Status_Setup
You can even call jenkins-job.sh manually if you really want, you just need to export JOB_NAME="oe_world_workspace-compare-signatures"
Quoted 9 lines
It seems to me we have a few options:
- Try to troubleshoot how to manually run the tests
- Submit the fixed-up version and hope it works. I agree that dropping the kernel dependency will probably fix the issue.
- If you know how to trigger the Jenkins build manually, you could test it on my new branch before I submit:
https://github.com/xevoinc/meta-openembedded/tree/open-vm-tools-v2I'm happy with any of these; let me know what you think.
Just submit the fixed-up version and I'll include it in next master-next run on jenkins.
For the create-pull-request issue we discussed earlier I'm using following parameters:
scripts/create-pull-request -u contrib -b ${B} -i ${B} -p "PATCH][${R}][RESEND" -r origin/${R} -s "Backports for ${R}" -o pull-${R}
Where R is release, e.g. morty and
B is e.g. B=jansa/${R}-backports
While branches are on openembedded-core-contrib repository:
http://git.openembedded.org/openembedded-core-contrib
and "contrib" is the git remote for it:
OE @ ~/openembedded-core $ git remote -v | grep contrib
contrib git+ssh://[email protected]/openembedded-core-contrib (fetch) contrib git+ssh://[email protected]/openembedded-core-contrib (push)
and since this change:
commit 98faa3ec872e06774b5870fcfb52f3ff91494779
Author: Robert Yang <[email protected]> Date: Tue Apr 5 19:31:27 2016 -0700
create-pull-request: fix for newer git
Fixed when git > 2.1.0:
I also need to specify local branch name with -l or it will wrongly assume HEAD and fail with:
NOTE: Assuming local branch HEAD, use -l to override.
warn: No match for commit 9d45c08641b868322af4bebc2f095340cf4dac3f found at git://git.openembedded.org/openembedded-core-contrib
warn: Are you sure you pushed 'jansa/morty-backports' there?
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your diff.renameLimit variable to at least 1151 and retry the command.
ERROR: git request-pull reported an error
So currently my script calls it as:scripts/create-pull-request -u contrib -l ${B} -b ${B} -i ${B} -p "PATCH][${R}][RESEND" -r origin/${R} -s "Backports for ${R}" -o pull-${R}
Quoted 356 lines
Quoted 356 lines
On Thu, Jun 22, 2017 at 7:15 PM, Martin Kelly <[email protected] <mailto:[email protected]>> wrote:
(ping) I apologize for the top-post but did not want to have the ping lost in the noise. On Mon, 2017-06-19 at 16:43 -0700, Martin Kelly wrote: > On Sun, 2017-06-18 at 22:28 +0200, Martin Jansa wrote: > > And there is also this: > > > > === Incorrect PACKAGE_ARCH or sstate signatures (3) === > > > > Complete log: http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/ <http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/> > > lo > > g.signatures.20170618_014055.log/ > > * ERROR: 3 issues were found in these recipes: open-vm-tools > > > > * ERROR: 1 errors found in > > signatures.qemux86.do_configure.sigdata.log > > * ERROR: 1 errors found in > > signatures.qemux86.do_populate_sysroot.sigdata.log > > * ERROR: 1 errors found in > > signatures.qemux86.do_package_write_ipk.sigdata.log > > > > * ERROR: open-vm-tools different signature for task > > do_configure.sigdata between qemux86copy and qemux86 > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp- > > glibc/sstate- > > diff/1497786055/signatures.qemux86.do_configure.sigdata.log > > * ERROR: open-vm-tools different signature for task > > do_populate_sysroot.sigdata between qemux86copy and qemux86 > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp- > > glibc/sstate- > > diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log > > * ERROR: open-vm-tools different signature for task > > do_package_write_ipk.sigdata between qemux86copy and qemux86 > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp- > > glibc/sstate- > > diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log > > * ERROR: 3 issues were found in these recipes: open-vm-tools > > > > So it probably depends on some MACHINE specific variable without > > being marked as MACHINE_ARCH. > > > > Looking at: > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb <http://tools_10.1.5.bb> > > > > It's depending on kernel, so it needs to be MACHINE_ARCH, also I've > > noticed few more issues: > > > > Thanks for all the feedback. I believe I've now fixed all the issues > you outlined. > > I dropped the kernel dependency entirely, as we're no longer building > the kernel modules (they all got upstreamed). Thus I suspect the > issue > is no longer present with my latest changes. > > That said, I can't repro the sstate errors on my local machine. Could > you provide repro steps so I can verify this is fixed before I send > new > patches? > > > DEPENDS is there twice: > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb#L24 <http://tools_10.1.5.bb#L24> > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb#L39 <http://tools_10.1.5.bb#L39> > > > > What is supposed to set KERNEL_VERSION variable in: > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb#L58 <http://tools_10.1.5.bb#L58> > > ? > > > > Don't use tags in SRCREV, use git hash instead (otherwise bitbake > > fetcher will reach upstream git repo every single time the recipe > > is > > parsed and will cause failed builds when github isn't accessible). > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb#L35 <http://tools_10.1.5.bb#L35> > > > > There are many hardcoded paths like /usr/lib/ or /usr/sbin/, please > > use proper variables like libdir, sbindir. > > > > Once you fix these issues please resend all changes to the ML, it's > > much better to review inline than this. > > > > Regards, > > > > > > On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <[email protected] > > om > > > wrote: > > > Fails to configure on qemuarm. > > > > > > If arm isn't expected to be supported, can you please update > > > COMPATIBLE_HOST restriction? > > > > > > http://errors.yoctoproject.org/Errors/Details/145599/ <http://errors.yoctoproject.org/Errors/Details/145599/> > > > > > > On Thu, Jun 15, 2017 at 7:50 PM, Martin Jansa <martin.jansa@gmail > > > .c > > > om> wrote: > > > > OK, I'll try to remember to fix it before merge. > > > > > > > > I'm sorry about it, tweaking other people commits always > > > > strikes > > > > back :). > > > > > > > > On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly <[email protected] <mailto:[email protected]>> > > > > wrote: > > > > > On 06/15/2017 09:54 AM, Martin Jansa wrote: > > > > > > It didn't make it to patchwork, because you've sent only > > > > > > the > > > > > > cover > > > > > > letter. I've added it to master-next now. > > > > > > > > > > > > Next time please send also individual patches. So that it > > > > > > gets more > > > > > > visibility for other people to comment and also that I can > > > > > > use patchwork > > > > > > to pull it in. > > > > > > > > > > > > Regards, > > > > > > > > > > > > > > > > > > > > > > > > > > > Small note: Looks like the initial commit (24b2ac) has a > > > > > small > > > > > typo that should ideally be fixed before it's merged into > > > > > master: > > > > > > > > > > "open-vm-tools: add recipe from meat-foss-openswitch" > > > > > > > > > > "meat" --> "meta" > > > > > > > > > > > On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo. > > > > > > co > > > > > > m > > > > > > <mailto:[email protected] <mailto:[email protected]>>> wrote: > > > > > > > > > > > > On 06/09/2017 03:22 PM, Martin Kelly wrote: > > > > > > > > > > > > Hi all, > > > > > > > > > > > > This patch series adds a new recipe for Open VM > > > > > > Tools > > > > > > to > > > > > > meta-oe. This > > > > > > recipe is invaluable for using Openembedded with > > > > > > VMWare, as > > > > > > without the > > > > > > tools, performance is very slow. > > > > > > > > > > > > More information about Open VM Tools can be found > > > > > > here: > > > > > > > > > > > > https://github.com/vmware/open-vm-tools <https://github.com/vmware/open-vm-tools> > > > > > > <https://github.com/vmware/open-vm-tools <https://github.com/vmware/open-vm-tools>> > > > > > > > > > > > > Please note that, as mentioned in the first commit, > > > > > > this recipe is > > > > > > modified from the recipe originally found in the > > > > > > Open-Switch > > > > > > repository. > > > > > > The first patch is directly from that repository, > > > > > > and > > > > > > the following > > > > > > patches are modifications to it. > > > > > > > > > > > > Original recipe: > > > > > > https://github.com/open-switch/ops-build <https://github.com/open-switch/ops-build> > > > > > > <https://github.com/open-switch/ops-build <https://github.com/open-switch/ops-build>> > > > > > > yocto/openswitch/meta-foss-openswitch/recipes- > > > > > > extended/open-vm-tools/open-vm-tools_10.0.5.bb <http://open-vm-tools_10.0.5.bb> > > > > > > <http://open-vm-tools_10.0.5.bb <http://open-vm-tools_10.0.5.bb>> > > > > > > > > > > > > Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9 > > > > > > > > > > > > Although the original recipe packaging was Apache- > > > > > > licensed, I > > > > > > received > > > > > > permission from the author (Diego Dompe) to > > > > > > relicense > > > > > > it under > > > > > > the MIT > > > > > > license for inclusion in meta-openembedded: > > > > > > > > > > > > https://lists.openswitch.net/pipermail/ops-dev/2017 <https://lists.openswitch.net/pipermail/ops-dev/2017> > > > > > > -A > > > > > > pril/014715.html > > > > > > <https://lists.openswitch.net/pipermail/ops-dev/201 <https://lists.openswitch.net/pipermail/ops-dev/201> > > > > > > 7- > > > > > > April/014715.html> > > > > > > https://lists.openswitch.net/pipermail/ops-dev/2017 <https://lists.openswitch.net/pipermail/ops-dev/2017> > > > > > > -A > > > > > > pril/014716.html > > > > > > > > > > > > <https://lists.openswitch.net/pipermail/ops-dev/201 <https://lists.openswitch.net/pipermail/ops-dev/201> > > > > > > 7- > > > > > > April/014716.html> > > > > > > > > > > > > -- > > > > > > The following changes since commit > > > > > > 41cf832cc9abd6f2293a6d612463a34a53a9a52a: > > > > > > > > > > > > Revert "rrdtool: add gettext-native dependency" > > > > > > (2017-06-05 > > > > > > 11:13:09 > > > > > > +0200) > > > > > > > > > > > > are available in the git repository at: > > > > > > > > > > > > https://github.com/XevoInc/meta-openembedded <https://github.com/XevoInc/meta-openembedded> > > > > > > <https://github.com/XevoInc/meta-openembedded <https://github.com/XevoInc/meta-openembedded>> > > > > > > > > > > > > for you to fetch changes up to > > > > > > 402d1b3917195beb2ab7cac5dc94aaed8992b5a1: > > > > > > > > > > > > open-vm-tools: style changes (2017-06-07 22:31:34 > > > > > > +0000) > > > > > > > > > > > > --------------------------------------------------- > > > > > > ------------- > > > > > > Martin Kelly (14): > > > > > > add open-vm-tools recipe > > > > > > open-vm-tools: add missing pkgconfig > > > > > > dependency > > > > > > open-vm-tools: add missing glib-2.0-native > > > > > > dependency > > > > > > open-vm-tools: clarify and expand licensing > > > > > > open-vm-tools: base_contains --> > > > > > > bb.utils.contains > > > > > > open-vm-tools: update version to 10.1.5 > > > > > > open-vm-tools: don't use mspack > > > > > > open-vm-tools: don't use dnet-config > > > > > > open-vm-tools: add #include to fix build > > > > > > break > > > > > > open-vm-tools: add missing X11 dependencies > > > > > > open-vm-tools: remove kernel module logic > > > > > > open-vm-tools: line up configure options > > > > > > open-vm-tools: support FUSE > > > > > > open-vm-tools: style changes > > > > > > > > > > > > .../recipes-support/open-vm-tools/files/tools.conf > > > > > > > 2 + > > > > > > > > > > > > .../open-vm-tools/files/vmtoolsd.service > > > > > > | > > > > > > 11 +++ > > > > > > .../open-vm-tools/0001-Fix-kernel-detection.patch > > > > > > | > > > > > > 35 +++++++++ > > > > > > .../0002-configure.ac-don-t-use-dnet-config.patch > > > > > > | > > > > > > 41 ++++++++++ > > > > > > .../0003-add-include-sys-sysmacros.h.patch > > > > > > | > > > > > > 33 ++++++++ > > > > > > .../open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> > > > > > > <http://open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb>> | 90 > > > > > > ++++++++++++++++++++++ > > > > > > 6 files changed, 212 insertions(+) > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm- > > > > > > tools/files/tools.conf > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm- > > > > > > tools/files/vmtoolsd.service > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm- > > > > > > tools/0001-Fix-kernel-detection.patch > > > > > > > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm- > > > > > > tools/0002-configure.ac-don-t-use-dnet-config.patch > > > > > > > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm- > > > > > > tools/0003-add-include-sys-sysmacros.h.patch > > > > > > > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm- > > > > > > tools_10.1.5.bb <http://tools_10.1.5.bb> > > > > > > <http://open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb>> > > > > > > -- > > > > > > 2.1.4 > > > > > > > > > > > > > > > > > > (ping) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Quoted 83 lines · Martin Jansa
Quoted 18 lines · Martin Kelly
Quoted 9 lines · Martin Jansa
It basically just calls this script:
openembedded-core/scripts/sstate-diff-machines.sh--machines="qemux86copy qemux86 qemuarm" --targets=world --tmpdir=tmp-glibc/ --analyze 2>&1 | tee ${LOGDIR}/signatures.logsee:
https://github.com/shr-project/jenkins-jobs/blob/master/jenkins-job.sh#L258Quoted 7 lines
for qemux86copy you either need to add meta-selftest layer from oe-core or apply:
http://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/master&id=9d45c08641b868322af4bebc2f095340cf4dac3fSorry I didn't reply earlier, I think it's resolved by dropped kernel dependency and I didn't notice the question about reproducing it.
Quoted 5 lines
I'm trying to run the script, but I'm just getting output suggesting everything is OK, even with the old change that I know has issues. I'm guessing I need to manually run through some steps that simulate what Jenkins would have done before running this script ("bitbake world" on several arches with a particular directory structure?).
It doesn't do anything special before or after the script (you don't need to build anything in order to compare signatures).
The whole jenkins setup is described here:
http://www.openembedded.org/wiki/Bitbake_World_Status_SetupYou can even call
jenkins-job.shmanually if you really want, you just need to export JOB_NAME="oe_world_workspace-compare-signatures"Quoted 9 lines
It seems to me we have a few options:
- Try to troubleshoot how to manually run the tests
- Submit the fixed-up version and hope it works. I agree that dropping the kernel dependency will probably fix the issue.
- If you know how to trigger the Jenkins build manually, you could test it on my new branch before I submit:
https://github.com/xevoinc/meta-openembedded/tree/open-vm-tools-v2I'm happy with any of these; let me know what you think.
Just submit the fixed-up version and I'll include it in next master-next run on jenkins.
For the create-pull-request issue we discussed earlier I'm using following parameters:
scripts/create-pull-request-u contrib -b ${B} -i ${B} -p "PATCH][${R}][RESEND" -r origin/${R} -s "Backports for ${R}" -o pull-${R}Where R is release, e.g. morty and
B is e.g. B=jansa/${R}-backportsWhile branches are on openembedded-core-contrib repository:
http://git.openembedded.org/openembedded-core-contrib
and "contrib" is the git remote for it:
OE @ ~/openembedded-core $ git remote -v | grep contrib
contrib git+ssh://[email protected]/openembedded-core-contrib (fetch) contrib git+ssh://[email protected]/openembedded-core-contrib (push)and since this change:
commit98faa3ec872e06774b5870fcfb52f3ff91494779Author: Robert Yang <[email protected]> Date: Tue Apr 5 19:31:27 2016 -0700create-pull-request: fix for newer git
Fixed when git > 2.1.0:
I also need to specify local branch name with -l or it will wrongly assume HEAD and fail with:
NOTE: Assuming local branch HEAD, use -l to override.
warn: No match for commit9d45c08641b868322af4bebc2f095340cf4dac3ffound atgit://git.openembedded.org/openembedded-core-contrib
warn: Are you sure you pushed 'jansa/morty-backports' there?
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your diff.renameLimit variable to at least 1151 and retry the command.
ERROR: git request-pull reported an error
Quoted 3 lines
So currently my script calls it as:
scripts/create-pull-request-u contrib -l ${B} -b ${B} -i ${B} -p "PATCH][${R}][RESEND" -r origin/${R} -s "Backports for ${R}" -o pull-${R}
Thanks, I finally got the invocation to work and sent it off. I think I recall hitting the note about "Assuming local branch HEAD", so I probably needed to add -l.
Quoted 357 lines
Quoted 356 lines
Quoted 356 lines
On Thu, Jun 22, 2017 at 7:15 PM, Martin Kelly <[email protected] <mailto:[email protected]>> wrote:
(ping) I apologize for the top-post but did not want to have the ping lost in the noise. On Mon, 2017-06-19 at 16:43 -0700, Martin Kelly wrote: > On Sun, 2017-06-18 at 22:28 +0200, Martin Jansa wrote: > > And there is also this: > > > > === Incorrect PACKAGE_ARCH or sstate signatures (3) === > > > > Complete log: http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/ <http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/> > > lo > > g.signatures.20170618_014055.log/ > > * ERROR: 3 issues were found in these recipes: open-vm-tools > > > > * ERROR: 1 errors found in > > signatures.qemux86.do_configure.sigdata.log > > * ERROR: 1 errors found in > > signatures.qemux86.do_populate_sysroot.sigdata.log > > * ERROR: 1 errors found in > > signatures.qemux86.do_package_write_ipk.sigdata.log > > > > * ERROR: open-vm-tools different signature for task > > do_configure.sigdata between qemux86copy and qemux86 > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp- > > glibc/sstate- > > diff/1497786055/signatures.qemux86.do_configure.sigdata.log > > * ERROR: open-vm-tools different signature for task > > do_populate_sysroot.sigdata between qemux86copy and qemux86 > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp- > > glibc/sstate- > > diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log > > * ERROR: open-vm-tools different signature for task > > do_package_write_ipk.sigdata between qemux86copy and qemux86 > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp- > > glibc/sstate- > > diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log > > * ERROR: 3 issues were found in these recipes: open-vm-tools > > > > So it probably depends on some MACHINE specific variable without > > being marked as MACHINE_ARCH. > > > > Looking at: > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb <http://tools_10.1.5.bb> > > > > It's depending on kernel, so it needs to be MACHINE_ARCH, also I've > > noticed few more issues: > > > > Thanks for all the feedback. I believe I've now fixed all the issues > you outlined. > > I dropped the kernel dependency entirely, as we're no longer building > the kernel modules (they all got upstreamed). Thus I suspect the > issue > is no longer present with my latest changes. > > That said, I can't repro the sstate errors on my local machine. Could > you provide repro steps so I can verify this is fixed before I send > new > patches? > > > DEPENDS is there twice: > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb#L24 <http://tools_10.1.5.bb#L24> > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb#L39 <http://tools_10.1.5.bb#L39> > > > > What is supposed to set KERNEL_VERSION variable in: > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb#L58 <http://tools_10.1.5.bb#L58> > > ? > > > > Don't use tags in SRCREV, use git hash instead (otherwise bitbake > > fetcher will reach upstream git repo every single time the recipe > > is > > parsed and will cause failed builds when github isn't accessible). > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2 <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2> > > ab > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open- > > vm- > > tools_10.1.5.bb#L35 <http://tools_10.1.5.bb#L35> > > > > There are many hardcoded paths like /usr/lib/ or /usr/sbin/, please > > use proper variables like libdir, sbindir. > > > > Once you fix these issues please resend all changes to the ML, it's > > much better to review inline than this. > > > > Regards, > > > > > > On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <[email protected] > > om > > > wrote: > > > Fails to configure on qemuarm. > > > > > > If arm isn't expected to be supported, can you please update > > > COMPATIBLE_HOST restriction? > > > > > > http://errors.yoctoproject.org/Errors/Details/145599/ <http://errors.yoctoproject.org/Errors/Details/145599/> > > > > > > On Thu, Jun 15, 2017 at 7:50 PM, Martin Jansa <martin.jansa@gmail > > > .c > > > om> wrote: > > > > OK, I'll try to remember to fix it before merge. > > > > > > > > I'm sorry about it, tweaking other people commits always > > > > strikes > > > > back :). > > > > > > > > On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly <[email protected] <mailto:[email protected]>> > > > > wrote: > > > > > On 06/15/2017 09:54 AM, Martin Jansa wrote: > > > > > > It didn't make it to patchwork, because you've sent only > > > > > > the > > > > > > cover > > > > > > letter. I've added it to master-next now. > > > > > > > > > > > > Next time please send also individual patches. So that it > > > > > > gets more > > > > > > visibility for other people to comment and also that I can > > > > > > use patchwork > > > > > > to pull it in. > > > > > > > > > > > > Regards, > > > > > > > > > > > > > > > > > > > > > > > > > > > Small note: Looks like the initial commit (24b2ac) has a > > > > > small > > > > > typo that should ideally be fixed before it's merged into > > > > > master: > > > > > > > > > > "open-vm-tools: add recipe from meat-foss-openswitch" > > > > > > > > > > "meat" --> "meta" > > > > > > > > > > > On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo. > > > > > > co > > > > > > m > > > > > > <mailto:[email protected] <mailto:[email protected]>>> wrote: > > > > > > > > > > > > On 06/09/2017 03:22 PM, Martin Kelly wrote: > > > > > > > > > > > > Hi all, > > > > > > > > > > > > This patch series adds a new recipe for Open VM > > > > > > Tools > > > > > > to > > > > > > meta-oe. This > > > > > > recipe is invaluable for using Openembedded with > > > > > > VMWare, as > > > > > > without the > > > > > > tools, performance is very slow. > > > > > > > > > > > > More information about Open VM Tools can be found > > > > > > here: > > > > > > > > > > > > https://github.com/vmware/open-vm-tools <https://github.com/vmware/open-vm-tools> > > > > > > <https://github.com/vmware/open-vm-tools <https://github.com/vmware/open-vm-tools>> > > > > > > > > > > > > Please note that, as mentioned in the first commit, > > > > > > this recipe is > > > > > > modified from the recipe originally found in the > > > > > > Open-Switch > > > > > > repository. > > > > > > The first patch is directly from that repository, > > > > > > and > > > > > > the following > > > > > > patches are modifications to it. > > > > > > > > > > > > Original recipe: > > > > > > https://github.com/open-switch/ops-build <https://github.com/open-switch/ops-build> > > > > > > <https://github.com/open-switch/ops-build <https://github.com/open-switch/ops-build>> > > > > > > yocto/openswitch/meta-foss-openswitch/recipes- > > > > > > extended/open-vm-tools/open-vm-tools_10.0.5.bb <http://open-vm-tools_10.0.5.bb> > > > > > > <http://open-vm-tools_10.0.5.bb <http://open-vm-tools_10.0.5.bb>> > > > > > > > > > > > > Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9 > > > > > > > > > > > > Although the original recipe packaging was Apache- > > > > > > licensed, I > > > > > > received > > > > > > permission from the author (Diego Dompe) to > > > > > > relicense > > > > > > it under > > > > > > the MIT > > > > > > license for inclusion in meta-openembedded: > > > > > > > > > > > > https://lists.openswitch.net/pipermail/ops-dev/2017 <https://lists.openswitch.net/pipermail/ops-dev/2017> > > > > > > -A > > > > > > pril/014715.html > > > > > > <https://lists.openswitch.net/pipermail/ops-dev/201 <https://lists.openswitch.net/pipermail/ops-dev/201> > > > > > > 7- > > > > > > April/014715.html> > > > > > > https://lists.openswitch.net/pipermail/ops-dev/2017 <https://lists.openswitch.net/pipermail/ops-dev/2017> > > > > > > -A > > > > > > pril/014716.html > > > > > > > > > > > > <https://lists.openswitch.net/pipermail/ops-dev/201 <https://lists.openswitch.net/pipermail/ops-dev/201> > > > > > > 7- > > > > > > April/014716.html> > > > > > > > > > > > > -- > > > > > > The following changes since commit > > > > > > 41cf832cc9abd6f2293a6d612463a34a53a9a52a: > > > > > > > > > > > > Revert "rrdtool: add gettext-native dependency" > > > > > > (2017-06-05 > > > > > > 11:13:09 > > > > > > +0200) > > > > > > > > > > > > are available in the git repository at: > > > > > > > > > > > > https://github.com/XevoInc/meta-openembedded <https://github.com/XevoInc/meta-openembedded> > > > > > > <https://github.com/XevoInc/meta-openembedded <https://github.com/XevoInc/meta-openembedded>> > > > > > > > > > > > > for you to fetch changes up to > > > > > > 402d1b3917195beb2ab7cac5dc94aaed8992b5a1: > > > > > > > > > > > > open-vm-tools: style changes (2017-06-07 22:31:34 > > > > > > +0000) > > > > > > > > > > > > --------------------------------------------------- > > > > > > ------------- > > > > > > Martin Kelly (14): > > > > > > add open-vm-tools recipe > > > > > > open-vm-tools: add missing pkgconfig > > > > > > dependency > > > > > > open-vm-tools: add missing glib-2.0-native > > > > > > dependency > > > > > > open-vm-tools: clarify and expand licensing > > > > > > open-vm-tools: base_contains --> > > > > > > bb.utils.contains > > > > > > open-vm-tools: update version to 10.1.5 > > > > > > open-vm-tools: don't use mspack > > > > > > open-vm-tools: don't use dnet-config > > > > > > open-vm-tools: add #include to fix build > > > > > > break > > > > > > open-vm-tools: add missing X11 dependencies > > > > > > open-vm-tools: remove kernel module logic > > > > > > open-vm-tools: line up configure options > > > > > > open-vm-tools: support FUSE > > > > > > open-vm-tools: style changes > > > > > > > > > > > > .../recipes-support/open-vm-tools/files/tools.conf > > > > > > > 2 + > > > > > > > > > > > > .../open-vm-tools/files/vmtoolsd.service > > > > > > | > > > > > > 11 +++ > > > > > > .../open-vm-tools/0001-Fix-kernel-detection.patch > > > > > > | > > > > > > 35 +++++++++ > > > > > > .../0002-configure.ac-don-t-use-dnet-config.patch > > > > > > | > > > > > > 41 ++++++++++ > > > > > > .../0003-add-include-sys-sysmacros.h.patch > > > > > > | > > > > > > 33 ++++++++ > > > > > > .../open-vm-tools/open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb> > > > > > > <http://open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb>> | 90 > > > > > > ++++++++++++++++++++++ > > > > > > 6 files changed, 212 insertions(+) > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm- > > > > > > tools/files/tools.conf > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm- > > > > > > tools/files/vmtoolsd.service > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm- > > > > > > tools/0001-Fix-kernel-detection.patch > > > > > > > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm- > > > > > > tools/0002-configure.ac-don-t-use-dnet-config.patch > > > > > > > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm- > > > > > > tools/0003-add-include-sys-sysmacros.h.patch > > > > > > > > > > > > create mode 100644 > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm- > > > > > > tools_10.1.5.bb <http://tools_10.1.5.bb> > > > > > > <http://open-vm-tools_10.1.5.bb <http://open-vm-tools_10.1.5.bb>> > > > > > > -- > > > > > > 2.1.4 > > > > > > > > > > > > > > > > > > (ping) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
-----Original Message-----
From: Martin Jansa <[email protected]>
To: Martin Kelly <[email protected]>
Cc: openembeded-devel <[email protected]>, Koen Kooi <[email protected]>
Subject: Re: [oe] [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
Date: Sun, 18 Jun 2017 21:58:47 +0200
Fails to configure on qemuarm.
If arm isn't expected to be supported, can you please update COMPATIBLE_HOST restriction?
http://errors.yoctoproject.org/Errors/Details/145599/
Yes, I will fix this and the other issues you found. Thanks for finding them.
Quoted 169 lines · Martin Jansa
OK, I'll try to remember to fix it before merge.
I'm sorry about it, tweaking other people commits always strikes back :).
Quoted 160 lines · Martin Kelly
Quoted 4 lines · Martin Jansa
It didn't make it to patchwork, because you've sent only the cover
letter. I've added it to master-next now.Quoted 9 lines
Next time please send also individual patches. So that it gets more
visibility for other people to comment and also that I can use patchwork
to pull it in.Regards,
Small note: Looks like the initial commit (24b2ac) has a small typo that should ideally be fixed before it's merged into master:"open-vm-tools: add recipe from meat-foss-openswitch"
"meat" --> "meta"
Quoted 133 lines
On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <[email protected] <mailto:[email protected]>> wrote:
On 06/09/2017 03:22 PM, Martin Kelly wrote:
Hi all,
This patch series adds a new recipe for Open VM Tools to meta-oe. This
recipe is invaluable for using Openembedded with VMWare, as
without the
tools, performance is very slow.More information about Open VM Tools can be found here:
https://github.com/vmware/open-vm-tools
<https://github.com/vmware/open-vm-tools>Please note that, as mentioned in the first commit, this recipe is
modified from the recipe originally found in the Open- Switch
repository.
The first patch is directly from that repository, and the following
patches are modifications to it.Original recipe:
https://github.com/open-switch/ops-build
<https://github.com/open-switch/ops-build>
yocto/openswitch/meta-foss-openswitch/recipes- extended/open-vm-tools/open-vm-tools_10.0.5.bb
<http://open-vm-tools_10.0.5.bb>Commit
9008de2d8e100f3f868c66765742bca9fa98f3f9Although the original recipe packaging was Apache- licensed, I
received
permission from the author (Diego Dompe) to relicense it under
the MIT
license for inclusion in meta-openembedded:https://lists.openswitch.net/pipermail/ops-dev/2017-April
/014715.html
<https://lists.openswitch.net/pipermail/ops-dev/2017-Apri
l/014715.html>
https://lists.openswitch.net/pipermail/ops-dev/2017-April
/014716.html<https://lists.openswitch.net/pipermail/ops-dev/2017-Apri
l/014716.html>--
The following changes since commit
41cf832cc9abd6f2293a6d612463a34a53a9a52a:Revert "rrdtool: add gettext-native dependency" (2017- 06-05
11:13:09
+0200)are available in the git repository at:
https://github.com/XevoInc/meta-openembedded
<https://github.com/XevoInc/meta-openembedded>for you to fetch changes up to
402d1b3917195beb2ab7cac5dc94aaed8992b5a1:open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
-------------------------------------------------------
---------
Martin Kelly (14):
add open-vm-tools recipe
open-vm-tools: add missing pkgconfig dependency
open-vm-tools: add missing glib-2.0-native dependency
open-vm-tools: clarify and expand licensing
open-vm-tools:base_contains--> bb.utils.contains
open-vm-tools: update version to 10.1.5
open-vm-tools: don't use mspack
open-vm-tools: don't use dnet-config
open-vm-tools: add #include to fix build break
open-vm-tools: add missing X11 dependencies
open-vm-tools: remove kernel module logic
open-vm-tools: line up configure options
open-vm-tools: support FUSE
open-vm-tools: style changes.../recipes-support/open-vm-tools/files/tools.conf | 2 +
.../open-vm-tools/files/vmtoolsd.service | 11
+++
.../open-vm-tools/0001-Fix-kernel-detection.patch | 35
+++++++++
.../0002-configure.ac-don-t-use-dnet-config.patch | 41
++++++++++
.../0003-add-include-sys-sysmacros.h.patch | 33
++++++++
.../open-vm-tools/open-vm-tools_10.1.5.bb
<http://open-vm-tools_10.1.5.bb> | 90
++++++++++++++++++++++6 files changed, 212 insertions(+)create mode 100644
meta-oe/recipes-support/open-vm-tools/files/tools.confcreate mode 100644 meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001- Fix-kernel-detection.patchcreate mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002- configure.ac-don-t-use-dnet-config.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003- add-include-sys-sysmacros.h.patch
create mode 100644 meta-oe/recipes-support/open-vm-tools/open-vm- tools_10.1.5.bb
<http://open-vm-tools_10.1.5.bb>
--
2.1.4Quoted 4 lines
(ping)