Skip to contentSkip to conversation

qttools: DEPENDS on icu

PATCH In review [email protected] 3 participants 7 messages Jun 20, 2017 – Jun 27, 2017 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qttools: DEPENDS on icu

From: Ming Liu <[email protected]>

This fixes a following QA issue:

| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicui18n, but it isn't a build dependency.
| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicuuc, but it isn't a build dependency.
| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicudata, but it isn't a build dependency.
---
 recipes-qt/qt5/qttools_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt/qt5/qttools_git.bb +1 -1
index 5c0f51c..1108390 100644
@@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = " \
 
 inherit ptest
 
-DEPENDS += "qtbase qtdeclarative qtxmlpatterns"
+DEPENDS += "qtbase qtdeclarative qtxmlpatterns icu"
 
 SRC_URI += " \
     file://run-ptest \
Signature · 1 line
2.7.4
#1 lore raw
Quoted 6 lines · On Tue, Jun 20, 2017 at 06:28:32AM +0200, [email protected] wrote:

From: Ming Liu <[email protected]>

This fixes a following QA issue:

| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicui18n, but it isn't a build dependency.
| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicuuc, but it isn't a build dependency.
| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicudata, but it isn't a build dependency.

It seems there's inconsistency here between errors above referring to nativesdk-qtbase-tools and the change below made to qttools instead of qtbase!

I wonder if this fix was not included by the author:

https://github.com/meta-qt5/meta-qt5/commit/ff073f04109900fc07bf81e2f1df63c626caf342

Just to double-check, I just built nativesdk-qttools using meta-qt5 w/o this patch and I don't see the above QA errors.

Signature · 1 line
Denys
Quoted 26 lines
---
 recipes-qt/qt5/qttools_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt/qt5/qttools_git.bb +1 -1
index 5c0f51c..1108390 100644
@@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = " \
 
 inherit ptest
 
-DEPENDS += "qtbase qtdeclarative qtxmlpatterns"
+DEPENDS += "qtbase qtdeclarative qtxmlpatterns icu"
 
 SRC_URI += " \
     file://run-ptest \
Signature · 7 lines
2.7.4

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
#2 lore raw

Martin,

Were you able to look into this yet? I didn't copy you directly at first, so not sure if you missed it...

Quoted 54 lines · Denys Dmytriyenko
Quoted 6 lines · On Tue, Jun 20, 2017 at 06:28:32AM +0200, [email protected] wrote:

From: Ming Liu <[email protected]>

This fixes a following QA issue:

| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicui18n, but it isn't a build dependency.
| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicuuc, but it isn't a build dependency.
| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicudata, but it isn't a build dependency.

It seems there's inconsistency here between errors above referring to nativesdk-qtbase-tools and the change below made to qttools instead of qtbase!

I wonder if this fix was not included by the author:

https://github.com/meta-qt5/meta-qt5/commit/ff073f04109900fc07bf81e2f1df63c626caf342

Just to double-check, I just built nativesdk-qttools using meta-qt5 w/o this patch and I don't see the above QA errors.

Signature · 1 line
Denys
Quoted 26 lines
---
 recipes-qt/qt5/qttools_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt/qt5/qttools_git.bb +1 -1
index 5c0f51c..1108390 100644
@@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = " \
 
 inherit ptest
 
-DEPENDS += "qtbase qtdeclarative qtxmlpatterns"
+DEPENDS += "qtbase qtdeclarative qtxmlpatterns icu"
 
 SRC_URI += " \
     file://run-ptest \
Signature · 7 lines
2.7.4

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
#3 lore raw

Yes, I've seen both e-mails. I'm waiting for response from author, then I'll revert it in master and pyro branches.

Quoted 69 lines · Denys Dmytriyenko

Martin,

Were you able to look into this yet? I didn't copy you directly at first, so
not sure if you missed it...

Quoted 5 lines · Denys Dmytriyenko
Quoted 4 lines · On Tue, Jun 20, 2017 at 06:28:32AM +0200, [email protected] wrote:

From: Ming Liu <[email protected]>

This fixes a following QA issue:
| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicui18n,

but it isn't a build dependency.

Quoted 1 line
Quoted 1 line

| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicuuc, but

it isn't a build dependency.

Quoted 1 line
Quoted 1 line

| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicudata,

but it isn't a build dependency.

Quoted 8 lines

It seems there's inconsistency here between errors above referring to nativesdk-qtbase-tools and the change below made to qttools instead of qtbase!

I wonder if this fix was not included by the author:

https://github.com/meta-qt5/meta-qt5/commit/

ff073f04109900fc07bf81e2f1df63c626caf342

Quoted 2 lines

Just to double-check, I just built nativesdk-qttools using meta-qt5 w/o

this

Quoted 6 lines

patch and I don't see the above QA errors.

--
Denys

Quoted 6 lines

recipes-qt/qt5/

Quoted 6 lines
---
 recipes-qt/qt5/qttools_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt/qt5/ renamed from recipes-qt/qt5/qttools_git.bb +0 -0

qttools_git.bb

Quoted 25 lines
Quoted 15 lines

index 5c0f51c..1108390 100644

recipes-qt/qt5/qttools_git.bb +1 -2
@@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = " \
 
 inherit ptest
 
-DEPENDS += "qtbase qtdeclarative qtxmlpatterns"
+DEPENDS += "qtbase qtdeclarative qtxmlpatterns icu"
 
 SRC_URI += " \
     file://run-ptest \
--

2.7.4

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw

Thanks.

Quoted 74 lines · Martin Jansa

Yes, I've seen both e-mails. I'm waiting for response from author, then I'll revert it in master and pyro branches.

Quoted 69 lines · Denys Dmytriyenko

Martin,

Were you able to look into this yet? I didn't copy you directly at first, so
not sure if you missed it...

Quoted 5 lines · Denys Dmytriyenko
Quoted 4 lines · On Tue, Jun 20, 2017 at 06:28:32AM +0200, [email protected] wrote:

From: Ming Liu <[email protected]>

This fixes a following QA issue:
| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicui18n,

but it isn't a build dependency.

Quoted 1 line
Quoted 1 line

| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicuuc, but

it isn't a build dependency.

Quoted 1 line
Quoted 1 line

| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicudata,

but it isn't a build dependency.

Quoted 8 lines

It seems there's inconsistency here between errors above referring to nativesdk-qtbase-tools and the change below made to qttools instead of qtbase!

I wonder if this fix was not included by the author:

https://github.com/meta-qt5/meta-qt5/commit/

ff073f04109900fc07bf81e2f1df63c626caf342

Quoted 2 lines

Just to double-check, I just built nativesdk-qttools using meta-qt5 w/o

this

Quoted 6 lines

patch and I don't see the above QA errors.

--
Denys

Quoted 6 lines

recipes-qt/qt5/

Quoted 6 lines
---
 recipes-qt/qt5/qttools_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt/qt5/ renamed from recipes-qt/qt5/qttools_git.bb +0 -0

qttools_git.bb

Quoted 25 lines
Quoted 15 lines

index 5c0f51c..1108390 100644

recipes-qt/qt5/qttools_git.bb +1 -2
@@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = " \
 
 inherit ptest
 
-DEPENDS += "qtbase qtdeclarative qtxmlpatterns"
+DEPENDS += "qtbase qtdeclarative qtxmlpatterns icu"
 
 SRC_URI += " \
     file://run-ptest \
--

2.7.4

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

A message that is not in the archive (sent off-list or not yet received): CALatG=7jn597sL8XE2hk8X67smJTH84HPe+wsYzwHC1HNHh9cA@mail.gmail.com

#6 lore raw

I believe this was meant to be sent to the list, not just me directly...

Quoted 98 lines · Ming Liu

Hi,

Please revert it, I probably made a mistake, I encountered this issue in morty branch, then I checked the qttools-5.7 source, and found there is code referring ICU, so I thought the issue is also impacting the upstream, which it seems is not according to Denys, sorry for the inconvenience I brought.

//Ming Liu

2017-06-23 23:46 GMT+02:00 Denys Dmytriyenko <[email protected]>:

Quoted 86 lines

Thanks.

Quoted 4 lines · Martin Jansa

Yes, I've seen both e-mails. I'm waiting for response from author, then I'll revert it in master and pyro branches.

On Fri, Jun 23, 2017 at 11:19 PM, Denys Dmytriyenko <[email protected]>

Quoted 4 lines · wrote:
Quoted 4 lines

Martin,

Were you able to look into this yet? I didn't copy you directly at

first,

Quoted 6 lines
Quoted 6 lines

so
not sure if you missed it...

Quoted 1 line · Denys Dmytriyenko

On Tue, Jun 20, 2017 at 06:28:32AM +0200, [email protected]

Quoted 4 lines · wrote:
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

From: Ming Liu <[email protected]>

This fixes a following QA issue:
| QA Issue: nativesdk-qtbase-tools rdepends on

nativesdk-libicui18n,

Quoted 2 lines
Quoted 2 lines

but it isn't a build dependency.

Quoted 1 line
Quoted 1 line

| QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicuuc,

but

Quoted 2 lines
Quoted 2 lines

it isn't a build dependency.

Quoted 1 line
Quoted 1 line

| QA Issue: nativesdk-qtbase-tools rdepends on

nativesdk-libicudata,

Quoted 4 lines
Quoted 4 lines

but it isn't a build dependency.

Quoted 3 lines

It seems there's inconsistency here between errors above referring to nativesdk-qtbase-tools and the change below made to qttools instead

of

Quoted 8 lines
Quoted 8 lines
Quoted 5 lines

qtbase!

I wonder if this fix was not included by the author:

https://github.com/meta-qt5/meta-qt5/commit/

ff073f04109900fc07bf81e2f1df63c626caf342

Quoted 2 lines

Just to double-check, I just built nativesdk-qttools using meta-qt5

w/o

Quoted 40 lines
Quoted 40 lines

this

Quoted 6 lines

patch and I don't see the above QA errors.

--
Denys

Quoted 6 lines

recipes-qt/qt5/

Quoted 6 lines
---
 recipes-qt/qt5/qttools_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt/qt5/ renamed from recipes-qt/qt5/qttools_git.bb +0 -0

qttools_git.bb

Quoted 25 lines
Quoted 15 lines

index 5c0f51c..1108390 100644

recipes-qt/qt5/qttools_git.bb +1 -2
@@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = " \
 
 inherit ptest
 
-DEPENDS += "qtbase qtdeclarative qtxmlpatterns"
+DEPENDS += "qtbase qtdeclarative qtxmlpatterns icu"
 
 SRC_URI += " \
     file://run-ptest \
--

2.7.4

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#7 lore raw

Hi,

Please revert it, I probably made a mistake, I encountered this issue in morty branch, then I checked the qttools-5.7 source, and found there is code referring ICU, so I thought the issue is also impacting the upstream, which it seems is not according to Denys, sorry for the inconvenience I brought.

2017-06-26 17:52 GMT+02:00 Denys Dmytriyenko <[email protected]>:

Quoted 111 lines

I believe this was meant to be sent to the list, not just me directly...

Quoted 5 lines · Ming Liu

Hi,

Please revert it, I probably made a mistake, I encountered this issue in morty branch, then I checked the qttools-5.7 source, and found there is code referring ICU, so I thought the issue is also impacting the

upstream,

Quoted 11 lines

which it seems is not according to Denys, sorry for the inconvenience I brought.

//Ming Liu

2017-06-23 23:46 GMT+02:00 Denys Dmytriyenko <[email protected]>:

Quoted 4 lines

Thanks.

Quoted 1 line · Martin Jansa

Yes, I've seen both e-mails. I'm waiting for response from author,

then

Quoted 16 lines
Quoted 16 lines
Quoted 3 lines

I'll revert it in master and pyro branches.

On Fri, Jun 23, 2017 at 11:19 PM, Denys Dmytriyenko <[email protected]

Quoted 4 lines · wrote:
Quoted 4 lines

Martin,

Were you able to look into this yet? I didn't copy you directly at

first,

Quoted 6 lines
Quoted 6 lines

so
not sure if you missed it...

Quoted 1 line · Denys Dmytriyenko

On Tue, Jun 20, 2017 at 06:28:32AM +0200, [email protected]

Quoted 8 lines
Quoted 8 lines
Quoted 4 lines · wrote:
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

From: Ming Liu <[email protected]>

This fixes a following QA issue:
| QA Issue: nativesdk-qtbase-tools rdepends on

nativesdk-libicui18n,

Quoted 2 lines
Quoted 2 lines

but it isn't a build dependency.

Quoted 1 line
Quoted 1 line

| QA Issue: nativesdk-qtbase-tools rdepends on

nativesdk-libicuuc,

Quoted 7 lines
Quoted 7 lines

but

Quoted 2 lines
Quoted 2 lines

it isn't a build dependency.

Quoted 1 line
Quoted 1 line

| QA Issue: nativesdk-qtbase-tools rdepends on

nativesdk-libicudata,

Quoted 3 lines
Quoted 3 lines

but it isn't a build dependency.

Quoted 2 lines

It seems there's inconsistency here between errors above

referring to

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

nativesdk-qtbase-tools and the change below made to qttools

instead

Quoted 9 lines
Quoted 9 lines

of

Quoted 8 lines
Quoted 8 lines
Quoted 5 lines

qtbase!

I wonder if this fix was not included by the author:

https://github.com/meta-qt5/meta-qt5/commit/

ff073f04109900fc07bf81e2f1df63c626caf342

Quoted 2 lines

Just to double-check, I just built nativesdk-qttools using

meta-qt5

Quoted 30 lines
Quoted 30 lines

w/o

Quoted 29 lines
Quoted 29 lines

this

Quoted 6 lines

patch and I don't see the above QA errors.

--
Denys

Quoted 6 lines

recipes-qt/qt5/

Quoted 6 lines
---
 recipes-qt/qt5/qttools_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt/qt5/ renamed from recipes-qt/qt5/qttools_git.bb +0 -0

qttools_git.bb

Quoted 15 lines
Quoted 15 lines

index 5c0f51c..1108390 100644

recipes-qt/qt5/qttools_git.bb +1 -2
@@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = " \
 
 inherit ptest
 
-DEPENDS += "qtbase qtdeclarative qtxmlpatterns"
+DEPENDS += "qtbase qtdeclarative qtxmlpatterns icu"
 
 SRC_URI += " \
     file://run-ptest \
--

2.7.4

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-

devel

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-

devel

Quoted 2 lines
Quoted 2 lines
Quoted 1 line
Quoted 1 line