systemd: work-around ppc gold linker error
PATCH 1/1 systemd: work-around ppc gold linker error
--- .../systemd/systemd/systemd-drop-gold-use-bfd.patch | 11 +++++++++++ meta/recipes-core/systemd/systemd_232.bb | 2 ++ 2 files changed, 13 insertions(+) create mode 100644 meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch
meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch new file +11 -0
@@ -0,0 +1,11 @@ +--- a/configure.ac ++++ b/configure.ac +@@ -260,7 +260,7 @@ + -Wl,-z,relro \ + -Wl,-z,now \ + -pie \ +- -Wl,-fuse-ld=gold]) ++ -Wl,-fuse-ld=bfd]) + AC_SUBST([OUR_LDFLAGS], "$with_ldflags $sanitizer_ldflags") + + AC_CHECK_SIZEOF(pid_t)
meta/recipes-core/systemd/systemd_232.bb +2 -0
@@ -41,6 +41,8 @@ SRC_URI_append_libc-uclibc = "\ " SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch" +SRC_URI_append_qemuppc = " file://systemd-drop-gold-use-bfd.patch" + PACKAGECONFIG ??= "xz \ ${@bb.utils.filter('DISTRO_FEATURES', 'efi pam selinux ldconfig', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \
Signature · 1 line
2.7.4
Quoted 14 lines · Randy MacLeod
Signed-off-by Randy MacLeod <[email protected]>--- .../systemd/systemd/systemd-drop-gold-use-bfd.patch | 11 +++++++++++ meta/recipes-core/systemd/systemd_232.bb | 2 ++ 2 files changed, 13 insertions(+) create mode 100644 meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patchmeta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch new file +1
-0@@ -0,0 +1,11 @@ +--- a/configure.ac
meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch line 11
Quoted 10 lines
meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch new file +10
-0++++ b/configure.ac +@@ -260,7 +260,7 @@ + -Wl,-z,relro \ + -Wl,-z,now \ + -pie \ +- -Wl,-fuse-ld=gold]) ++ -Wl,-fuse-ld=bfd]) + AC_SUBST([OUR_LDFLAGS], "$with_ldflags $sanitizer_ldflags") + + AC_CHECK_SIZEOF(pid_t)
may be a sed expression in do_configure_prepend is better
meta/recipes-core/systemd/systemd_232.bb SRC_URI_append_libc-uclibc = "\ · line 44
Quoted 9 lines
meta/recipes-core/systemd/systemd_232.bb +1
-0@@ -41,6 +41,8 @@ SRC_URI_append_libc-uclibc = "\ " SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch" +SRC_URI_append_qemuppc = " file://systemd-drop-gold-use-bfd.patch"
is it specific to qemu alone ? if its generic across ppc then this is not right override. Infact you should also describe what the problem is in detail here.
Quoted 12 lines
meta/recipes-core/systemd/systemd_232.bb +1
-1+ PACKAGECONFIG ??= "xz \ ${@bb.utils.filter('DISTRO_FEATURES', 'efi pam selinux ldconfig', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \ --2.7.4
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 20 lines · Khem Raj
Quoted 18 lines · Randy MacLeod
Signed-off-by Randy MacLeod <[email protected]>--- .../systemd/systemd/systemd-drop-gold-use-bfd.patch | 11 +++++++++++ meta/recipes-core/systemd/systemd_232.bb | 2 ++ 2 files changed, 13 insertions(+)create mode 100644
meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patchmeta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch new file +5
-0@@ -0,0 +1,11 @@ +--- a/configure.ac ++++ b/configure.ac +@@ -260,7 +260,7 @@ + -Wl,-z,relro \ + -Wl,-z,now \
Quoted 8 lines
meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch line 11
Quoted 6 lines
meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch new file +6
-0+ -pie \ +- -Wl,-fuse-ld=gold]) ++ -Wl,-fuse-ld=bfd]) + AC_SUBST([OUR_LDFLAGS], "$with_ldflags $sanitizer_ldflags") + + AC_CHECK_SIZEOF(pid_t)may be a sed expression in
do_configure_prependis better
Maybe?... hmmm.
I could do but this works and is intended to be reverted once the proper fix is merged so unless you or someone else insists and explains why it's better to do it in configure_prepend, I'll leave it as is.
Quoted 9 lines
Quoted 9 lines
meta/recipes-core/systemd/systemd_232.bb +0
-0@@ -41,6 +41,8 @@ SRC_URI_append_libc-uclibc = "\ " SRC_URI_append_qemuall = " file://0001-core-device.c-Change-the-default-device-timeout-to-2.patch"
Quoted 3 lines
meta/recipes-core/systemd/systemd_232.bb SRC_URI_append_libc-uclibc = "\ · line 44
Quoted 1 line
meta/recipes-core/systemd/systemd_232.bb +1
-0+SRC_URI_append_qemuppc = " file://systemd-drop-gold-use-bfd.patch"is it specific to qemu alone ?
Probably not. I'll figure out a better pattern for v2.
Quoted 3 lines
if its generic across ppc then this is not
right override. Infact you should also describe what the problem is in detail here.
Right. I'll do that in v2.
Meanwhile, some details are here for those interested:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=11696
Thanks for the review.
../Randy
Quoted 13 lines
Quoted 13 lines
meta/recipes-core/systemd/systemd_232.bb +1
-1+ PACKAGECONFIG ??= "xz \ ${@bb.utils.filter('DISTRO_FEATURES', 'efi pam selinux ldconfig', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \ --2.7.4
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 2 lines
# Randy MacLeod. SMTS, Linux, Wind River Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, K2K 2W5
✗ patchtest: failure for systemd: work-around ppc gold linker error
In reply to Randy MacLeod== Series Details ==
Series: systemd: work-around ppc gold linker error
Revision: 1
URL : https://patchwork.openembedded.org/series/7390/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:
* Issue Added patch file is missing Upstream-Status in the header [test_upstream_status_presence]
Suggested fix Add Upstream-Status: <status> to the header of meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch (possible values: Pending, Submitted, Accepted, Backport, Denied, Inappropriate)
* Issue A patch file has been added, but does not have a Signed-off-by tag [test_signed_off_by_presence]
Suggested fix Sign off the added patch file (meta/recipes-core/systemd/systemd/systemd-drop-gold-use-bfd.patch)
If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).
---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe