drm/amdgpu: fix solid screen and hard hang when 2k + 4k display connected with DP
Subsystems (2)
PATCH v2 1/1 drm/amdgpu: fix solid screen and hard hang when 2k + 4k display connected with DP
---
V1 -> V2:
- Add READ_ONCE to avoid complier might cause to read as previous fence value.
I will refine fence checking with fence interface at amdgpu_fence.c after S3 stress issue completed as Christian's suggestion.
Thanks,
Ray
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +1 -1
@@ -130,7 +130,7 @@ psp_cmd_submit_buf(struct psp_context *psp, ret =psp_cmd_submit (psp, ucode, cmd_buf_mc_addr, fence_mc_addr, index); -while (*((unsigned int *)psp->fence_buf) != index) { +while (READ_ONCE (*((unsigned int *)psp->fence_buf)) < index) {msleep (1 ); }
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1498479491-31585-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org
Christian König
Acked-byAm 26.06.2017 um 14:18 schrieb Huang Rui:
Quoted 1 line
Signed-off-by Huang Rui <[email protected]>
Quoted 20 lines
---
V1 -> V2:
- AddREAD_ONCEto avoid complier might cause to read as previous fence value.I will refine fence checking with fence interface at
amdgpu_fence.cafter S3 stress issue completed as Christian's suggestion.Thanks,
Ray--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c psp_cmd_submit_buf(struct psp_context *psp, · line 136
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +1
-1@@ -130,7 +130,7 @@ psp_cmd_submit_buf(struct psp_context *psp, ret =psp_cmd_submit (psp, ucode, cmd_buf_mc_addr, fence_mc_addr, index); -while (*((unsigned int *)psp->fence_buf) != index) { +while (READ_ONCE (*((unsigned int *)psp->fence_buf)) < index) {msleep (1 ); }
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Deucher, Alexander
Acked-by Alex DeucherQuoted 9 lines
-----Original Message-----
From: Huang Rui [mailto:[email protected]]
Sent: Monday, June 26, 2017 8:18 AM
To: [email protected]; Deucher, Alexander; Koenig, Christian
Cc: Wang, Ken; Qiao, Joe(Markham); Jiang, Sonny; Huan, Alvin; Huang, Ray
Subject: [PATCH v2] drm/amdgpu: fix solid screen and hard hang when 2k + 4k display connected with DPSigned-off-by Huang Rui <[email protected]>
Quoted 31 lines
---
V1 -> V2:
- AddREAD_ONCEto avoid complier might cause to read as previous fence value.I will refine fence checking with fence interface at
amdgpu_fence.cafter S3 stress issue completed as Christian's suggestion.Thanks,
Ray--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +1
-2@@ -130,7 +130,7 @@ psp_cmd_submit_buf(struct psp_context *psp, ret =psp_cmd_submit (psp, ucode, cmd_buf_mc_addr, fence_mc_addr, index); -while (*((unsigned int *)psp->fence_buf) != index) { +while (READ_ONCE (*((unsigned int *)psp->fence_buf)) < index) {msleep (1 ); } --
Quoted 1 line
2.7.4
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx