Staging: wlan-ng: hfa384x.h:Fix use of volatile is usually wrong
PATCH 6/6 Staging: wlan-ng: hfa384x.h:Fix use of volatile is usually wrong
Fix checkpatch.pl issue
WARNING: Use of volatile is usually wrong:
see Documentation/process/volatile-considered-harmful.rst
Signed-off-by Jaya Durga <[email protected]>
--- drivers/staging/wlan-ng/hfa384x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wlan-ng/hfa384x.h +1 -1
@@ -1175,7 +1175,7 @@ struct hfa384x_usbctlx {enum ctlx_state state;/* Tracks running state */ struct completion done; -volatile int reapable;/* Food for the reaper task */ +int reapable;/* Food for the reaper task */ ctlx_cmdcb_t cmdcb;/* Async command callback */ ctlx_usercb_t usercb;/* Async user callback, */
Signature · 1 line
1.9.1
Quoted 3 lines · Jaya Durga
Fix checkpatch.pl issue
WARNING: Use of volatile is usually wrong:
seeDocumentation/process/volatile-considered-harmful.rst
Now I've only had a very quick look at the code using this. Could you elaborate on why just removing the volatile keyword is enough, and that this isn't related to some smelly bit of code that should be implemented differently?
Quoted 19 lines
Signed-off-by Jaya Durga <[email protected]>--- drivers/staging/wlan-ng/hfa384x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/wlan-ng/hfa384x.h +1
-2@@ -1175,7 +1175,7 @@ struct hfa384x_usbctlx {enum ctlx_state state;/* Tracks running state */ struct completion done; -volatile int reapable;/* Food for the reaper task */ +int reapable;/* Food for the reaper task */ ctlx_cmdcb_t cmdcb;/* Async command callback */ ctlx_usercb_t usercb;/* Async user callback, */ --
Quoted 1 line
1.9.1
Frans