Patch "dt: bindings: net: use boolean dt properties for eee broken modes" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
dt: bindings: net: use boolean dt properties for eee broken modes
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
dt-bindings-net-use-boolean-dt-properties-for-eee-broken-modes.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Mon Jul 3 11:00:33 CEST 2017
From: jbrunet <[email protected]>
Date: Mon, 19 Dec 2016 16:05:38 +0100
Subject: dt: bindings: net: use boolean dt properties for eee broken modes
From: jbrunet <[email protected]>
[ Upstream commit 308d3165d8b2b98d3dc3d97d6662062735daea67 ]
The patches regarding eee-broken-modes was merged before all people involved could find an agreement on the best way to move forward.
While we agreed on having a DT property to mark particular modes as broken, the value used for eee-broken-modes mapped the phy register in very direct way. Because of this, the concern is that it could be used to implement configuration policies instead of describing a broken HW.
In the end, having a boolean property for each mode seems to be preferred over one bit field value mapping the register (too) directly.
--- Documentation/devicetree/bindings/net/phy.txt | 9 +++++++++ include/dt-bindings/net/mdio.h | 19 ------------------- 2 files changed, 9 insertions(+), 19 deletions(-) delete mode 100644 include/dt-bindings/net/mdio.h
Documentation/devicetree/bindings/net/phy.txt +9 -0
@@ -35,6 +35,15 @@ Optional Properties: - broken-turn-around: If set, indicates the PHY device does not correctly release the turn around line low at the end of a MDIO transaction. +- eee-broken-100tx: +- eee-broken-1000t: +- eee-broken-10gt: +- eee-broken-1000kx: +- eee-broken-10gkx4: +- eee-broken-10gkr: + Mark the corresponding energy efficient ethernet mode as broken and + request the ethernet to stop advertising it. + Example: ethernet-phy@0 {
include/dt-bindings/net/mdio.h deleted +0 -19
@@ -1,19 +0,0 @@ -/* -* This header provides generic constants for ethernet MDIO bindings -*/ - -#ifndef _DT_BINDINGS_NET_MDIO_H -#define _DT_BINDINGS_NET_MDIO_H - -/* -* EEE capability Advertisement -*/ - -#define MDIO_EEE_100TX 0x0002/* 100TX EEE cap */ -#define MDIO_EEE_1000T 0x0004/* 1000T EEE cap */ -#define MDIO_EEE_10GT 0x0008/* 10GT EEE cap */ -#define MDIO_EEE_1000KX 0x0010/* 1000KX EEE cap */ -#define MDIO_EEE_10GKX4 0x0020/* 10G KX4 EEE cap */ -#define MDIO_EEE_10GKR 0x0040/* 10G KR EEE cap */ - -#endif
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/net-phy-add-an-option-to-disable-eee-advertisement.patch queue-4.9/dt-bindings-net-add-eee-capability-constants.patch queue-4.9/net-phy-use-boolean-dt-properties-for-eee-broken-modes.patch queue-4.9/arm64-dts-meson-gxbb-odroidc2-fix-gbe-tx-link-breakage.patch queue-4.9/net-phy-fix-sign-type-error-in-genphy_config_eee_advert.patch queue-4.9/dt-bindings-net-use-boolean-dt-properties-for-eee-broken-modes.patch