Skip to contentSkip to conversation

Patch "net: bgmac: Remove superflous netif_carrier_on()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jul 3, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net: bgmac: Remove superflous netif_carrier_on()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-bgmac-remove-superflous-netif_carrier_on.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 3894396e64994f31c3ef5c7e6f63dded0593e567 Mon Sep 17 00:00:00 2001

From: Florian Fainelli <[email protected]>
Date: Thu, 23 Jun 2016 14:25:33 -0700
Subject: net: bgmac: Remove superflous netif_carrier_on()

From: Florian Fainelli <[email protected]>

commit 3894396e64994f31c3ef5c7e6f63dded0593e567 upstream.

bgmac_open() calls phy_start() to initialize the PHY state machine, which will set the interface's carrier state accordingly, no need to force that as this could be conflicting with the PHY state determined by PHYLIB.

Fixes dd4544f05469 ("bgmac: driver for GBit MAC core on BCMA bus")
---
 drivers/net/ethernet/broadcom/bgmac.c |    2 --
 1 file changed, 2 deletions(-)
drivers/net/ethernet/broadcom/bgmac.c +0 -2
@@ -1308,8 +1308,6 @@ static int bgmac_open(struct net_device
 
 	phy_start(bgmac->phy_dev);
 
-	netif_carrier_on(net_dev);
-
 	netif_start_queue(net_dev);
 
 	return 0;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/net-korina-fix-napi-versus-resources-freeing.patch queue-4.4/arm-dts-bcm5301x-correct-gic_ppi-interrupt-flags.patch queue-4.4/net-bgmac-start-transmit-queue-in-bgmac_open.patch queue-4.4/net-bgmac-fix-sof-bit-checking.patch queue-4.4/net-bgmac-remove-superflous-netif_carrier_on.patch