Skip to contentSkip to conversation

Patch "net: ethtool: Initialize buffer when querying device channel settings" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jul 3, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net: ethtool: Initialize buffer when querying device channel settings

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-ethtool-initialize-buffer-when-querying-device-channel-settings.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Jul 3 11:54:13 CEST 2017

From: Eran Ben Elisha <[email protected]>
Date: Tue, 17 Jan 2017 19:19:17 +0200
Subject: net: ethtool: Initialize buffer when querying device channel settings

From: Eran Ben Elisha <[email protected]>

[ Upstream commit 31a86d137219373c3222ca5f4f912e9a4d8065bb ]

Ethtool channels respond struct was uninitialized when querying device channel boundaries settings. As a result, unreported fields by the driver hold garbage. This may cause sending unsupported params to driver.

Fixes 8bf368620486 ('ethtool: ensure channel counts are within bounds ...')
CC John W. Linville <[email protected]>
---
 net/core/ethtool.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/ethtool.c +1 -1
@@ -1704,7 +1704,7 @@ static noinline_for_stack int ethtool_ge
 static noinline_for_stack int ethtool_set_channels(struct net_device *dev,
 						   void __user *useraddr)
 {
-	struct ethtool_channels channels, max;
+	struct ethtool_channels channels, max = { .cmd = ETHTOOL_GCHANNELS };
 	u32 max_rx_in_use = 0;
 
 	if (!dev->ethtool_ops->set_channels || !dev->ethtool_ops->get_channels)

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/net-ethtool-initialize-buffer-when-querying-device-channel-settings.patch