Skip to contentSkip to conversation

Patch "iommu/amd: Fix incorrect error handling in amd_iommu_bind_pasid()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jul 3, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iommu/amd: Fix incorrect error handling in amd_iommu_bind_pasid()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iommu-amd-fix-incorrect-error-handling-in-amd_iommu_bind_pasid.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 73dbd4a4230216b6a5540a362edceae0c9b4876b Mon Sep 17 00:00:00 2001

From: Pan Bian <[email protected]>
Date: Sun, 23 Apr 2017 18:23:21 +0800
Subject: iommu/amd: Fix incorrect error handling in amd_iommu_bind_pasid()

From: Pan Bian <[email protected]>

commit 73dbd4a4230216b6a5540a362edceae0c9b4876b upstream.

In function amd_iommu_bind_pasid(), the control flow jumps to label out_free when pasid_state->mm and mm is NULL. And mmput(mm) is called. In function mmput(mm), mm is referenced without validation. This will result in a NULL dereference bug. This patch fixes the bug.

Fixes f0aac63b873b ('iommu/amd: Don't hold a reference to mm_struct')
---
 drivers/iommu/amd_iommu_v2.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/amd_iommu_v2.c +1 -1
@@ -699,9 +699,9 @@ out_clear_state:
 
 out_unregister:
 	mmu_notifier_unregister(&pasid_state->mn, mm);
+	mmput(mm);
 
 out_free:
-	mmput(mm);
 	free_pasid_state(pasid_state);
 
 out:

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/iommu-amd-fix-incorrect-error-handling-in-amd_iommu_bind_pasid.patch