Skip to contentSkip to conversation

Patch "cpufreq: s3c2416: double free on driver init error path" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jul 3, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

cpufreq: s3c2416: double free on driver init error path

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
cpufreq-s3c2416-double-free-on-driver-init-error-path.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From a69261e4470d680185a15f748d9cdafb37c57a33 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Tue, 7 Feb 2017 16:19:06 +0300
Subject: cpufreq: s3c2416: double free on driver init error path

From: Dan Carpenter <[email protected]>

commit a69261e4470d680185a15f748d9cdafb37c57a33 upstream.

The "goto err_armclk;" error path already does a clk_put(s3c_freq->hclk); so this is a double free.

Fixes 34ee55075265 ([CPUFREQ] Add S3C2416/S3C2450 cpufreq driver)
---
 drivers/cpufreq/s3c2416-cpufreq.c |    1 -
 1 file changed, 1 deletion(-)
drivers/cpufreq/s3c2416-cpufreq.c +0 -1
@@ -400,7 +400,6 @@ static int s3c2416_cpufreq_driver_init(s
 	rate = clk_get_rate(s3c_freq->hclk);
 	if (rate < 133 * 1000 * 1000) {
 		pr_err("cpufreq: HCLK not at 133MHz\n");
-		clk_put(s3c_freq->hclk);
 		ret = -EINVAL;
 		goto err_armclk;
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/xfrm-oops-on-error-in-pfkey_msg2xfrm_state.patch queue-4.9/kvm-x86-vpmu-fix-undefined-shift-in-intel_pmu_refresh.patch queue-4.9/kvm-x86-zero-base3-of-unusable-segments.patch queue-4.9/xfrm-null-dereference-on-allocation-failure.patch queue-4.9/cpufreq-s3c2416-double-free-on-driver-init-error-path.patch