Skip to contentSkip to conversation

writeback error handling fixes (pile #1)

DISCUSSION Jeff Layton 1 participant 2 messages Jul 6, 2017 VFS

lore
Share & tools
lore
#0 lore raw

The following changes since commit c86daad2c25bfd4a33d48b7691afaa96d9c5ab46:

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input (2017-05-26 16:45:13 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git tags/for-linus-v4.13-1

for you to fetch changes up to 0f41074a65757b46acbdd4293f0de8a70b147406:

fs: remove call_fsync helper function (2017-07-05 18:44:23 -0400)

----------------------------------------------------------------
The main rationale for all of these changes is to tighten up writeback error reporting to userland. There are many ways now that writeback errors can be lost, such that fsync/fdatasync/msync return 0 when writeback actually failed.

This pile contains a small set of cleanups and writeback error handling fixes that I was able to break off from the main pile (#2).

Two of the patches in this pile are trivial. The exceptions are the patch to fix up error handling in write_one_page, and the patch to make JFS pay attention to write_one_page errors.

Side note: I'm not going to send a PR for the remaining locking patches. Al picked up most of the file locking / fcntl patches from my series in one of his PRs, so all that's left is the l_pid rework from Ben. I think it's reasonable to give those a full cycle to soak in -next as they came in rather late in this cycle anyway.
----------------------------------------------------------------
Dave Kleikamp (1):
JFS: do not ignore return code from write_one_page()

Jeff Layton (3):
mm: drop "wait" parameter from write_one_page()
mm: clean up error handling in write_one_page
fs: remove call_fsync helper function

 fs/exofs/dir.c        |  2 +-
 fs/ext2/dir.c         |  2 +-
 fs/jfs/jfs_metapage.c |  7 +++++--
 fs/jfs/jfs_metapage.h |  1 +
 fs/minix/dir.c        |  2 +-
 fs/sync.c             |  2 +-
 fs/sysv/dir.c         |  2 +-
 fs/ufs/dir.c          |  2 +-
 include/linux/fs.h    |  6 ------
 include/linux/mm.h    |  2 +-
 ipc/shm.c             |  2 +-
 mm/page-writeback.c   | 19 +++++++++----------
 12 files changed, 23 insertions(+), 26 deletions(-)
Signature · 1 line
Jeff Layton <[email protected]>
#1 lore raw
Quoted 39 lines · Jeff Layton

The following changes since commit c86daad2c25bfd4a33d48b7691afaa96d9c5ab46:

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input (2017-05-26 16:45:13 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git tags/for-linus-v4.13-1

for you to fetch changes up to 0f41074a65757b46acbdd4293f0de8a70b147406:

fs: remove call_fsync helper function (2017-07-05 18:44:23 -0400)

----------------------------------------------------------------
The main rationale for all of these changes is to tighten up writeback error reporting to userland. There are many ways now that writeback errors can be lost, such that fsync/fdatasync/msync return 0 when writeback actually failed.

This pile contains a small set of cleanups and writeback error handling fixes that I was able to break off from the main pile (#2).

Two of the patches in this pile are trivial. The exceptions are the patch to fix up error handling in write_one_page, and the patch to make JFS pay attention to write_one_page errors.

Side note: I'm not going to send a PR for the remaining locking patches. Al picked up most of the file locking / fcntl patches from my series in one of his PRs, so all that's left is the l_pid rework from Ben. I think it's reasonable to give those a full cycle to soak in -next as they came in rather late in this cycle anyway.
----------------------------------------------------------------
Dave Kleikamp (1):
JFS: do not ignore return code from write_one_page()

Jeff Layton (3):
mm: drop "wait" parameter from write_one_page()
mm: clean up error handling in write_one_page
fs: remove call_fsync helper function

Quoted 13 lines
 fs/exofs/dir.c        |  2 +-
 fs/ext2/dir.c         |  2 +-
 fs/jfs/jfs_metapage.c |  7 +++++--
 fs/jfs/jfs_metapage.h |  1 +
 fs/minix/dir.c        |  2 +-
 fs/sync.c             |  2 +-
 fs/sysv/dir.c         |  2 +-
 fs/ufs/dir.c          |  2 +-
 include/linux/fs.h    |  6 ------
 include/linux/mm.h    |  2 +-
 ipc/shm.c             |  2 +-
 mm/page-writeback.c   | 19 +++++++++----------
 12 files changed, 23 insertions(+), 26 deletions(-)

Obviously, this should have had [GIT PULL] in the subject...

Signature · 1 line
Jeff Layton <[email protected]>