Patch "sysctl: don't print negative flag for proc_douintvec" has been added to the 4.4-stable tree

This is a note to let you know that I've just added the patch titled

sysctl: don't print negative flag for proc_douintvec

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
sysctl-don-t-print-negative-flag-for-proc_douintvec.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From: Liping Zhang <[email protected]>
Date: Fri, 7 Apr 2017 23:51:06 +0800
Subject: sysctl: don't print negative flag for proc_douintvec

From: Liping Zhang <[email protected]>

commit 5380e5644afbba9e3d229c36771134976f05c91e upstream.

I saw some very confusing sysctl output on my system:

  # cat /proc/sys/net/core/xfrm_aevent_rseqth
  -2
  # cat /proc/sys/net/core/xfrm_aevent_etime
  -10
  # cat /proc/sys/net/ipv4/tcp_notsent_lowat
  -4294967295

Because we forget to set the *negp flag in proc_douintvec, so it will become a garbage value.

Since the value related to proc_douintvec is always an unsigned integer, so we can set *negp to false explictily to fix this issue.

---
 kernel/sysctl.c |    1 +
 1 file changed, 1 insertion(+)

@@ -2070,6 +2070,7 @@ static int do_proc_douintvec_conv(bool *
 		*valp = *lvalp;
 	} else {
 		unsigned int val = *valp;
+		*negp = false;
 		*lvalp = (unsigned long)val;
 	}
 	return 0;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/sysctl-don-t-print-negative-flag-for-proc_douintvec.patch queue-4.4/sysctl-report-einval-if-value-is-larger-than-uint_max-for-proc_douintvec.patch