Skip to contentSkip to conversation

Patch "sysctl: report EINVAL if value is larger than UINT_MAX for proc_douintvec" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jul 7, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

sysctl: report EINVAL if value is larger than UINT_MAX for proc_douintvec

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
sysctl-report-einval-if-value-is-larger-than-uint_max-for-proc_douintvec.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 425fffd886bae3d127a08fa6a17f2e31e24ed7ff Mon Sep 17 00:00:00 2001

From: Liping Zhang <[email protected]>
Date: Fri, 7 Apr 2017 23:51:07 +0800
Subject: sysctl: report EINVAL if value is larger than UINT_MAX for proc_douintvec

From: Liping Zhang <[email protected]>

commit 425fffd886bae3d127a08fa6a17f2e31e24ed7ff upstream.

Currently, inputting the following command will succeed but actually the value will be truncated:

  # echo 0x12ffffffff > /proc/sys/net/ipv4/tcp_notsent_lowat

This is not friendly to the user, so instead, we should report error when the value is larger than UINT_MAX.

Fixes e7d316a02f68 ("sysctl: handle error writing UINT_MAX to u32 fields")
Cc Subash Abhinov Kasiviswanathan <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Eric W. Biederman <[email protected]>
---
 kernel/sysctl.c |    2 ++
 1 file changed, 2 insertions(+)
kernel/sysctl.c +2 -0
@@ -2067,6 +2067,8 @@ static int do_proc_douintvec_conv(bool *
 	if (write) {
 		if (*negp)
 			return -EINVAL;
+		if (*lvalp > UINT_MAX)
+			return -EINVAL;
 		*valp = *lvalp;
 	} else {
 		unsigned int val = *valp;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/sysctl-don-t-print-negative-flag-for-proc_douintvec.patch queue-4.4/sysctl-report-einval-if-value-is-larger-than-uint_max-for-proc_douintvec.patch