Skip to contentSkip to conversation

printk: Modify operators of printed_len and text_len

PATCH In review Pierre Kuo 2 participants 2 messages Jul 11, 2017 Printk

lore
Share & tools
lore

Pierre Kuo

author
#0 lore raw

PATCH v2 1/1 printk: Modify operators of printed_len and text_len

With commit <ddb9baa82226> ("printk: report lost messages in printk safe/nmi contexts") and commit <8b1742c9c207> ("printk: remove zap_locks() function"), it seems we can remove initialization, "=0", of text_len and directly assign result of log_output to printed_len.

---
Changes since v2:
* Per Petr's friendly reminder, add description of <ddb9baa82226> ("printk: report lost messages in printk
safe/nmi contexts") and remove "=0", the initialization, of text_len.

 kernel/printk/printk.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/printk/printk.c +3 -3
index fc47863..229fbdcb 100644
@@ -1698,10 +1698,10 @@ asmlinkage int vprintk_emit(int facility, int level,
 {
 	static char textbuf[LOG_LINE_MAX];
 	char *text = textbuf;
-	size_t text_len = 0;
+	size_t text_len;
 	enum log_flags lflags = 0;
 	unsigned long flags;
-	int printed_len = 0;
+	int printed_len;
 	bool in_sched = false;
 
 	if (level == LOGLEVEL_SCHED) {
@@ -1754,7 +1754,7 @@ asmlinkage int vprintk_emit(int facility, int level,
 	if (dict)
 		lflags |= LOG_PREFIX|LOG_NEWLINE;
 
-	printed_len += log_output(facility, level, lflags, dict, dictlen, text, text_len);
+	printed_len = log_output(facility, level, lflags, dict, dictlen, text, text_len);
 
 	logbuf_unlock_irqrestore(flags);
 
Signature · 1 line
1.7.9.5
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 4 lines · Pierre Kuo

With commit <ddb9baa82226> ("printk: report lost messages in printk safe/nmi contexts") and commit <8b1742c9c207> ("printk: remove zap_locks() function"), it seems we can remove initialization, "=0", of text_len and directly assign result of log_output to printed_len.

Just one small thing. The <> brackets should not be there around the sha1 commit id. Otherwise, the patch looks fine to me.

You do not need to resend the patch. I'll remove the brackets when applying the patch. I'll wait few more days just in case anyone has more comments on this patch.

Best Regards,
Petr