Skip to contentSkip to conversation

drm/amdgpu: implement si_read_bios_from_rom

PATCH In review Alex Deucher 2 participants 2 messages Jul 12, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: implement si_read_bios_from_rom

This allows us to read the vbios image directly from ROM. This is already implemented for other asics, but was not yet available for SI.

---
 drivers/gpu/drm/amd/amdgpu/si.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
drivers/gpu/drm/amd/amdgpu/si.c +28 -0
index dca956d..3f3e367 100644
@@ -1150,6 +1150,33 @@ static bool si_read_disabled_bios(struct amdgpu_device *adev)
 	return r;
 }
 
+#define mmROM_INDEX 0x2A
+#define mmROM_DATA  0x2B
+
+static bool si_read_bios_from_rom(struct amdgpu_device *adev,
+				  u8 *bios, u32 length_bytes)
+{
+	u32 *dw_ptr;
+	u32 i, length_dw;
+
+	if (bios == NULL)
+		return false;
+	if (length_bytes == 0)
+		return false;
+	/* APU vbios image is part of sbios image */
+	if (adev->flags & AMD_IS_APU)
+		return false;
+
+	dw_ptr = (u32 *)bios;
+	length_dw = ALIGN(length_bytes, 4) / 4;
+	/* set rom index to 0 */
+	WREG32(mmROM_INDEX, 0);
+	for (i = 0; i < length_dw; i++)
+		dw_ptr[i] = RREG32(mmROM_DATA);
+
+	return true;
+}
+
 //xxx: not implemented
 static int si_asic_reset(struct amdgpu_device *adev)
 {
@@ -1218,6 +1245,7 @@ static void si_invalidate_hdp(struct amdgpu_device *adev)
 static const struct amdgpu_asic_funcs si_asic_funcs =
 {
 	.read_disabled_bios = &si_read_disabled_bios,
+	.read_bios_from_rom = &si_read_bios_from_rom,
 	.read_register = &si_read_register,
 	.reset = &si_asic_reset,
 	.set_vga_state = &si_vga_set_state,
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1499865585-20782-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Am 12.07.2017 um 15:19 schrieb Alex Deucher:

Quoted 5 lines

This allows us to read the vbios image directly from ROM. This is already implemented for other asics, but was not yet available for SI.

Quoted 43 lines
---
  drivers/gpu/drm/amd/amdgpu/si.c | 28 ++++++++++++++++++++++++++++
  1 file changed, 28 insertions(+)
drivers/gpu/drm/amd/amdgpu/si.c +27 -0
index dca956d..3f3e367 100644
@@ -1150,6 +1150,33 @@ static bool si_read_disabled_bios(struct amdgpu_device *adev)
  	return r;
  }
 
+#define mmROM_INDEX 0x2A
+#define mmROM_DATA  0x2B
+
+static bool si_read_bios_from_rom(struct amdgpu_device *adev,
+				  u8 *bios, u32 length_bytes)
+{
+	u32 *dw_ptr;
+	u32 i, length_dw;
+
+	if (bios == NULL)
+		return false;
+	if (length_bytes == 0)
+		return false;
+	/* APU vbios image is part of sbios image */
+	if (adev->flags & AMD_IS_APU)
+		return false;
+
+	dw_ptr = (u32 *)bios;
+	length_dw = ALIGN(length_bytes, 4) / 4;
+	/* set rom index to 0 */
+	WREG32(mmROM_INDEX, 0);
+	for (i = 0; i < length_dw; i++)
+		dw_ptr[i] = RREG32(mmROM_DATA);
+
+	return true;
+}
+
  //xxx: not implemented
  static int si_asic_reset(struct amdgpu_device *adev)
  {

drivers/gpu/drm/amd/amdgpu/si.c static void si_invalidate_hdp(struct amdgpu_device *adev) · line 1251

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/si.c +1 -0
@@ -1218,6 +1245,7 @@ static void si_invalidate_hdp(struct amdgpu_device *adev)
  static const struct amdgpu_asic_funcs si_asic_funcs =
  {
  	.read_disabled_bios = &si_read_disabled_bios,
+	.read_bios_from_rom = &si_read_bios_from_rom,
  	.read_register = &si_read_register,
  	.reset = &si_asic_reset,
  	.set_vga_state = &si_vga_set_state,

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx