Skip to contentSkip to conversation

Patch "tools string: Use __fallthrough in perf_atoll()" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jul 13, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

tools string: Use __fallthrough in perf_atoll()

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
tools-string-use-__fallthrough-in-perf_atoll.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 94bdd5edb34e472980d1e18b4600d6fb92bd6b0a Mon Sep 17 00:00:00 2001

From: Arnaldo Carvalho de Melo <[email protected]>
Date: Wed, 8 Feb 2017 17:01:46 -0300
Subject: tools string: Use __fallthrough in perf_atoll()

From: Arnaldo Carvalho de Melo <[email protected]>

commit 94bdd5edb34e472980d1e18b4600d6fb92bd6b0a upstream.

The implicit fall through case label here is intended, so let us inform that to gcc >= 7:

CC /tmp/build/perf/util/string.o
util/string.c: In function 'perf_atoll':
util/string.c:22:7: error: this statement may fall through [-Werror=implicit-fallthrough=]

      if (*p)
         ^
  util/string.c:24:3: note: here
     case '\0':
     ^~~~
---
 tools/perf/util/string.c |    2 ++
 1 file changed, 2 insertions(+)
tools/perf/util/string.c +2 -0
@@ -21,6 +21,8 @@ s64 perf_atoll(const char *str)
 		case 'b': case 'B':
 			if (*p)
 				goto out_err;
+
+			__fallthrough;
 		case '\0':
 			return length;
 		default:

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/perf-thread_map-correctly-size-buffer-used-with-dirent-dt_name.patch queue-4.9/perf-tests-avoid-possible-truncation-with-dirent-d_name-snprintf.patch queue-4.9/perf-top-use-__fallthrough.patch queue-4.9/perf-scripting-perl-fix-compile-error-with-some-perl5-versions.patch queue-4.9/perf-bench-numa-avoid-possible-truncation-when-using-snprintf.patch queue-4.9/perf-probe-add-error-checks-to-offline-probe-post-processing.patch queue-4.9/perf-header-fix-handling-of-perf_event_update__scale.patch queue-4.9/tools-string-use-__fallthrough-in-perf_atoll.patch queue-4.9/perf-intel-pt-use-__fallthrough.patch queue-4.9/tools-include-add-a-__fallthrough-statement.patch queue-4.9/tools-strfilter-use-__fallthrough.patch queue-4.9/perf-probe-fix-to-probe-on-gcc-generated-symbols-for-offline-kernel.patch