Skip to contentSkip to conversation

Patch "crypto: rsa-pkcs1pad - use constant time memory comparison for MACs" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jul 13, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

crypto: rsa-pkcs1pad - use constant time memory comparison for MACs

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
crypto-rsa-pkcs1pad-use-constant-time-memory-comparison-for-macs.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From fec17cb2231733174e039ad9054fa16bb358e2ec Mon Sep 17 00:00:00 2001

From: "Jason A. Donenfeld" <[email protected]>
Date: Sun, 11 Jun 2017 23:20:23 +0200
Subject: crypto: rsa-pkcs1pad - use constant time memory comparison for MACs
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Jason A. Donenfeld <[email protected]>

commit fec17cb2231733174e039ad9054fa16bb358e2ec upstream.

Otherwise, we enable all sorts of forgeries via timing attack.

---
 crypto/rsa-pkcs1pad.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
crypto/rsa-pkcs1pad.c +1 -1
@@ -496,7 +496,7 @@ static int pkcs1pad_verify_complete(stru
 		goto done;
 	pos++;
 
-	if (memcmp(out_buf + pos, digest_info->data, digest_info->size))
+	if (crypto_memneq(out_buf + pos, digest_info->data, digest_info->size))
 		goto done;
 
 	pos += digest_info->size;

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/crypto-rsa-pkcs1pad-use-constant-time-memory-comparison-for-macs.patch