Skip to contentSkip to conversation

Patch "ext4: check return value of kstrtoull correctly in reserved_clusters_store" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jul 13, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ext4: check return value of kstrtoull correctly in reserved_clusters_store

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ext4-check-return-value-of-kstrtoull-correctly-in-reserved_clusters_store.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 1ea1516fbbab2b30bf98c534ecaacba579a35208 Mon Sep 17 00:00:00 2001

From: Chao Yu <[email protected]>
Date: Fri, 23 Jun 2017 01:08:22 -0400
Subject: ext4: check return value of kstrtoull correctly in reserved_clusters_store

From: Chao Yu <[email protected]>

commit 1ea1516fbbab2b30bf98c534ecaacba579a35208 upstream.

kstrtoull returns 0 on success, however, in reserved_clusters_store we will return -EINVAL if kstrtoull returns 0, it makes us fail to update reserved_clusters value through sysfs.

Fixes 76d33bca5581b1dd5c3157fa168db849a784ada4
---
 fs/ext4/sysfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ext4/sysfs.c +1 -1
@@ -100,7 +100,7 @@ static ssize_t reserved_clusters_store(s
 	int ret;
 
 	ret = kstrtoull(skip_spaces(buf), 0, &val);
-	if (!ret || val >= clusters)
+	if (ret || val >= clusters)
 		return -EINVAL;
 
 	atomic64_set(&sbi->s_resv_clusters, val);

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/ext4-check-return-value-of-kstrtoull-correctly-in-reserved_clusters_store.patch