Skip to contentSkip to conversation

Fix value set for uname of phantom tap devices

RFC PATCH New Masaki Kanno 1 participant 1 message Feb 18, 2010

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 Fix value set for uname of phantom tap devices

Hi,

cfg_xenapi['image'] is always set to dev_info['uname'] even if cfg_xenapi['image'] does not include 'tap:'.
I'm not sure about phantom tap devices. However, I think that the following patch is correct. How do you think?

tools/python/xen/xend/XendConfig.py +2 -1
diff -r b4041e7bbe1b tools/python/xen/xend/XendConfig.py
@@ -1686,8 +1686,9 @@
                 elif dev_type == 'tap':
                     if cfg_xenapi.get('image').find('tap:') == -1:
                         dev_info['uname'] = 'tap:qcow:%s' % cfg_xenapi.get('image')
+                    else:
+                        dev_info['uname'] = cfg_xenapi.get('image')
                     dev_info['dev'] =  '/dev/%s' % cfg_xenapi.get('device')
-                    dev_info['uname'] = cfg_xenapi.get('image')
                 dev_info['mode'] = cfg_xenapi.get('mode')
                 dev_info['backend'] = '0'
                 dev_uuid = cfg_xenapi.get('uuid', uuid.createString())

Best regards,
Kan

tools/python/xen/xend/XendConfig.py +2 -1
diff -r b4041e7bbe1b tools/python/xen/xend/XendConfig.py
@@ -1686,8 +1686,9 @@
                 elif dev_type == 'tap':
                     if cfg_xenapi.get('image').find('tap:') == -1:
                         dev_info['uname'] = 'tap:qcow:%s' % cfg_xenapi.get('image')
+                    else:
+                        dev_info['uname'] = cfg_xenapi.get('image')
                     dev_info['dev'] =  '/dev/%s' % cfg_xenapi.get('device')
-                    dev_info['uname'] = cfg_xenapi.get('image')
                 dev_info['mode'] = cfg_xenapi.get('mode')
                 dev_info['backend'] = '0'
                 dev_uuid = cfg_xenapi.get('uuid', uuid.createString())

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel