Skip to contentSkip to conversation

serial: men_z135_uart: Drop duplicated iotype assignment

PATCH RESEND In review Ilpo Järvinen 2 participants 2 messages May 4, 2022 – May 9, 2022 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 serial: men_z135_uart: Drop duplicated iotype assignment

The driver assigns same iotype twice. Drop one of them.

---

Resending with correct linux-serial address.

 drivers/tty/serial/men_z135_uart.c | 1 -
 1 file changed, 1 deletion(-)
drivers/tty/serial/men_z135_uart.c +0 -1
index 9acae5f8fc32..12117b596e73 100644
@@ -833,7 +833,6 @@ static int men_z135_probe(struct mcb_device *mdev,
 	uart->port.iotype = UPIO_MEM;
 	uart->port.ops = &men_z135_ops;
 	uart->port.irq = mcb_get_irq(mdev);
-	uart->port.iotype = UPIO_MEM;
 	uart->port.flags = UPF_BOOT_AUTOCONF | UPF_IOREMAP;
 	uart->port.line = line++;
 	uart->port.dev = dev;
Signature · 1 line
tg: (672c0c517342..) cleanup/dbl_iotype_assign (depends on: master)
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Ilpo Järvinen

The driver assigns same iotype twice. Drop one of them.

Quoted 20 lines

---

Resending with correct linux-serial address.

  drivers/tty/serial/men_z135_uart.c | 1 -
  1 file changed, 1 deletion(-)
drivers/tty/serial/men_z135_uart.c +0 -1
index 9acae5f8fc32..12117b596e73 100644
@@ -833,7 +833,6 @@ static int men_z135_probe(struct mcb_device *mdev,
  	uart->port.iotype = UPIO_MEM;
  	uart->port.ops = &men_z135_ops;
  	uart->port.irq = mcb_get_irq(mdev);
-	uart->port.iotype = UPIO_MEM;
  	uart->port.flags = UPF_BOOT_AUTOCONF | UPF_IOREMAP;
  	uart->port.line = line++;
  	uart->port.dev = dev;
Signature · 2 lines
js
suse labs