Add SMI LARBs reset for MediaTek MT8188 SoC
Subsystems (3)
v4 cover Add SMI LARBs reset for MediaTek MT8188 SoC
Based on tag: next-20250220, linux-next/master
On the MediaTek MT8188 SoC platform, we encountered power-off failures and SMI bus hang issues during camera stress tests. The issue arises because bus glitches are sometimes produced when MTCMOS powers on or off. While this is fairly normal, the software must handle these glitches to avoid mistaking them for transaction signals. What's more, this issue emerged only after the initial upstreaming of this binding.
The software solutions can be summarized as follows:
1. Use CLAMP to disable the SMI sub-common port after turning off the LARB CG and before turning off the LARB MTCMOS.
2. Use CLAMP to disable/enable the SMI sub-common port.
3. Implement an AXI reset for SMI LARBs.
This patch primarily provides the implementation of an AXI reset.
Changes v4:
- Modify the commit message
v3:
https://lore.kernel.org/lkml/20250121065045.13514-2
[email protected]/
https://lore.kernel.org/lkml/20250121065045.13514-3
[email protected]/
Friday Yang (2):
dt-bindings: clock: mediatek: Add SMI LARBs reset for MT8188
clk: mediatek: Add SMI LARBs reset for MT8188
.../bindings/clock/mediatek,mt8188-clock.yaml | 21 +++++++++++++++++++ drivers/clk/mediatek/clk-mt8188-cam.c | 17 +++++++++++++++ drivers/clk/mediatek/clk-mt8188-img.c | 18 ++++++++++++++++ drivers/clk/mediatek/clk-mt8188-ipe.c | 14 +++++++++++++ 4 files changed, 70 insertions(+)
--
2.46.0
PATCH v4 1/2 dt-bindings: clock: mediatek: Add SMI LARBs reset for MT8188
On the MediaTek platform, some SMI LARBs are directly connected to the SMI Common, while others are connected to the SMI Sub-Common, which in turn is connected to the SMI Common. The hardware block diagram can be described as follows.
SMI-Common(Smart Multimedia Interface Common)
|
+----------------+------------------+
| | |
| | |
| | |
| | |
| | |
larb0 SMI-Sub-Common0 SMI-Sub-Common1
| | | | |
larb1 larb2 larb3 larb7 larb9
For previous discussion on the direction of the code modifications, please refer to:
https://lore.kernel.org/all/CAFGrd9qZhObQXvm2_abqaX83xMLqxjQETB2=
[email protected]/
https://lore.kernel.org/all/CAPDyKFpokXV2gJDgowbixTvOH_5VL3B5H8ey
[email protected]/
On the MediaTek MT8188 SoC platform, we encountered power-off failures and SMI bus hang issues during camera stress tests. The issue arises because bus glitches are sometimes produced when MTCMOS powers on or off. While this is fairly normal, the software must handle these glitches to avoid mistaking them for transaction signals. What's more, this issue emerged only after the initial upstreaming of this binding. Without these patches, the SMI becomes unstable during camera stress tests.
The software solutions can be summarized as follows:
1. Use CLAMP to disable the SMI sub-common port after turning off the LARB CG and before turning off the LARB MTCMOS.
2. Use CLAMP to disable/enable the SMI sub-common port.
3. Implement an AXI reset for SMI LARBs.
This patch add '#reset-cells' for the clock controller located in image, camera and IPE subsystems.
--- .../bindings/clock/mediatek,mt8188-clock.yaml | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+)
Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml +21 -0
@@ -57,6 +57,27 @@ required: - reg - '#clock-cells' +allOf: + - if: + properties: + compatible: + contains: + enum: + - mediatek,mt8188-camsys-rawa + - mediatek,mt8188-camsys-rawb + - mediatek,mt8188-camsys-yuva + - mediatek,mt8188-camsys-yuvb + - mediatek,mt8188-imgsys-wpe1 + - mediatek,mt8188-imgsys-wpe2 + - mediatek,mt8188-imgsys-wpe3 + - mediatek,mt8188-imgsys1-dip-nr + - mediatek,mt8188-imgsys1-dip-top + - mediatek,mt8188-ipesys + + then: + required: + - '#reset-cells' + additionalProperties: false examples:
--
2.46.0
Re: [PATCH v4 1/2] dt-bindings: clock: mediatek: Add SMI LARBs reset for MT8188
Quoted 40 lines · Friday Yang
On the MediaTek platform, some SMI LARBs are directly connected to the SMI Common, while others are connected to the SMI Sub-Common, which in turn is connected to the SMI Common. The hardware block diagram can be described as follows.
SMI-Common(Smart Multimedia Interface Common)
|
+----------------+------------------+
| | |
| | |
| | |
| | |
| | |
larb0 SMI-Sub-Common0 SMI-Sub-Common1
| | | | |
larb1 larb2 larb3 larb7 larb9For previous discussion on the direction of the code modifications, please refer to:
https://lore.kernel.org/all/CAFGrd9qZhObQXvm2_abqaX83xMLqxjQETB2=
[email protected]/
https://lore.kernel.org/all/CAPDyKFpokXV2gJDgowbixTvOH_5VL3B5H8ey
[email protected]/On the MediaTek MT8188 SoC platform, we encountered power-off failures and SMI bus hang issues during camera stress tests. The issue arises because bus glitches are sometimes produced when MTCMOS powers on or off. While this is fairly normal, the software must handle these glitches to avoid mistaking them for transaction signals. What's more, this issue emerged only after the initial upstreaming of this binding. Without these patches, the SMI becomes unstable during camera stress tests.
The software solutions can be summarized as follows:
1. Use CLAMP to disable the SMI sub-common port after turning off the LARB CG and before turning off the LARB MTCMOS.
2. Use CLAMP to disable/enable the SMI sub-common port.
3. Implement an AXI reset for SMI LARBs.
Quoted 4 lines
This patch add '#reset-cells' for the clock controller located in image, camera and IPE subsystems.
Signed-off-by Friday Yang <[email protected]>
Re: [PATCH v4 1/2] dt-bindings: clock: mediatek: Add SMI LARBs reset for MT8188
In reply to Friday YangIl 21/02/25 08:50, Friday Yang ha scritto:
Quoted 40 lines
On the MediaTek platform, some SMI LARBs are directly connected to the SMI Common, while others are connected to the SMI Sub-Common, which in turn is connected to the SMI Common. The hardware block diagram can be described as follows.
SMI-Common(Smart Multimedia Interface Common)
|
+----------------+------------------+
| | |
| | |
| | |
| | |
| | |
larb0 SMI-Sub-Common0 SMI-Sub-Common1
| | | | |
larb1 larb2 larb3 larb7 larb9For previous discussion on the direction of the code modifications, please refer to:
https://lore.kernel.org/all/CAFGrd9qZhObQXvm2_abqaX83xMLqxjQETB2=
[email protected]/
https://lore.kernel.org/all/CAPDyKFpokXV2gJDgowbixTvOH_5VL3B5H8ey
[email protected]/On the MediaTek MT8188 SoC platform, we encountered power-off failures and SMI bus hang issues during camera stress tests. The issue arises because bus glitches are sometimes produced when MTCMOS powers on or off. While this is fairly normal, the software must handle these glitches to avoid mistaking them for transaction signals. What's more, this issue emerged only after the initial upstreaming of this binding. Without these patches, the SMI becomes unstable during camera stress tests.
The software solutions can be summarized as follows:
1. Use CLAMP to disable the SMI sub-common port after turning off the LARB CG and before turning off the LARB MTCMOS.
2. Use CLAMP to disable/enable the SMI sub-common port.
3. Implement an AXI reset for SMI LARBs.
Quoted 4 lines
This patch add '#reset-cells' for the clock controller located in image, camera and IPE subsystems.
Signed-off-by Friday Yang <[email protected]>
Quoted 39 lines
--- .../bindings/clock/mediatek,mt8188-clock.yaml | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+)Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml +21
-1@@ -57,6 +57,27 @@ required: - reg - '#clock-cells' +allOf: + - if: + properties: + compatible: + contains: + enum: + - mediatek,mt8188-camsys-rawa + - mediatek,mt8188-camsys-rawb + - mediatek,mt8188-camsys-yuva + - mediatek,mt8188-camsys-yuvb + - mediatek,mt8188-imgsys-wpe1 + - mediatek,mt8188-imgsys-wpe2 + - mediatek,mt8188-imgsys-wpe3 + - mediatek,mt8188-imgsys1-dip-nr + - mediatek,mt8188-imgsys1-dip-top + - mediatek,mt8188-ipesys + + then: + required: + - '#reset-cells' + additionalProperties: false examples: --2.46.0
Signature · 6 lines
AngeloGioacchino Del Regno Senior Software Engineer Collabora Ltd. Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK Registered in England & Wales, no. 5513718
Re: [PATCH v4 1/2] dt-bindings: clock: mediatek: Add SMI LARBs reset for MT8188
In reply to Friday YangQuoting Friday Yang (2025-02-20 23:50:53)
Quoted 8 lines
On the MediaTek platform, some SMI LARBs are directly connected to the SMI Common, while others are connected to the SMI Sub-Common, which in turn is connected to the SMI Common. The hardware block diagram can be described as follows.
SMI-Common(Smart Multimedia Interface Common) | +----------------+------------------+
Applied to clk-next
PATCH v4 2/2 clk: mediatek: Add SMI LARBs reset for MT8188
In reply to Friday YangSMI LARBs require reset functions when MTCMOS powers on or off. Add reset platform data for SMI LARBs in the image, camera and IPE subsystems.
--- drivers/clk/mediatek/clk-mt8188-cam.c | 17 +++++++++++++++++ drivers/clk/mediatek/clk-mt8188-img.c | 18 ++++++++++++++++++ drivers/clk/mediatek/clk-mt8188-ipe.c | 14 ++++++++++++++ 3 files changed, 49 insertions(+)
drivers/clk/mediatek/clk-mt8188-cam.c +17 -0
@@ -20,6 +20,8 @@ static const struct mtk_gate_regs cam_cg_regs = {#define GATE_CAM (_id, _name, _parent, _shift) \ GATE_MTK(_id, _name, _parent, &cam_cg_regs, _shift, &mtk_clk_gate_ops_setclr) +#define CAM_SYS_SMI_LARB_RST_OFF (0xA0) +static const struct mtk_gate cam_main_clks[] = {GATE_CAM (CLK_CAM_MAIN_LARB13 ,"cam_main_larb13" ,"top_cam" ,0 ),GATE_CAM (CLK_CAM_MAIN_LARB14 ,"cam_main_larb14" ,"top_cam" ,1 ),
@@ -72,6 +74,17 @@ static const struct mtk_gate cam_yuvb_clks[] = { GATE_CAM(CLK_CAM_YUVB_CAMTG, "cam_yuvb_camtg", "top_cam", 2), }; +/* Reset for SMI larb 16a/16b/17a/17b */ +static u16 cam_sys_rst_ofs[] = { +CAM_SYS_SMI_LARB_RST_OFF , +}; + +static const struct mtk_clk_rst_desc cam_sys_rst_desc = { + .version =MTK_RST_SIMPLE , + .rst_bank_ofs = cam_sys_rst_ofs, + .rst_bank_nr =ARRAY_SIZE (cam_sys_rst_ofs), +}; +static const struct mtk_clk_desc cam_main_desc = { .clks = cam_main_clks, .num_clks =ARRAY_SIZE (cam_main_clks),
@@ -80,21 +93,25 @@ static const struct mtk_clk_desc cam_main_desc = {static const struct mtk_clk_desc cam_rawa_desc = { .clks = cam_rawa_clks, .num_clks =ARRAY_SIZE (cam_rawa_clks), + .rst_desc = &cam_sys_rst_desc, };static const struct mtk_clk_desc cam_rawb_desc = { .clks = cam_rawb_clks, .num_clks =ARRAY_SIZE (cam_rawb_clks), + .rst_desc = &cam_sys_rst_desc, };static const struct mtk_clk_desc cam_yuva_desc = { .clks = cam_yuva_clks, .num_clks =ARRAY_SIZE (cam_yuva_clks), + .rst_desc = &cam_sys_rst_desc, };static const struct mtk_clk_desc cam_yuvb_desc = { .clks = cam_yuvb_clks, .num_clks =ARRAY_SIZE (cam_yuvb_clks), + .rst_desc = &cam_sys_rst_desc, };static const struct of_device_id of_match_clk_mt8188_cam[] = {
drivers/clk/mediatek/clk-mt8188-img.c +18 -0
@@ -20,6 +20,8 @@ static const struct mtk_gate_regs imgsys_cg_regs = {#define GATE_IMGSYS (_id, _name, _parent, _shift) \ GATE_MTK(_id, _name, _parent, &imgsys_cg_regs, _shift, &mtk_clk_gate_ops_setclr) +#define IMG_SYS_SMI_LARB_RST_OFF (0xC) +static const struct mtk_gate imgsys_main_clks[] = {GATE_IMGSYS (CLK_IMGSYS_MAIN_LARB9 ,"imgsys_main_larb9" ,"top_img" ,0 ),GATE_IMGSYS (CLK_IMGSYS_MAIN_TRAW0 ,"imgsys_main_traw0" ,"top_img" ,1 ),
@@ -58,6 +60,17 @@ static const struct mtk_gate imgsys1_dip_nr_clks[] = { GATE_IMGSYS(CLK_IMGSYS1_DIP_NR_DIP_NR, "imgsys1_dip_nr_dip_nr", "top_img", 1), }; +/* Reset for SMI larb 10/11a/11b/11c/15 */ +static u16 img_sys_rst_ofs[] = { +IMG_SYS_SMI_LARB_RST_OFF , +}; + +static const struct mtk_clk_rst_desc img_sys_rst_desc = { + .version =MTK_RST_SIMPLE , + .rst_bank_ofs = img_sys_rst_ofs, + .rst_bank_nr =ARRAY_SIZE (img_sys_rst_ofs), +}; +static const struct mtk_clk_desc imgsys_main_desc = { .clks = imgsys_main_clks, .num_clks =ARRAY_SIZE (imgsys_main_clks),
@@ -66,26 +79,31 @@ static const struct mtk_clk_desc imgsys_main_desc = {static const struct mtk_clk_desc imgsys_wpe1_desc = { .clks = imgsys_wpe1_clks, .num_clks =ARRAY_SIZE (imgsys_wpe1_clks), + .rst_desc = &img_sys_rst_desc, };static const struct mtk_clk_desc imgsys_wpe2_desc = { .clks = imgsys_wpe2_clks, .num_clks =ARRAY_SIZE (imgsys_wpe2_clks), + .rst_desc = &img_sys_rst_desc, };static const struct mtk_clk_desc imgsys_wpe3_desc = { .clks = imgsys_wpe3_clks, .num_clks =ARRAY_SIZE (imgsys_wpe3_clks), + .rst_desc = &img_sys_rst_desc, };static const struct mtk_clk_desc imgsys1_dip_top_desc = { .clks = imgsys1_dip_top_clks, .num_clks =ARRAY_SIZE (imgsys1_dip_top_clks), + .rst_desc = &img_sys_rst_desc, };static const struct mtk_clk_desc imgsys1_dip_nr_desc = { .clks = imgsys1_dip_nr_clks, .num_clks =ARRAY_SIZE (imgsys1_dip_nr_clks), + .rst_desc = &img_sys_rst_desc, };static const struct of_device_id of_match_clk_mt8188_imgsys_main[] = {
drivers/clk/mediatek/clk-mt8188-ipe.c +14 -0
@@ -20,6 +20,8 @@ static const struct mtk_gate_regs ipe_cg_regs = {#define GATE_IPE (_id, _name, _parent, _shift) \ GATE_MTK(_id, _name, _parent, &ipe_cg_regs, _shift, &mtk_clk_gate_ops_setclr) +#define IPE_SYS_SMI_LARB_RST_OFF (0xC) +static const struct mtk_gate ipe_clks[] = {GATE_IPE (CLK_IPE_DPE ,"ipe_dpe" ,"top_ipe" ,0 ),GATE_IPE (CLK_IPE_FDVT ,"ipe_fdvt" ,"top_ipe" ,1 ),
@@ -28,9 +30,21 @@ static const struct mtk_gate ipe_clks[] = { GATE_IPE(CLK_IPE_SMI_LARB12, "ipe_smi_larb12", "top_ipe", 4), }; +/* Reset for SMI larb 12 */ +static u16 ipe_sys_rst_ofs[] = { +IPE_SYS_SMI_LARB_RST_OFF , +}; + +static const struct mtk_clk_rst_desc ipe_sys_rst_desc = { + .version =MTK_RST_SIMPLE , + .rst_bank_ofs = ipe_sys_rst_ofs, + .rst_bank_nr =ARRAY_SIZE (ipe_sys_rst_ofs), +}; +static const struct mtk_clk_desc ipe_desc = { .clks = ipe_clks, .num_clks =ARRAY_SIZE (ipe_clks), + .rst_desc = &ipe_sys_rst_desc, };static const struct of_device_id of_match_clk_mt8188_ipe[] = {
--
2.46.0
Re: [PATCH v4 2/2] clk: mediatek: Add SMI LARBs reset for MT8188
Il 21/02/25 08:50, Friday Yang ha scritto:
Quoted 5 lines
SMI LARBs require reset functions when MTCMOS powers on or off. Add reset platform data for SMI LARBs in the image, camera and IPE subsystems.
Signed-off-by Friday Yang <[email protected]>
Re: [PATCH v4 2/2] clk: mediatek: Add SMI LARBs reset for MT8188
In reply to Friday YangQuoting Friday Yang (2025-02-20 23:50:54)
Quoted 6 lines
SMI LARBs require reset functions when MTCMOS powers on or off. Add reset platform data for SMI LARBs in the image, camera and IPE subsystems.
Signed-off-by Friday Yang <[email protected]>---
Applied to clk-next