Skip to contentSkip to conversation

patch "serial: st-asc: Potential error pointer dereference" added to tty-linus

PATCH [email protected] 1 participant 1 message Jul 17, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

serial: st-asc: Potential error pointer dereference

to my tty git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
in the tty-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

Quoted 1 line

From 2b01bfaeb41e1563322448d9b392ac924cbf22ef Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Mon, 17 Jul 2017 11:12:38 +0300
Subject: serial: st-asc: Potential error pointer dereference

It looks like we intended to return an error code here, because we dereference "ascport->pinctrl" on the next lines.

Fixes 6929cb00a501 ("serial: st-asc: Read in all Pinctrl states")
Cc stable <[email protected]>
---
 drivers/tty/serial/st-asc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/tty/serial/st-asc.c +1 -0
index f5335be344f6..6b0ca65027d0 100644
@@ -758,6 +758,7 @@ static int asc_init_port(struct asc_port *ascport,
 	if (IS_ERR(ascport->pinctrl)) {
 		ret = PTR_ERR(ascport->pinctrl);
 		dev_err(&pdev->dev, "Failed to get Pinctrl: %d\n", ret);
+		return ret;
 	}
 
 	ascport->states[DEFAULT] =
Signature · 1 line
2.13.3