Patch "liquidio: fix bug in soft reset failure detection" has been added to the 4.12-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
liquidio: fix bug in soft reset failure detection
to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
liquidio-fix-bug-in-soft-reset-failure-detection.patch
and it can be found in the queue-4.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Mon Jul 17 18:46:41 CEST 2017
From: Derek Chickles <[email protected]>
Date: Wed, 5 Jul 2017 11:59:27 -0700
Subject: liquidio: fix bug in soft reset failure detection
From: Derek Chickles <[email protected]>
[ Upstream commit 05a6b4cae8c0cc1680c9dd33a97a49a13c0f01bc ]
The code that detects a failed soft reset of Octeon is comparing the wrong value against the reset value of the Octeon SLI_SCRATCH_1 register, resulting in an inability to detect a soft reset failure. Fix it by using the correct value in the comparison, which is any non-zero value.
--- drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c | 2 +- drivers/net/ethernet/cavium/liquidio/cn66xx_device.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c +1 -1
@@ -221,7 +221,7 @@ static int cn23xx_pf_soft_reset(struct o/* Wait for 100ms as Octeon resets. */ mdelay (100 ); -if (octeon_read_csr64 (oct,CN23XX_SLI_SCRATCH1 ) ==0x1234ULL ) { +if (octeon_read_csr64 (oct,CN23XX_SLI_SCRATCH1 )) {dev_err (&oct->pci_dev->dev,"OCTEON[%d]: Soft reset failed\n" , oct->octeon_id);return 1 ;
drivers/net/ethernet/cavium/liquidio/cn66xx_device.c +1 -1
@@ -44,7 +44,7 @@ int lio_cn6xxx_soft_reset(struct octeon_/* Wait for 10ms as Octeon resets. */ mdelay (100 ); -if (octeon_read_csr64 (oct,CN6XXX_SLI_SCRATCH1 ) ==0x1234ULL ) { +if (octeon_read_csr64 (oct,CN6XXX_SLI_SCRATCH1 )) {dev_err (&oct->pci_dev->dev,"Soft reset failed\n" );return 1 ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.12/liquidio-fix-bug-in-soft-reset-failure-detection.patch