Skip to contentSkip to conversation

Patch "net/mlx5e: Fix TX carrier errors report in get stats ndo" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Jul 17, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net/mlx5e: Fix TX carrier errors report in get stats ndo

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-mlx5e-fix-tx-carrier-errors-report-in-get-stats-ndo.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Jul 17 18:46:41 CEST 2017

From: Gal Pressman <[email protected]>
Date: Sun, 25 Jun 2017 16:46:25 +0300
Subject: net/mlx5e: Fix TX carrier errors report in get stats ndo

From: Gal Pressman <[email protected]>

[ Upstream commit 8ff93de7668bd81bc8efa819d1184ebd48fae72d ]

Symbol error during carrier counter from PPCNT was mistakenly reported as TX carrier errors in get_stats ndo, although it's an RX counter.

Fixes 269e6b3af3bf ("net/mlx5e: Report additional error statistics in get stats ndo")
---
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c |    2 --
 1 file changed, 2 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_main.c +0 -2
@@ -3053,8 +3053,6 @@ mlx5e_get_stats(struct net_device *dev,
 		PPORT_802_3_GET(pstats, a_frame_check_sequence_errors);
 	stats->rx_frame_errors = PPORT_802_3_GET(pstats, a_alignment_errors);
 	stats->tx_aborted_errors = PPORT_2863_GET(pstats, if_out_discards);
-	stats->tx_carrier_errors =
-		PPORT_802_3_GET(pstats, a_symbol_error_during_carrier);
 	stats->rx_errors = stats->rx_length_errors + stats->rx_crc_errors +
 			   stats->rx_frame_errors;
 	stats->tx_errors = stats->tx_aborted_errors + stats->tx_carrier_errors;

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/net-mlx5e-fix-tx-carrier-errors-report-in-get-stats-ndo.patch queue-4.12/net-mlx5-fix-driver-load-error-flow-when-firmware-is-stuck.patch