Skip to contentSkip to conversation

Patch "cfg80211: Define nla_policy for NL80211_ATTR_LOCAL_MESH_POWER_MODE" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jul 18, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

    cfg80211: Define nla_policy for NL80211_ATTR_LOCAL_MESH_POWER_MODE

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     cfg80211-define-nla_policy-for-nl80211_attr_local_mesh_power_mode.patch

and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 8feb69c7bd89513be80eb19198d48f154b254021 Mon Sep 17 00:00:00 2001

From: Srinivas Dasari <[email protected]>
Date: Fri, 7 Jul 2017 01:43:41 +0300
Subject: cfg80211: Define nla_policy for NL80211_ATTR_LOCAL_MESH_POWER_MODE

From: Srinivas Dasari <[email protected]>

commit 8feb69c7bd89513be80eb19198d48f154b254021 upstream.

Buffer overread may happen as nl80211_set_station() reads 4 bytes from the attribute NL80211_ATTR_LOCAL_MESH_POWER_MODE without validating the size of data received when userspace sends less than 4 bytes of data with NL80211_ATTR_LOCAL_MESH_POWER_MODE. Define nla_policy for NL80211_ATTR_LOCAL_MESH_POWER_MODE to avoid the buffer overread.

Fixes 3b1c5a5307f ("{cfg,nl}80211: mesh power mode primitives and userspace access")
---
 net/wireless/nl80211.c |    1 +
 1 file changed, 1 insertion(+)
net/wireless/nl80211.c +1 -0
@@ -359,6 +359,7 @@ static const struct nla_policy nl80211_p
 	[NL80211_ATTR_SCAN_FLAGS] = { .type = NLA_U32 },
 	[NL80211_ATTR_P2P_CTWINDOW] = { .type = NLA_U8 },
 	[NL80211_ATTR_P2P_OPPPS] = { .type = NLA_U8 },
+	[NL80211_ATTR_LOCAL_MESH_POWER_MODE] = {. type = NLA_U32 },
 	[NL80211_ATTR_ACL_POLICY] = {. type = NLA_U32 },
 	[NL80211_ATTR_MAC_ADDRS] = { .type = NLA_NESTED },
 	[NL80211_ATTR_STA_CAPABILITY] = { .type = NLA_U16 },

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/cfg80211-validate-frequencies-nested-in-nl80211_attr_scan_frequencies.patch queue-4.4/cfg80211-check-if-pmkid-attribute-is-of-expected-size.patch queue-4.4/cfg80211-define-nla_policy-for-nl80211_attr_local_mesh_power_mode.patch