Patch "cfg80211: Check if PMKID attribute is of expected size" has been added to the 3.18-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
cfg80211: Check if PMKID attribute is of expected size
to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
cfg80211-check-if-pmkid-attribute-is-of-expected-size.patch
and it can be found in the queue-3.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
9361df14d1cbf966409d5d6f48bb334384fbe138Mon Sep 17 00:00:00 2001
From: Srinivas Dasari <[email protected]>
Date: Fri, 7 Jul 2017 01:43:39 +0300
Subject: cfg80211: Check if PMKID attribute is of expected size
From: Srinivas Dasari <[email protected]>
commit 9361df14d1cbf966409d5d6f48bb334384fbe138 upstream.
nla policy checks for only maximum length of the attribute data when the attribute type is NLA_BINARY. If userspace sends less data than specified, the wireless drivers may access illegal memory. When type is NLA_UNSPEC, nla policy check ensures that userspace sends minimum specified length number of bytes.
Remove type assignment to NLA_BINARY from nla_policy of NL80211_ATTR_PMKID to make this NLA_UNSPEC and to make sure minimum WLAN_PMKID_LEN bytes are received from userspace with NL80211_ATTR_PMKID.
--- net/wireless/nl80211.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
net/wireless/nl80211.c +1 -2
@@ -301,8 +301,7 @@ static const struct nla_policy nl80211_p [NL80211_ATTR_WPA_VERSIONS] = { .type = NLA_U32 }, [NL80211_ATTR_PID] = { .type = NLA_U32 }, [NL80211_ATTR_4ADDR] = { .type = NLA_U8 }, - [NL80211_ATTR_PMKID] = { .type = NLA_BINARY, - .len = WLAN_PMKID_LEN }, + [NL80211_ATTR_PMKID] = { .len = WLAN_PMKID_LEN }, [NL80211_ATTR_DURATION] = { .type = NLA_U32 }, [NL80211_ATTR_COOKIE] = { .type = NLA_U64 }, [NL80211_ATTR_TX_RATES] = { .type = NLA_NESTED },
Patches currently in stable-queue which might be from [email protected] are
queue-3.18/cfg80211-validate-frequencies-nested-in-nl80211_attr_scan_frequencies.patch queue-3.18/cfg80211-check-if-pmkid-attribute-is-of-expected-size.patch queue-3.18/cfg80211-define-nla_policy-for-nl80211_attr_local_mesh_power_mode.patch