Skip to contentSkip to conversation

qcom: mtd: nand: fixed config error for BCH

PATCH New Abhishek Sahu 1 participant 1 message Jul 19, 2017 1 message not in the archive

Subsystems (4)
Stable branch Arm Qualcomm mailing list Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Abhishek Sahu

author
#1 lore raw

PATCH v2 1/25 qcom: mtd: nand: fixed config error for BCH

The configuration for BCH is not correct in the current driver. The ECC_CFG_ECC_DISABLE bit defines whether to enable or disable the BCH ECC in which

	0x1 : BCH_DISABLED
	0x0 : BCH_ENABLED

But currently host->bch_enabled is being assined to BCH_DISABLED.

Fixes c76b78d8ec05a ("mtd: nand: Qualcomm NAND controller driver")
Cc [email protected]
Signed-off-by Abhishek Sahu <[email protected]>
---
 drivers/mtd/nand/qcom_nandc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mtd/nand/qcom_nandc.c +2 -2
index 57d483a..bc0408c 100644
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2016-2017, The Linux Foundation. All rights reserved.
  *
  * This software is licensed under the terms of the GNU General Public
  * License version 2, as published by the Free Software Foundation, and

@@ -1893,7 +1893,7 @@ static int qcom_nand_host_setup(struct qcom_nand_host *host)
 				| wide_bus << WIDE_FLASH
 				| 1 << DEV0_CFG1_ECC_DISABLE;
 
-	host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE
+	host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE
 				| 0 << ECC_SW_RESET
 				| host->cw_data << ECC_NUM_DATA_BYTES
 				| 1 << ECC_FORCE_CLK_OPEN
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation