Skip to contentSkip to conversation

Patch "ALSA: x86: Clear the pdata.notify_lpe_audio pointer before teardown" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jul 19, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: x86: Clear the pdata.notify_lpe_audio pointer before teardown

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-x86-clear-the-pdata.notify_lpe_audio-pointer-before-teardown.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 8d5c30308d7c5a17db96fa5452c0232f633377c2 Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <[email protected]>
Date: Thu, 27 Apr 2017 19:02:21 +0300
Subject: ALSA: x86: Clear the pdata.notify_lpe_audio pointer before teardown
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Ville Syrjälä <[email protected]>

commit 8d5c30308d7c5a17db96fa5452c0232f633377c2 upstream.

Clear the notify function pointer in the platform data before we tear down the driver. Otherwise i915 would end up calling a stale function pointer and possibly explode.

---
 sound/x86/intel_hdmi_audio.c |    5 +++++
 1 file changed, 5 insertions(+)
sound/x86/intel_hdmi_audio.c +5 -0
@@ -1665,6 +1665,11 @@ static int __maybe_unused hdmi_lpe_audio
 static void hdmi_lpe_audio_free(struct snd_card *card)
 {
 	struct snd_intelhad *ctx = card->private_data;
+	struct intel_hdmi_lpe_audio_pdata *pdata = ctx->dev->platform_data;
+
+	spin_lock_irq(&pdata->lpe_audio_slock);
+	pdata->notify_audio_lpe = NULL;
+	spin_unlock_irq(&pdata->lpe_audio_slock);
 
 	cancel_work_sync(&ctx->hdmi_audio_wq);
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/alsa-x86-clear-the-pdata.notify_lpe_audio-pointer-before-teardown.patch