fixed ethernet binding violation for reset signal
Subsystems (3)
cover fixed ethernet binding violation for reset signal
From: Sean Wang <[email protected]>
Fixed binding violation and also updated related binding documentation to reflect the reset signals the MediaTek Ethernet requires.
Sean Wang (2):
dt-bindings: net: mediatek: update documentation for reset signals
arm: dts: mt7623: fixup binding violation missing reset in ethernet
node
Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++-- arch/arm/boot/dts/mt7623.dtsi | 4 ++++ 2 files changed, 8 insertions(+), 2 deletions(-)
Signature · 1 line
2.7.4
PATCH 1/2 dt-bindings: net: mediatek: update documentation for reset signals
From: Sean Wang <[email protected]>
Since there's no user for the property reset inside the ethernet node for current supported MediaTek SoCs and boards, so it should be safe to update reset property in the bindings to introduce more reset signals as corresponding that commit 7c2adaf11036 ("reset: mediatek: Add MT2701 ethsys reset controller include file") did in order to be referenced them from within a devicetree file.
--- Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/net/mediatek-net.txt +4 -2
@@ -15,8 +15,10 @@ Required properties: - clock-names: the names of the clock listed in the clocks property. These are "ethif", "esw", "gp2", "gp1" - power-domains: phandle to the power domain that the ethernet is part of -- resets: Should contain a phandle to the ethsys reset signal -- reset-names: Should contain the reset signal name "eth" +- resets: Should contain phandles to the ethsys reset signals +- reset-names: Should contain the names of reset signal listed in the resets + property + These are "fe", "gmac" and "ppe" - mediatek,ethsys: phandle to the syscon node that handles the port setup - mediatek,pctl: phandle to the syscon node that handles the ports slew rate and driver current
Signature · 1 line
2.7.4
Re: [PATCH 1/2] dt-bindings: net: mediatek: update documentation for reset signals
Quoted 9 lines · sean.wang at mediatek.com
From: Sean Wang <[email protected]>
Since there's no user for the property reset inside the ethernet node for current supported MediaTek SoCs and boards, so it should be safe to update reset property in the bindings to introduce more reset signals as corresponding that commit
7c2adaf11036("reset: mediatek: Add MT2701 ethsys reset controller include file") did in order to be referenced them from within a devicetree file.
Quoted 5 lines
Cc John Crispin <[email protected]>Signed-off-by Sean Wang <[email protected]>--- Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
PATCH 2/2 arm: dts: mt7623: fixup binding violation missing reset in ethernet node
In reply to [email protected]From: Sean Wang <[email protected]>
fix up binding violation where the reset property is required additionally.
--- arch/arm/boot/dts/mt7623.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/boot/dts/mt7623.dtsi +4 -0
@@ -782,6 +782,10 @@ <ðsys CLK_ETHSYS_GP2>, <&apmixedsys CLK_APMIXED_TRGPLL>; clock-names = "ethif", "esw", "gp1", "gp2", "trgpll"; + resets = <ðsys MT2701_ETHSYS_FE_RST>, + <ðsys MT2701_ETHSYS_GMAC_RST>, + <ðsys MT2701_ETHSYS_PPE_RST>; + reset-names = "fe", "gmac", "ppe"; power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>; mediatek,ethsys = <ðsys>; mediatek,pctl = <&syscfg_pctl_a>;
Signature · 1 line
2.7.4
Hi, Matthias
just a gentle ping on this
Sean
Quoted 14 lines · sean.wang at mediatek.com
From: Sean Wang <[email protected]>
Fixed binding violation and also updated related binding documentation to reflect the reset signals the MediaTek Ethernet requires.
Sean Wang (2):
dt-bindings: net: mediatek: update documentation for reset signals
arm: dts: mt7623: fixup binding violation missing reset in ethernet
nodeDocumentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++-- arch/arm/boot/dts/mt7623.dtsi | 4 ++++ 2 files changed, 8 insertions(+), 2 deletions(-)
Matthias Brugger
maintainerQuoted 4 lines · Sean Wang
Hi, Matthias
just a gentle ping on this
Pushed now to v4.13-next/dts32
Thanks!
Quoted 20 lines
Sean
Quoted 14 lines · sean.wang at mediatek.com
From: Sean Wang <[email protected]>
Fixed binding violation and also updated related binding documentation to reflect the reset signals the MediaTek Ethernet requires.
Sean Wang (2):
dt-bindings: net: mediatek: update documentation for reset signals
arm: dts: mt7623: fixup binding violation missing reset in ethernet
nodeDocumentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++-- arch/arm/boot/dts/mt7623.dtsi | 4 ++++ 2 files changed, 8 insertions(+), 2 deletions(-)