Patch "[media] ir-core: fix gcc-7 warning on bool arithmetic" has been added to the 4.4-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
[media] ir-core: fix gcc-7 warning on bool arithmetic
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ir-core-fix-gcc-7-warning-on-bool-arithmetic.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
bd7e31bbade02bc1e92aa00d5cf2cee2da66838aMon Sep 17 00:00:00 2001
From: Arnd Bergmann <[email protected]>
Date: Thu, 11 May 2017 08:46:44 -0300
Subject: [media] ir-core: fix gcc-7 warning on bool arithmetic
From: Arnd Bergmann <[email protected]>
commit bd7e31bbade02bc1e92aa00d5cf2cee2da66838a upstream.
gcc-7 suggests that an expression using a bitwise not and a bitmask on a 'bool' variable is better written using boolean logic:
drivers/media/rc/imon.c: In function 'imon_incoming_scancode':drivers/media/rc/imon.c:1725:22: error: '~' on a boolean expression [-Werror=bool-operation]
ictx->pad_mouse = ~(ictx->pad_mouse) & 0x1;
^drivers/media/rc/imon.c:1725:22: note: did you mean to use logical not?
I agree.
--- drivers/media/rc/imon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/imon.c +1 -1
@@ -1629,7 +1629,7 @@ static void imon_incoming_packet(structif (kc ==KEY_KEYBOARD && !ictx->release_code) { ictx->last_keycode = kc;if (!nomouse) { - ictx->pad_mouse = ~(ictx->pad_mouse) &0x1 ; + ictx->pad_mouse = !ictx->pad_mouse;dev_dbg (dev,"toggling to %s mode\n" , ictx->pad_mouse ?"mouse" :"keyboard" );spin_unlock_irqrestore (&ictx->kc_lock, flags);
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/ir-core-fix-gcc-7-warning-on-bool-arithmetic.patch