Skip to contentSkip to conversation

FAILED: patch "[PATCH] [media] mceusb: fix memory leaks in error path" failed to apply to 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jul 22, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 2d5a6ce71c72d98d4f7948672842e3e8c265a8b7 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Thu, 1 Jun 2017 04:45:59 -0300
Subject: [PATCH] [media] mceusb: fix memory leaks in error path

Fix urb and transfer-buffer leaks in an urb-submission error path which may be hit when a device is disconnected.

Fixes 66e89522aff7 ("V4L/DVB: IR: add mceusb IR receiver driver")
drivers/media/rc/mceusb.c +2 -0
index 4530237cbb67..04d6cd1818fb 100644
@@ -795,6 +795,8 @@ static void mce_request_packet(struct mceusb_dev *ir, unsigned char *data,
 	res = usb_submit_urb(async_urb, GFP_ATOMIC);
 	if (res) {
 		dev_err(dev, "send request FAILED! (res=%d)", res);
+		kfree(async_buf);
+		usb_free_urb(async_urb);
 		return;
 	}
 	dev_dbg(dev, "send request complete (res=%d)", res);