Skip to contentSkip to conversation

staging: pi433: fix sparse warning: missing static

PATCH In review David Wittman 2 participants 2 messages Jul 23, 2017 – Jul 24, 2017 Staging

lore
Share & tools
lore

David Wittman

author
#0 lore raw

PATCH 1/1 staging: pi433: fix sparse warning: missing static

A few local functions in the pi433 module were getting flagged by Sparse for missing declarations, so I added static qualifiers to clean up the warnings.

Signed-off-by David Wittman <[email protected]>
---
 drivers/staging/pi433/pi433_if.c | 4 ++--
 drivers/staging/pi433/rf69.c     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/pi433/pi433_if.c +2 -2
index 1bc478a..46461b4 100644
@@ -313,7 +313,7 @@ struct pi433_instance {
 
 /*-------------------------------------------------------------------------*/
 
-int
+static int
 pi433_receive(void *data)
 {
 	struct pi433_device *dev = data;

@@ -463,7 +463,7 @@ struct pi433_instance {
 		return bytes_total;
 }
 
-int
+static int
 pi433_tx_thread(void *data)
 {
 	struct pi433_device *device = data;
drivers/staging/pi433/rf69.c +1 -1
index e391ce7..e5eee84 100644
@@ -433,7 +433,7 @@ int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum dccPer
 	return rf69_set_dc_cut_off_frequency_intern(spi, REG_AFCBW, dccPercent);
 }
 
-int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mantisse, u8 exponent)
+static int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mantisse, u8 exponent)
 {
 	u8 newValue;
Signature · 1 line
1.9.1
Reviewed-by on v1 1/1
#1 lore raw
Reviewed-by Marcus Wolf <[email protected]>

The fixes of this patch are fine, but there are already patches out there, containing these fixes.

Thanks,
Marcus

Quoted 56 lines

David Wittman <[email protected]> hat am 24. Juli 2017 um 00:46 geschrieben:

A few local functions in the pi433 module were getting flagged by Sparse for missing declarations, so I added static qualifiers to clean up the warnings.

Signed-off-by David Wittman <[email protected]>

---
drivers/staging/pi433/pi433_if.c | 4 ++--
drivers/staging/pi433/rf69.c | 2 +-

2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/pi433/pi433_if.c +2 -2
index 1bc478a..46461b4 100644
@@ -313,7 +313,7 @@ struct pi433_instance {
 
 /*-------------------------------------------------------------------------*/
 
-int
+static int
 pi433_receive(void *data)
 {
 struct pi433_device *dev = data;

@@ -463,7 +463,7 @@ struct pi433_instance {
 return bytes_total;
 }
 
-int
+static int
 pi433_tx_thread(void *data)
 {
 struct pi433_device *device = data;
drivers/staging/pi433/rf69.c +0 -0
index e391ce7..e5eee84 100644
@@ -433,7 +433,7 @@ int rf69_set_dc_cut_off_frequency_during_afc(struct

spi_device *spi, enum dccPer
return rf69_set_dc_cut_off_frequency_intern(spi, REG_AFCBW, dccPercent); }

-int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mantisse, u8 exponent)
+static int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mantisse, u8 exponent)
{
u8 newValue;

--
1.9.1