ftgmac100: Increase reset timeout

PATCH Applied Benjamin Herrenschmidt 2 participants 2 messages Jul 24, 2017 – Jul 25, 2017

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Benjamin Herrenschmidt

author

2017-07-24 06:59 UTC #0 lore raw

PATCH 1/2 ftgmac100: Increase reset timeout

We had reports of 50us not being sufficient to reset the MAC, thus hitting the "Hardware reset failed" error bringing the interface up on some AST2400 based machines.

This bumps the timeout to 200us.

Signed-off-by Benjamin Herrenschmidt <[email protected]>

---
 drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/net/ethernet/faraday/ftgmac100.c +1 -1

index b166666128d3..2b17f7023d91 100644
@@ -125,7 +125,7 @@ static int ftgmac100_reset_mac(struct ftgmac100 *priv, u32 maccr)
 	iowrite32(maccr, priv->base + FTGMAC100_OFFSET_MACCR);
 	iowrite32(maccr | FTGMAC100_MACCR_SW_RST,
 		  priv->base + FTGMAC100_OFFSET_MACCR);
-	for (i = 0; i < 50; i++) {
+	for (i = 0; i < 200; i++) {
 		unsigned int maccr;
 
 		maccr = ioread32(priv->base + FTGMAC100_OFFSET_MACCR);

David Miller

maintainer Applied

2017-07-25 00:24 UTC #1 lore raw

From: Benjamin Herrenschmidt <[email protected]>
Date: Mon, 24 Jul 2017 16:59:01 +1000

Quoted 7 lines

We had reports of 50us not being sufficient to reset the MAC, thus hitting the "Hardware reset failed" error bringing the interface up on some AST2400 based machines.
This bumps the timeout to 200us.
Signed-off-by Benjamin Herrenschmidt <[email protected]>

Applied.