Skip to contentSkip to conversation

Patch "ftrace: Fix uninitialized variable in match_records()" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Jul 25, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ftrace: Fix uninitialized variable in match_records()

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ftrace-fix-uninitialized-variable-in-match_records.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 2e028c4fe12907f226b8221815f16c2486ad3aa7 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Wed, 12 Jul 2017 10:35:57 +0300
Subject: ftrace: Fix uninitialized variable in match_records()

From: Dan Carpenter <[email protected]>

commit 2e028c4fe12907f226b8221815f16c2486ad3aa7 upstream.

My static checker complains that if "func" is NULL then "clear_filter" is uninitialized. This seems like it could be true, although it's possible something subtle is happening that I haven't seen.

kernel/trace/ftrace.c:3844 match_records()
error: uninitialized symbol 'clear_filter'.

Fixes f0a3b154bd7 ("ftrace: Clarify code for mod command")
---
 kernel/trace/ftrace.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/ftrace.c +1 -1
@@ -3665,7 +3665,7 @@ match_records(struct ftrace_hash *hash,
 	int exclude_mod = 0;
 	int found = 0;
 	int ret;
-	int clear_filter;
+	int clear_filter = 0;
 
 	if (func) {
 		func_g.type = filter_parse_regex(func, len, &func_g.search,

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/ftrace-fix-uninitialized-variable-in-match_records.patch queue-4.12/serial-st-asc-potential-error-pointer-dereference.patch queue-4.12/ipmi-ssif-add-missing-unlock-in-error-branch.patch queue-4.12/serial-sh-sci-uninitialized-variables-in-sysfs-files.patch queue-4.12/ovl-fix-random-return-value-on-mount.patch