Skip to contentSkip to conversation

Patch "NFS: Fix initialization of nfs_page_array->npages" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Jul 25, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

    NFS: Fix initialization of nfs_page_array->npages

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
nfs-fix-initialization-of-nfs_page_array-npages.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 2eb3aea7d9c43325a12df312adfc7fb25bbd636b Mon Sep 17 00:00:00 2001

From: Benjamin Coddington <[email protected]>
Date: Fri, 9 Jun 2017 11:03:23 -0400
Subject: NFS: Fix initialization of nfs_page_array->npages

From: Benjamin Coddington <[email protected]>

commit 2eb3aea7d9c43325a12df312adfc7fb25bbd636b upstream.

Commit 8ef9b0b9e1c0 open-coded nfs_pgarray_set(), and left out the initialization of the nfs_page_array's npages. This mistake didn't show up until testing with block layouts, and there shows that all pNFS reads return -EIO.

Fixes 8ef9b0b9e1c0 ("NFS: move nfs_pgarray_set() to open code")
---
 fs/nfs/pagelist.c |    1 +
 1 file changed, 1 insertion(+)
fs/nfs/pagelist.c +1 -0
@@ -779,6 +779,7 @@ int nfs_generic_pgio(struct nfs_pageio_d
 	gfp_t gfp_flags = GFP_KERNEL;
 
 	pagecount = nfs_page_array_len(mirror->pg_base, mirror->pg_count);
+	pg_array->npages = pagecount;
 
 	if (pagecount <= ARRAY_SIZE(pg_array->page_array))
 		pg_array->pagevec = pg_array->page_array;

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/nfs-fix-initialization-of-nfs_page_array-npages.patch