Skip to contentSkip to conversation

Patch "ovl: fix random return value on mount" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jul 25, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ovl: fix random return value on mount

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ovl-fix-random-return-value-on-mount.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 8fc646b44385ff0a9853f6590497e43049eeb311 Mon Sep 17 00:00:00 2001

From: Amir Goldstein <[email protected]>
Date: Tue, 11 Jul 2017 15:58:35 +0300
Subject: ovl: fix random return value on mount

From: Amir Goldstein <[email protected]>

commit 8fc646b44385ff0a9853f6590497e43049eeb311 upstream.

On failure to prepare_creds(), mount fails with a random return value, as err was last set to an integer cast of a valid lower mnt pointer or set to 0 if inodes index feature is enabled.

Fixes 3fe6e52f0626 ("ovl: override creds with the ones from ...")
---
 fs/overlayfs/super.c |    1 +
 1 file changed, 1 insertion(+)
fs/overlayfs/super.c +1 -0
@@ -1310,6 +1310,7 @@ static int ovl_fill_super(struct super_b
 	else
 		sb->s_d_op = &ovl_dentry_operations;
 
+	err = -ENOMEM;
 	ufs->creator_cred = cred = prepare_creds();
 	if (!cred)
 		goto out_put_lower_mnt;

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/ovl-drop-cap_sys_resource-from-saved-mounter-s-credentials.patch queue-4.9/ovl-fix-random-return-value-on-mount.patch