Skip to contentSkip to conversation

drm/amd/powerplay: updated vega10 fan control

PATCH In review Evan Quan 4 participants 5 messages Jul 28, 2017 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

Evan Quan

author
#0 lore raw

PATCH 2/3 drm/amd/powerplay: updated vega10 fan control

Change-Id Ifbeb1f0c8e195cc9cb1e9cff975284d96d49b193
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
 mode change 100644 => 100755 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c +1 -5
old mode 100644
new mode 100755
index 7bb4e46..ace1aca
@@ -321,10 +321,7 @@ int vega10_fan_ctrl_reset_fan_speed_to_default(struct pp_hwmgr *hwmgr)
 
 	if (phm_cap_enabled(hwmgr->platform_descriptor.platformCaps,
 			PHM_PlatformCaps_MicrocodeFanControl)) {
-		result = vega10_fan_ctrl_set_static_mode(hwmgr,
-				FDO_PWM_MODE_STATIC);
-		if (!result)
-			result = vega10_fan_ctrl_start_smc_fan_control(hwmgr);
+		result = vega10_fan_ctrl_start_smc_fan_control(hwmgr);
 	} else
 		result = vega10_fan_ctrl_set_default_mode(hwmgr);
 
@@ -633,7 +630,6 @@ int tf_vega10_thermal_start_smc_fan_control(struct pp_hwmgr *hwmgr,
 	if (phm_cap_enabled(hwmgr->platform_descriptor.platformCaps,
 			PHM_PlatformCaps_MicrocodeFanControl)) {
 		vega10_fan_ctrl_start_smc_fan_control(hwmgr);
-		vega10_fan_ctrl_set_static_mode(hwmgr, FDO_PWM_MODE_STATIC);
 	}
 
 	return 0;
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1501228845-21326-1-git-send-email-evan.quan-5C7GfCeVMHo@public.gmane.org

#2 lore raw
Quoted 6 lines · Evan Quan
Change-Id Ifbeb1f0c8e195cc9cb1e9cff975284d96d49b193
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
 mode change 100644 => 100755 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

Please fix your setup not to set executable bits for source code files.

Signature · 6 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 70c33897-ab8a-0a21-0ab5-5534e5e01442-otUistvHUpPR7s880joybQ@public.gmane.org

author
#4 lore raw

Oops, the changes were made by a remote windows editor which added the executable bit wrongly. Thanks for the remind. Will pay attention to it.

Regards,
Evan

Quoted 14 lines

-----Original Message-----
From: Michel Dänzer [mailto:[email protected]]
Sent: Friday, July 28, 2017 4:38 PM
To: Quan, Evan <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 2/3] drm/amd/powerplay: updated vega10 fan control

Quoted 6 lines · Evan Quan
Change-Id Ifbeb1f0c8e195cc9cb1e9cff975284d96d49b193
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
 mode change 100644 => 100755
Quoted 8 lines

drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

Please fix your setup not to set executable bits for source code files.

--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): DM5PR1201MB2489D8E33B172D10BE28878EE4BF0-grEf7a3NxMAAZHT/xKzwlGrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/[email protected]

Reviewed-by
#6 lore raw
Quoted 2 lines · Evan

Oops, the changes were made by a remote windows editor which added the executable bit wrongly. Thanks for the remind. Will pay attention to it.

With the mode fixed, the patch is:

Quoted 22 lines

Regards,
Evan

Quoted 19 lines

-----Original Message-----
From: Michel Dänzer [mailto:[email protected]]
Sent: Friday, July 28, 2017 4:38 PM
To: Quan, Evan <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 2/3] drm/amd/powerplay: updated vega10 fan control

Quoted 6 lines · Evan Quan
Change-Id Ifbeb1f0c8e195cc9cb1e9cff975284d96d49b193
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
 mode change 100644 => 100755

drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

Please fix your setup not to set executable bits for source code files.

Quoted 7 lines
Quoted 3 lines

--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#7 lore raw
In reply to a message not in the archive
Quoted 2 lines · Evan Quan
Change-Id Ifbeb1f0c8e195cc9cb1e9cff975284d96d49b193
Quoted 38 lines
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
 mode change 100644 => 100755 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c +1 -5
old mode 100644
new mode 100755
index 7bb4e46..ace1aca
@@ -321,10 +321,7 @@ int vega10_fan_ctrl_reset_fan_speed_to_default(struct pp_hwmgr *hwmgr)
 
 	if (phm_cap_enabled(hwmgr->platform_descriptor.platformCaps,
 			PHM_PlatformCaps_MicrocodeFanControl)) {
-		result = vega10_fan_ctrl_set_static_mode(hwmgr,
-				FDO_PWM_MODE_STATIC);
-		if (!result)
-			result = vega10_fan_ctrl_start_smc_fan_control(hwmgr);
+		result = vega10_fan_ctrl_start_smc_fan_control(hwmgr);
 	} else
 		result = vega10_fan_ctrl_set_default_mode(hwmgr);
 
@@ -633,7 +630,6 @@ int tf_vega10_thermal_start_smc_fan_control(struct pp_hwmgr *hwmgr,
 	if (phm_cap_enabled(hwmgr->platform_descriptor.platformCaps,
 			PHM_PlatformCaps_MicrocodeFanControl)) {
 		vega10_fan_ctrl_start_smc_fan_control(hwmgr);
-		vega10_fan_ctrl_set_static_mode(hwmgr, FDO_PWM_MODE_STATIC);
 	}
 
 	return 0;
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx