Skip to contentSkip to conversation

staging: lustre: declare fiemap_for_stripe static

PATCH In review David Wittman 2 participants 2 messages Aug 2, 2017 – Aug 3, 2017 Staging

lore
Share & tools
lore

David Wittman

author
#0 lore raw

PATCH 1/1 staging: lustre: declare fiemap_for_stripe static

Declare fiemap_for_stripe as static to fix sparse warnings:

Quoted 2 lines

warning: symbol 'fiemap_for_stripe' was not declared. Should it be static?

Signed-off-by David Wittman <[email protected]>
---
 drivers/staging/lustre/lustre/lov/lov_object.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/lustre/lustre/lov/lov_object.c +5 -5
index 8fc0bcc..334ecb1 100644
@@ -1141,11 +1141,11 @@ struct fiemap_state {
 	bool		fs_enough;
 };
 
-int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
-		      struct lov_stripe_md *lsm,
-		      struct fiemap *fiemap, size_t *buflen,
-		      struct ll_fiemap_info_key *fmkey, int stripeno,
-		      struct fiemap_state *fs)
+static int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
+			     struct lov_stripe_md *lsm,
+			     struct fiemap *fiemap, size_t *buflen,
+			     struct ll_fiemap_info_key *fmkey, int stripeno,
+			     struct fiemap_state *fs)
 {
 	struct cl_object *subobj;
 	struct lov_obd *lov = lu2lov_dev(obj->co_lu.lo_dev)->ld_lov;
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines

Declare fiemap_for_stripe as static to fix sparse warnings:

Quoted 2 lines

warning: symbol 'fiemap_for_stripe' was not declared. Should it be static?

Acked-by James Simmons <[email protected]>
Quoted 34 lines
Signed-off-by David Wittman <[email protected]>
---
 drivers/staging/lustre/lustre/lov/lov_object.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/lustre/lustre/lov/lov_object.c +5 -5
index 8fc0bcc..334ecb1 100644
@@ -1141,11 +1141,11 @@ struct fiemap_state {
 	bool		fs_enough;
 };
 
-int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
-		      struct lov_stripe_md *lsm,
-		      struct fiemap *fiemap, size_t *buflen,
-		      struct ll_fiemap_info_key *fmkey, int stripeno,
-		      struct fiemap_state *fs)
+static int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
+			     struct lov_stripe_md *lsm,
+			     struct fiemap *fiemap, size_t *buflen,
+			     struct ll_fiemap_info_key *fmkey, int stripeno,
+			     struct fiemap_state *fs)
 {
 	struct cl_object *subobj;
 	struct lov_obd *lov = lu2lov_dev(obj->co_lu.lo_dev)->ld_lov;
Signature · 6 lines
2.7.4

_______________________________________________
devel mailing list
devel at linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel